fix: add unit tests

Author: Fatme

test/ios-project-service.ts

@@ -1055,3 +1055,128 @@ describe("Merge Project XCConfig files", () => {
 		}
 	});
 });
+
+describe("buildProject", () => {
+	let xcodeBuildCommandArgs: string[] = [];
+
+	function setup(data: { frameworkVersion: string, deploymentTarget: string, devices?: Mobile.IDevice[] }): IInjector {
+		const projectPath = "myTestProjectPath";
+		const projectName = "myTestProjectName";
+		const testInjector = createTestInjector(projectPath, projectName);
+
+		const childProcess = testInjector.resolve("childProcess");
+		childProcess.spawnFromEvent = (command: string, args: string[]) => {
+			if (command === "xcodebuild" && args[0] !== "-exportArchive") {
+				xcodeBuildCommandArgs = args;
+			}
+		};
+
+		const projectDataService = testInjector.resolve("projectDataService");
+		projectDataService.getNSValue = (projectDir: string, propertyName: string) => {
+			if (propertyName === "tns-ios") {
+				return {
+					name: "tns-ios",
+					version: data.frameworkVersion
+				};
+			}
+		};
+
+		const projectData = testInjector.resolve("projectData");
+		projectData.appResourcesDirectoryPath = path.join(projectPath, "app", "App_Resources");
+
+		const devicesService = testInjector.resolve("devicesService");
+		devicesService.initialize = () => ({});
+		devicesService.getDeviceInstances = () => data.devices || [];
+
+		const xCConfigService = testInjector.resolve("xCConfigService");
+		xCConfigService.readPropertyValue = (projectDir: string, propertyName: string) => {
+			if (propertyName === "IPHONEOS_DEPLOYMENT_TARGET") {
+				return data.deploymentTarget;
+			}
+		};
+
+		const pbxprojDomXcode = testInjector.resolve("pbxprojDomXcode");
+		pbxprojDomXcode.Xcode = {
+			open: () => ({
+				getSigning: () => ({}),
+				setAutomaticSigningStyle: () => ({}),
+				save: () => ({})
+			})
+		};
+
+		const iOSProvisionService = testInjector.resolve("iOSProvisionService");
+		iOSProvisionService.getDevelopmentTeams = () => ({});
+		iOSProvisionService.getTeamIdsWithName = () => ({});
+
+		return testInjector;
+	}
+
+	function executeTests(testCases: any[], data: { buildForDevice: boolean }) {
+		_.each(testCases, testCase => {
+			it(`${testCase.name}`, async () => {
+				const testInjector = setup({ frameworkVersion: testCase.frameworkVersion, deploymentTarget: testCase.deploymentTarget });
+				const projectData: IProjectData = testInjector.resolve("projectData");
+
+				const iOSProjectService = <IOSProjectService>testInjector.resolve("iOSProjectService");
+				(<any>iOSProjectService).getExportOptionsMethod = () => ({});
+				await iOSProjectService.buildProject("myProjectRoot", projectData, <any>{ buildForDevice: data.buildForDevice });
+
+				const archsItem = xcodeBuildCommandArgs.find(item => item.startsWith("ARCHS="));
+				if (testCase.expectedArchs) {
+					const archsValue = archsItem.split("=")[1];
+					assert.deepEqual(archsValue, testCase.expectedArchs);
+				} else {
+					assert.deepEqual(undefined, archsItem);
+				}
+			});
+		});
+	}
+
+	describe("for device", () => {
+		afterEach(() => {
+			xcodeBuildCommandArgs = [];
+		});
+
+		const testCases = <any[]>[{
+			name: "shouldn't exclude armv7 architecture when deployment target 10",
+			frameworkVersion: "5.0.0",
+			deploymentTarget: "10.0",
+			expectedArchs: "armv7 arm64"
+		}, {
+			name: "should exclude armv7 architecture when deployment target is 11",
+			frameworkVersion: "5.0.0",
+			deploymentTarget: "11.0",
+			expectedArchs: "arm64"
+		}, {
+			name: "shouldn't pass architecture to xcodebuild command when frameworkVersion is 5.1.0",
+			frameworkVersion: "5.1.0",
+			deploymentTarget: "11.0"
+		}];
+
+		executeTests(testCases, { buildForDevice: true });
+	});
+
+	describe("for simulator", () => {
+		afterEach(() => {
+			xcodeBuildCommandArgs = [];
+		});
+
+		const testCases = [{
+			name: "shouldn't exclude i386 architecture when deployment target is 10",
+			frameworkVersion: "5.0.0",
+			deploymentTarget: "10.0",
+			expectedArchs: "i386 x86_64"
+		}, {
+			name: "should exclude i386 architecture when deployment target is 11",
+			frameworkVersion: "5.0.0",
+			deploymentTarget: "11.0",
+			expectedArchs: "x86_64"
+		}, {
+			name: "shouldn't pass architecture to xcodebuild command when frameworkVersion is 5.1.0",
+			frameworkVersion: "5.1.0",
+			deploymentTarget: "11.0"
+		}];
+
+		executeTests(testCases, { buildForDevice: false });
+	});
+});

test/stubs.ts

@@ -467,6 +467,9 @@ export class PlatformProjectServiceStub extends EventEmitter implements IPlatfor
 	getPluginPlatformsFolderPath(pluginData: IPluginData, platform: string): string {
 		return "";
 	}
+	getDeploymentTarget(projectData: IProjectData): IDeploymentTargetData {
+		return;
+	}
 }
 
 export class PlatformsDataStub extends EventEmitter implements IPlatformsData {
@@ -828,6 +831,10 @@ export class PlatformServiceStub extends EventEmitter implements IPlatformServic
 		return true;
 	}
 
+	public async validateInstall(device: Mobile.IDevice): Promise<void> {
+		return;
+	}
+
 	public installApplication(device: Mobile.IDevice, options: IRelease): Promise<void> {
 		return Promise.resolve();
 	}