Skip to content

Commit 1060aaa

Browse files
committed
fix: change ksplay to kspreview schema
1 parent 27ca961 commit 1060aaa

File tree

4 files changed

+10
-10
lines changed

4 files changed

+10
-10
lines changed

lib/services/livesync/playground/preview-qr-code-service.ts

+1-1
Original file line numberDiff line numberDiff line change
@@ -16,7 +16,7 @@ export class PreviewQrCodeService implements IPreviewQrCodeService {
1616

1717
@exported("previewQrCodeService")
1818
public async getPlaygroundAppQrCode(options?: IPlaygroundAppQrCodeOptions): Promise<IDictionary<IQrCodeImageData>> {
19-
const { projectDir } = options;
19+
const { projectDir } = options || <any>{ };
2020
const result = Object.create(null);
2121

2222
if (!options || !options.platform || this.$mobileHelper.isAndroidPlatform(options.platform)) {

lib/services/livesync/playground/preview-schema-service.ts

+2-2
Original file line numberDiff line numberDiff line change
@@ -13,8 +13,8 @@ export class PreviewSchemaService implements IPreviewSchemaService {
1313
subscribeKey: PubnubKeys.SUBSCRIBE_KEY,
1414
default: true
1515
},
16-
"ksplay": {
17-
name: "ksplay",
16+
"kspreview": {
17+
name: "kspreview",
1818
scannerAppId: "com.kinvey.scanner",
1919
scannerAppStoreId: "1263543946",
2020
previewAppId: "com.kinvey.preview",

test/services/playground/preview-schema-service.ts

+5-5
Original file line numberDiff line numberDiff line change
@@ -24,8 +24,8 @@ const nsPlaySchema = {
2424
default: true
2525
};
2626

27-
const ksPlaySchema = {
28-
name: 'ksplay',
27+
const ksPreviewSchema = {
28+
name: 'kspreview',
2929
scannerAppId: 'com.kinvey.scanner',
3030
scannerAppStoreId: '1263543946',
3131
previewAppId: 'com.kinvey.preview',
@@ -56,9 +56,9 @@ describe("PreviewSchemaService", () => {
5656
expectedSchema: nsPlaySchema
5757
},
5858
{
59-
name: "should return ksplay schema when { 'previewAppSchema': 'ksplay' } in nsconfig",
60-
previewAppSchema: "ksplay",
61-
expectedSchema: ksPlaySchema
59+
name: "should return kspreview schema when { 'previewAppSchema': 'kspreview' } in nsconfig",
60+
previewAppSchema: "kspreview",
61+
expectedSchema: ksPreviewSchema
6262
},
6363
{
6464
name: "should throw an error when invalid previewAppSchema is specified in nsconfig",

test/services/preview-sdk-service.ts

+2-2
Original file line numberDiff line numberDiff line change
@@ -54,8 +54,8 @@ describe('PreviewSdkService', () => {
5454
},
5555
{
5656
name: "should return the schema from nsconfig",
57-
schemaFromNsConfig: "ksplay",
58-
expectedSchemaName: "ksplay"
57+
schemaFromNsConfig: "kspreview",
58+
expectedSchemaName: "kspreview"
5959
},
6060
{
6161
name: "should return the default schema",

0 commit comments

Comments
 (0)