Merge pull request #4426 from NativeScript/tivanova/fix-sporadic-hang-cloud-builds

fix: retry stuck requests

Author: tsvetie

lib/common/http-client.ts

@@ -1,5 +1,6 @@
 import * as url from "url";
 import { EOL } from "os";
+import { TLSSocket } from "tls";
 import * as helpers from "./helpers";
 import * as zlib from "zlib";
 import * as util from "util";
@@ -105,8 +106,6 @@ export class HttpClient implements Server.IHttpClient {
 
 		const result = new Promise<Server.IResponse>((resolve, reject) => {
 			let timerId: number;
-			let stuckRequestTimerId: number;
-			let hasResponse = false;
 			const cleanupRequestData: ICleanupRequestData = Object.create({ timers: [] });
 			this.cleanupData.push(cleanupRequestData);
 
@@ -133,17 +132,6 @@ export class HttpClient implements Server.IHttpClient {
 			const requestObj = request(options);
 			cleanupRequestData.req = requestObj;
 
-			if (options.method !== "PUT" && options.method !== "POST") {
-				stuckRequestTimerId = setTimeout(() => {
-					clearTimeout(stuckRequestTimerId);
-					stuckRequestTimerId = null;
-					if (!hasResponse) {
-						this.setResponseResult(promiseActions, cleanupRequestData, { err: new Error(HttpClient.STUCK_REQUEST_ERROR_MESSAGE) });
-					}
-				}, options.timeout || HttpClient.STUCK_REQUEST_TIMEOUT);
-				cleanupRequestData.timers.push(stuckRequestTimerId);
-			}
-
 			requestObj
 				.on("error", (err: IHttpRequestError) => {
 					this.$logger.trace("An error occurred while sending the request:", err);
@@ -158,9 +146,22 @@ export class HttpClient implements Server.IHttpClient {
 					err.message = errorMessage || err.message;
 					this.setResponseResult(promiseActions, cleanupRequestData, { err });
 				})
+				.on("socket", (s: TLSSocket) => {
+					let stuckRequestTimerId: number;
+
+					stuckRequestTimerId = setTimeout(() => {
+						this.setResponseResult(promiseActions, cleanupRequestData, { err: new Error(HttpClient.STUCK_REQUEST_ERROR_MESSAGE) });
+					}, options.timeout || HttpClient.STUCK_REQUEST_TIMEOUT);
+
+					cleanupRequestData.timers.push(stuckRequestTimerId);
+
+					s.once("secureConnect", () => {
+						clearTimeout(stuckRequestTimerId);
+						stuckRequestTimerId = null;
+					});
+				})
 				.on("response", (response: Server.IRequestResponseData) => {
 					cleanupRequestData.res = response;
-					hasResponse = true;
 					let lastChunkTimestamp = Date.now();
 					cleanupRequestData.stuckResponseIntervalId = setInterval(() => {
 						if (Date.now() - lastChunkTimestamp > HttpClient.STUCK_RESPONSE_CHECK_INTERVAL) {