make default debug-ios behavior to use chrome-devtools instead of safari web inspector

Author: petekanev

docs/man_pages/project/testing/debug-ios.md

@@ -26,7 +26,8 @@ While debugging, prints the output from the application in the console and watch
 * `--timeout` - Sets the number of seconds that NativeScript CLI will wait for the simulator/device to boot. If not set, the default timeout is 90 seconds.
 * `--no-watch` - If set, changes in your code will not be reflected during the execution of this command.
 * `--clean` - If set, forces rebuilding the native application.
-* `--chrome` - Allows debugging in Chrome Developer Tools. If set Safari Web Inspector is not started and debugging is attached to Chrome Developer Tools.
+* `--chrome` - Deprecated - default behavior uses '--chrome' implicitly. Allows debugging in Chrome Developer Tools. If set, Safari Web Inspector is not started and debugging is attached to Chrome Developer Tools.
+* `--inspector` - If set, the developer tools in the Safari Web Inspector are used for debugging the application.
 
 ### Attributes
 * `<Device ID>` is the device identifier of the target device as listed by `$ tns device ios`

lib/declarations.d.ts

@@ -393,6 +393,7 @@ interface IOptions extends ICommonOptions, IBundle, IPlatformTemplate, IEmulator
 	syncAllFiles: boolean;
 	liveEdit: boolean;
 	chrome: boolean;
+	inspector: boolean; // the counterpart to --chrome
 }
 
 interface IEnvOptions {

lib/definitions/debug.d.ts

@@ -82,6 +82,11 @@ interface IDebugOptions {
 	 * Default value is 02e6bde1bbe34e43b309d4ef774b1168d25fd024 which corresponds to 55.0.2883 Chrome version
 	 */
 	devToolsCommit?: string;
+
+	/**
+	 * Defines if the iOS App Inspector should be used instead of providing URL to debug the application with Chrome DevTools
+	 */
+	inspector?: boolean;
 }
 
 /**

lib/services/ios-debug-service.ts

@@ -25,7 +25,6 @@ export class IOSDebugService extends DebugServiceBase implements IPlatformDebugS
 		private $platformService: IPlatformService,
 		private $iOSEmulatorServices: Mobile.IEmulatorPlatformServices,
 		private $childProcess: IChildProcess,
-		private $hostInfo: IHostInfo,
 		private $logger: ILogger,
 		private $errors: IErrors,
 		private $npmInstallationManager: INpmInstallationManager,
@@ -201,14 +200,17 @@ export class IOSDebugService extends DebugServiceBase implements IPlatformDebugS
 	}
 
 	private async wireDebuggerClient(debugData: IDebugData, debugOptions: IDebugOptions, device?: Mobile.IiOSDevice): Promise<string> {
-		if (debugOptions.chrome || !this.$hostInfo.isDarwin) {
-			this._socketProxy = await this.$socketProxyFactory.createWebSocketProxy(this.getSocketFactory(device));
-
-			return this.getChromeDebugUrl(debugOptions, this._socketProxy.options.port);
-		} else {
+		if (debugOptions.inspector) {
 			this._socketProxy = await this.$socketProxyFactory.createTCPSocketProxy(this.getSocketFactory(device));
 			await this.openAppInspector(this._socketProxy.address(), debugData, debugOptions);
 			return null;
+		} else {
+			if (debugOptions.chrome) {
+				this.$logger.info("'--chrome' is the default behavior. Use --inspector to debug iOS applications using the Safari Web Inspector.");
+			}
+
+			this._socketProxy = await this.$socketProxyFactory.createWebSocketProxy(this.getSocketFactory(device));
+			return this.getChromeDebugUrl(debugOptions, this._socketProxy.options.port);
 		}
 	}
 

test/services/ios-debug-service.ts

@@ -18,7 +18,7 @@ class IOSDebugServiceInheritor extends IOSDebugService {
 		$iOSSocketRequestExecutor: IiOSSocketRequestExecutor,
 		$processService: IProcessService,
 		$socketProxyFactory: ISocketProxyFactory) {
-		super(<any>{}, $devicesService, $platformService, $iOSEmulatorServices, $childProcess, $hostInfo, $logger, $errors,
+		super(<any>{}, $devicesService, $platformService, $iOSEmulatorServices, $childProcess, $logger, $errors,
 			$npmInstallationManager, $iOSNotification, $iOSSocketRequestExecutor, $processService, $socketProxyFactory);
 	}