Write tests for nativescript-cli/issues/1548 #116

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Open

dtopuzov opened this issue Apr 25, 2018 · 1 comment

Assignees

Contributor

dtopuzov commented Apr 25, 2018

Write tests for NativeScript/nativescript-cli#1548

What to check:

If no simulators are running we start the correct one when we pass sdk and device options.
If simulator is running and we specify another one we should start it (and keep the previous open).

We should be careful for this when writing tests:

For some tests we need specific simulator because we compare images (livesync tests).
If we start another one we should ensure default we need is started before other tests.
If should stop simulator we start at some point (we need to get as less resources on the machine as we can and for sure we should kill all the simulators when all tests are complete).

Contributor Author

dtopuzov commented Apr 25, 2018

As part of this task we can also add test for this specific case:
NativeScript/nativescript-cli#2131

miroslavaivanova self-assigned this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment