Skip to content

Commit ee03417

Browse files
committed
Fix android ng tests
1 parent 8c963c3 commit ee03417

File tree

4 files changed

+12
-34
lines changed

4 files changed

+12
-34
lines changed

core/tns/angular_helper.py

Lines changed: 0 additions & 15 deletions
This file was deleted.

core/tns/tns.py

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -221,6 +221,10 @@ def create_app_ng(app_name, attributes={}, log_trace=False, assert_success=True,
221221
if Npm.version() < 5:
222222
assert "nativescript-angular" in output
223223
assert File.exists(os.path.join(app_name, 'node_modules', 'nativescript-theme-core'))
224+
package_json = File.read(os.path.join(app_name, 'package.json'))
225+
assert "tns-core-modules" in package_json
226+
assert "nativescript-angular" in package_json
227+
assert "nativescript-dev-typescript" in package_json
224228

225229
return output
226230

Lines changed: 7 additions & 18 deletions
Original file line numberDiff line numberDiff line change
@@ -1,13 +1,10 @@
11
import os
22

33
from core.base_class.BaseClass import BaseClass
4-
from core.osutils.file import File
54
from core.osutils.folder import Folder
65
from core.settings.settings import ANDROID_RUNTIME_PATH, \
76
ANDROID_KEYSTORE_PASS, ANDROID_KEYSTORE_ALIAS, ANDROID_KEYSTORE_PATH, ANDROID_KEYSTORE_ALIAS_PASS
87
from core.tns.tns import Tns
9-
from core.tns import angular_helper as angular
10-
from core.settings.strings import *
118

129

1310
class BuildAndroidNGTests(BaseClass):
@@ -25,21 +22,13 @@ def tearDownClass(cls):
2522
Folder.cleanup(cls.app_name)
2623

2724
def test_001_build_android_ng_project(self):
28-
angular.assert_angular_project(self.app_name)
2925
Tns.build_android(attributes={"--path": self.app_name})
30-
assert File.exists(os.path.join(self.app_name, debug_apk_path))
3126

3227
def test_200_build_android_ng_project_release(self):
33-
print ANDROID_KEYSTORE_PATH
34-
output = Tns.build_android(attributes={"--keyStorePath": ANDROID_KEYSTORE_PATH,
35-
"--keyStorePassword": ANDROID_KEYSTORE_PASS,
36-
"--keyStoreAlias": ANDROID_KEYSTORE_ALIAS,
37-
"--keyStoreAliasPassword": ANDROID_KEYSTORE_ALIAS_PASS,
38-
"--release": "",
39-
"--path": self.app_name
40-
})
41-
assert successfully_prepared in output
42-
assert build_successful in output
43-
44-
assert successfully_built in output
45-
assert File.exists(os.path.join(self.app_name, release_apk_path))
28+
Tns.build_android(attributes={"--keyStorePath": ANDROID_KEYSTORE_PATH,
29+
"--keyStorePassword": ANDROID_KEYSTORE_PASS,
30+
"--keyStoreAlias": ANDROID_KEYSTORE_ALIAS,
31+
"--keyStoreAliasPassword": ANDROID_KEYSTORE_ALIAS_PASS,
32+
"--release": "",
33+
"--path": self.app_name
34+
})

tests/build/android/build_android_tests.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -130,7 +130,7 @@ def test_201_build_android_with_additional_prepare(self):
130130
def test_202_build_android_with_log_trace_and_platform_not_added_or_empty(self):
131131
"""'tns build android' with log trace options should output more logs."""
132132
Tns.create_app(self.app_no_platform)
133-
output = Tns.build_android(attributes={"--path": self.app_no_platform, "--log trace": ""})
133+
output = Tns.build_android(attributes={"--path": self.app_no_platform}, log_trace=True)
134134

135135
# Assert log trace show gradle logs
136136
assert "[DEBUG]" in output

0 commit comments

Comments
 (0)