Add tests for NativeScript/nativescript-cli#2825

Author: dtopuzov

tests/emulator/run_android_tests.py

@@ -461,6 +461,20 @@ def test_350_tns_run_android_should_start_emulator(self):
         else:
             raise nose.SkipTest('This test is not valid when devices are connected.')
 
+    def test_390_tns_run_android_should_warn_if_package_ids_do_not_match(self):
+        """
+        If bundle identifiers in package.json and app.gradle do not match CLI should warn the user.
+        """
+        app_gradle = os.path.join(self.app_name, 'app', 'App_Resources','Android','app.gradle')
+        File.replace(file_path=app_gradle, str1='org.nativescript.' + self.app_name, str2='org.nativescript.MyApp')
+        File.replace(file_path=app_gradle, str1='__PACKAGE__', str2='org.nativescript.MyApp')
+        assert "org.nativescript.MyApp" in File.read(app_gradle), "Failed to replace bundle identifier."
+
+        output = Tns.run_android(attributes={'--path': self.app_name, '--justlaunch': ''})
+        assert "The Application identifier is different from the one inside 'package.json' file." in output
+        assert "NativeScript CLI might not work properly." in output
+        assert "BUILD SUCCESSFUL" in output
+
     @unittest.skipIf(CURRENT_OS == OSType.LINUX, "`shell cp -r` fails for some reason on emulators on Linux.")
     def test_400_tns_run_android_respect_adb_errors(self):
         """

tests/simulator/run_ios_tests.py

@@ -42,7 +42,7 @@ def setUpClass(cls):
         BaseClass.setUpClass(logfile)
         Emulator.stop()
         Simulator.stop()
-        cls.SIMULATOR_ID = Simulator.start(name=SIMULATOR_NAME)
+        cls.SIMULATOR_ID = Simulator.ensure_available(simulator_name=SIMULATOR_NAME)
         Folder.cleanup(cls.app_name)
 
     def setUp(self):
@@ -359,6 +359,20 @@ def test_370_tns_run_plugin_add(self):
         assert 'BUILD SUCCEEDED' not in File.read(log), "Change of CSS files after plugin add is not incremental!"
         File.write(file_path=log, text="")  # Clean log file
 
+    def test_390_tns_run_ios_should_warn_if_package_ids_do_not_match(self):
+        """
+        If bundle identifiers in package.json and Info.plist do not match CLI should warn the user.
+        """
+        str1 = "<string>${EXECUTABLE_NAME}</string>"
+        str2 = "<string>${EXECUTABLE_NAME}</string>" \
+               "<key>CFBundleIdentifier</key>" \
+               "<string>org.nativescript.myapp</string>"
+        info = os.path.join(self.app_name, 'app', 'App_Resources','iOS','Info.plist')
+        File.replace(file_path=info, str1=str1, str2=str2)
+        output = Tns.run_ios(attributes={'--path': self.app_name, '--justlaunch': ''})
+        assert "[WARNING]: The CFBundleIdentifier key inside the 'Info.plist' will be overriden" in output
+        assert "Successfully synced application org.nativescript.TestApp" in output
+
     def test_400_tns_run_on_folder_with_spaces(self):
         """
         `tns run ios` for apps with spaces