Add test for NativeScript/nativescript-cli#3054

Author: dtopuzov

core/tns/tns.py

@@ -307,7 +307,7 @@ def plugin_add(name, attributes={}, log_trace=False, assert_success=True, tns_pa
         output = Tns.run_tns_command("plugin add " + name, attributes=attributes, log_trace=log_trace,
                                      tns_path=tns_path)
         if assert_success:
-            short_name = name.replace("@" + TAG, "").replace(".tgz", "").split(os.sep)[-1]
+            short_name = name.rsplit('@', 1)[0].replace(".tgz", "").split(os.sep)[-1]
             assert "Successfully installed plugin {0}".format(short_name) in output
         return output
 

tests/build/android/plugin_android_tests.py

@@ -167,6 +167,15 @@ def test_300_build_app_with_plugin_added_outside_project(self):
         output = Tns.run_tns_command("plugin", attributes={"--path": self.app_name})
         assert tns_plugin in output
 
+    def test_390_plugin_with_promise_in_hooks(self):
+        Tns.create_app(self.app_name)
+        Tns.plugin_add("[email protected]", attributes={"--path": self.app_name})
+        output = Tns.prepare_android(attributes={"--path": self.app_name}, assert_success=False)
+        assert "Failed to execute hook" in output
+        assert "nativescript-fabric.js" in output
+        assert "TypeError" not in output
+        assert "Cannot read property" not in output
+
     def test_400_plugin_add_not_existing_plugin(self):
         Tns.create_app(self.app_name)
         output = Tns.plugin_add("fakePlugin", attributes={"--path": self.app_name}, assert_success=False)

tests/build/ios/build_ios_provision_tests.py

@@ -46,13 +46,13 @@ def test_200_build_ios_list_provisions(self):
         assert PROVISIONING in output
         assert DEVELOPMENT_TEAM in output
 
-    @unittest.skipIf(Xcode.get_version() >= 9.0,
+    @unittest.skipIf(float(Xcode.get_version()) >= 9.0,
                      "Skip on Xcode9 because of https://github.com/NativeScript/nativescript-cli/issues/3046")
     def test_201_build_ios_with_provision(self):
         build_attributes = {"--path": self.app_name, "--forDevice": "", "--release": "", "--provision": PROVISIONING}
         Tns.build_ios(attributes=build_attributes)
 
-    @unittest.skipIf(Xcode.get_version() >= 9.0,
+    @unittest.skipIf(float(Xcode.get_version()) >= 9.0,
                      "Skip on Xcode9 because of https://github.com/NativeScript/nativescript-cli/issues/3046")
     def test_202_build_ios_with_distribution_provision(self):
         build_attributes = {"--path": self.app_name, "--forDevice": "", "--release": "",