Skip to content

fix(forms): disable onTouch for date, number and selectedIndex value accessors #986

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 13, 2017
Merged

fix(forms): disable onTouch for date, number and selectedIndex value accessors #986

merged 1 commit into from
Sep 13, 2017

Conversation

sis0k0
Copy link
Contributor

@sis0k0 sis0k0 commented Sep 8, 2017

view-base's touch event is not suitable for triggering ngOnTouch states for iOS
and is causing several issues, such as overriding the change event.

related #804
related #866
fixes #887

@sis0k0
fix(forms): disable onTouch for date, number and selectedIndex value
af064d8 
accessors

`touch` event is not suitable for triggering ngOnTouch classes for iOS
and is causing several issues, such as overriding the change event.

related #804
related #866
fixes #887
@sis0k0 sis0k0 added this to the 4.3 milestone Sep 8, 2017
@sis0k0 sis0k0 self-assigned this Sep 8, 2017
@sis0k0 sis0k0 requested a review from vakrilov September 8, 2017 17:46
@ghost ghost added the in progress label Sep 8, 2017
@sis0k0 sis0k0 merged commit b4b5ef6 into master Sep 13, 2017
@sis0k0 sis0k0 deleted the vlaeva/revert-on-touched branch September 13, 2017 12:44
@ghost ghost removed the in progress label Sep 13, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vakrilov vakrilov vakrilov approved these changes

Assignees

@sis0k0 sis0k0

Labels
None yet
Projects
None yet
Milestone
4.4
Development

Successfully merging this pull request may close these issues.

[Angular] Slider with two-way binding remains stuck after first usage
2 participants
@sis0k0 @vakrilov