From 64017fa27d1f77fab6755373f6c5ba6d2d000064 Mon Sep 17 00:00:00 2001 From: sis0k0 Date: Mon, 13 Mar 2017 18:10:29 +0200 Subject: [PATCH] refactor: stop exporting NativeScriptModule from platform Importing NativeScriptModule from "nativescript-angular/platform" leads to including @angular/compiler in the bundle when doing AoT compilation with webpack. Import from "nativescript-angular/nativescript.module" should be used instead. BREAKING CHANGE: User applications cannot import NativeScriptModule from "nativescript-angular/platform" anymore. Migration: Before: ``` import { NativeScriptModule } from "nativescript-angular/platform"; ``` After ``` import { NativeScriptModule } from "nativescript-angular/nativescript.module"; ``` --- nativescript-angular/platform.ts | 2 -- tests/app/lazy-loaded.module.ts | 2 +- tests/app/main.ts | 3 ++- tests/app/snippets/navigation/page-outlet.ts | 3 ++- tests/app/tests/test-app.ts | 3 ++- 5 files changed, 7 insertions(+), 6 deletions(-) diff --git a/nativescript-angular/platform.ts b/nativescript-angular/platform.ts index 04110398e..42cfd3984 100644 --- a/nativescript-angular/platform.ts +++ b/nativescript-angular/platform.ts @@ -33,8 +33,6 @@ import "./dom-adapter"; import { NativeScriptElementSchemaRegistry } from "./schema-registry"; import { FileSystemResourceLoader } from "./resource-loader"; -export { NativeScriptModule } from "./nativescript.module"; - export const NS_COMPILER_PROVIDERS = [ COMPILER_PROVIDERS, { diff --git a/tests/app/lazy-loaded.module.ts b/tests/app/lazy-loaded.module.ts index 85caabed9..aeffd82e1 100644 --- a/tests/app/lazy-loaded.module.ts +++ b/tests/app/lazy-loaded.module.ts @@ -1,5 +1,5 @@ import { NgModule } from '@angular/core'; -import { NativeScriptModule } from "nativescript-angular"; +import { NativeScriptModule } from "nativescript-angular/nativescript.module"; import { NativeScriptRouterModule } from "nativescript-angular/router"; import { SecondComponent } from './second.component'; diff --git a/tests/app/main.ts b/tests/app/main.ts index 32e122505..1e56c11d1 100644 --- a/tests/app/main.ts +++ b/tests/app/main.ts @@ -1,5 +1,6 @@ // "nativescript-angular/platform" import should be first in order to load some required settings (like globals and reflect-metadata) -import { NativeScriptModule, platformNativeScriptDynamic } from "nativescript-angular/platform"; +import { NativeScriptModule } from "nativescript-angular/nativescript.module"; +import { platformNativeScriptDynamic } from "nativescript-angular/platform"; import { NativeScriptRouterModule, NSModuleFactoryLoader } from "nativescript-angular/router"; import { NativeScriptFormsModule } from "nativescript-angular/forms"; import { AppComponent } from "./app.component"; diff --git a/tests/app/snippets/navigation/page-outlet.ts b/tests/app/snippets/navigation/page-outlet.ts index 2d9d8140d..abfde2259 100644 --- a/tests/app/snippets/navigation/page-outlet.ts +++ b/tests/app/snippets/navigation/page-outlet.ts @@ -2,7 +2,8 @@ import { TestApp, registerTestApp } from "../../tests/test-app"; import { ApplicationRef } from '@angular/core'; import { Router, NavigationStart, NavigationEnd } from "@angular/router"; // >> page-outlet-example -import { platformNativeScriptDynamic, NativeScriptModule } from "nativescript-angular/platform"; +import { platformNativeScriptDynamic } from "nativescript-angular/platform"; +import { NativeScriptModule } from "nativescript-angular/nativescript.module"; import { Component, NgModule } from '@angular/core'; import { NativeScriptRouterModule } from "nativescript-angular/router"; import { routes } from "./app.routes"; diff --git a/tests/app/tests/test-app.ts b/tests/app/tests/test-app.ts index dce7fc3b3..7bd8b072d 100644 --- a/tests/app/tests/test-app.ts +++ b/tests/app/tests/test-app.ts @@ -1,4 +1,5 @@ -import { NativeScriptModule, platformNativeScriptDynamic } from "nativescript-angular/platform"; +import { platformNativeScriptDynamic } from "nativescript-angular/platform"; +import { NativeScriptModule } from "nativescript-angular/nativescript.module"; import { NativeScriptRouterModule } from "nativescript-angular/router"; import { Type, Component, ComponentRef,