diff --git a/e2e/renderer/app/app-routing.module.ts b/e2e/renderer/app/app-routing.module.ts index 6e89eca70..61a49f6a5 100644 --- a/e2e/renderer/app/app-routing.module.ts +++ b/e2e/renderer/app/app-routing.module.ts @@ -1,5 +1,5 @@ import { NgModule, NO_ERRORS_SCHEMA } from "@angular/core"; -import { NativeScriptRouterModule } from "nativescript-angular/router"; +import { NativeScriptRouterModule, NSEmptyOutletComponent } from "nativescript-angular/router"; import { ActionBarDynamicItemsComponent } from "./action-bar/action-bar-dynamic-items.component"; import { ActionBarExtensionComponent } from "./action-bar/action-bar-extension.component"; @@ -54,6 +54,16 @@ export const routes = [ component: NestedPageComponent }] }, + { + path: "action-bar-visibility-never-lazy", + component: ActionBarVisibilityNeverComponent, + children: [{ + path: "nested", + outlet: "nested", + component: NSEmptyOutletComponent, + loadChildren:"~/page-router-outlet/nested-lazy-page.module#NestedLazyPageModule" + }] + }, { path: "action-bar-dynamic", component: ActionBarDynamicItemsComponent, @@ -111,7 +121,6 @@ export const navigatableComponents = [ ActionBarVisibilityAlwaysComponent, ActionBarVisibilityNeverComponent, ActionBarVisibilityAutoComponent, - NestedPageComponent, TabItemBindingComponent, diff --git a/e2e/renderer/app/app.module.ts b/e2e/renderer/app/app.module.ts index 94a20f26e..1f170798e 100644 --- a/e2e/renderer/app/app.module.ts +++ b/e2e/renderer/app/app.module.ts @@ -11,6 +11,8 @@ import { ItemsService } from "./items.service"; import { rendererTraceCategory, viewUtilCategory, bootstrapCategory } from "nativescript-angular/trace"; import { addCategories, enable, categories } from "tns-core-modules/trace"; +import { SharedModule } from "./shared.module"; + addCategories(bootstrapCategory); addCategories(rendererTraceCategory); addCategories(viewUtilCategory); @@ -22,7 +24,7 @@ export class MyErrorHandler implements ErrorHandler { console.log("### ErrorHandler Error: " + error.toString()); console.log("### ErrorHandler Stack: " + error.stack); } -} +} @NgModule({ @@ -38,6 +40,7 @@ export class MyErrorHandler implements ErrorHandler { imports: [ NativeScriptModule, AppRoutingModule, + SharedModule ], schemas: [NO_ERRORS_SCHEMA], }) diff --git a/e2e/renderer/app/list.component.ts b/e2e/renderer/app/list.component.ts index 168370525..9996d5a79 100644 --- a/e2e/renderer/app/list.component.ts +++ b/e2e/renderer/app/list.component.ts @@ -9,6 +9,7 @@ import { Component } from "@angular/core"; + diff --git a/e2e/renderer/app/page-router-outlet/nested-lazy-page.module.ts b/e2e/renderer/app/page-router-outlet/nested-lazy-page.module.ts new file mode 100644 index 000000000..6a761a4ed --- /dev/null +++ b/e2e/renderer/app/page-router-outlet/nested-lazy-page.module.ts @@ -0,0 +1,20 @@ +import { NgModule, NO_ERRORS_SCHEMA } from "@angular/core"; +import { NativeScriptRouterModule } from "nativescript-angular/router"; +import { NativeScriptCommonModule } from "nativescript-angular/common"; +import { SharedModule } from "~/shared.module"; +import { NestedPageComponent } from "./nested-page.component"; + +@NgModule({ + imports: [ + SharedModule, + NativeScriptCommonModule, + NativeScriptRouterModule, + NativeScriptRouterModule.forChild([ + { path: "", component: NestedPageComponent } + ]) + ], + providers: [ + ], + schemas: [NO_ERRORS_SCHEMA] +}) +export class NestedLazyPageModule { } \ No newline at end of file diff --git a/e2e/renderer/app/shared.module.ts b/e2e/renderer/app/shared.module.ts new file mode 100644 index 000000000..b36208dc3 --- /dev/null +++ b/e2e/renderer/app/shared.module.ts @@ -0,0 +1,14 @@ +import { NgModule, NO_ERRORS_SCHEMA } from "@angular/core"; +import { NativeScriptRouterModule } from "nativescript-angular/router"; +import { NativeScriptCommonModule } from "nativescript-angular/common"; +import { NestedPageComponent } from "./page-router-outlet/nested-page.component"; + +@NgModule({ + imports: [ + NativeScriptCommonModule, + NativeScriptRouterModule + ], + declarations:[NestedPageComponent], + schemas: [NO_ERRORS_SCHEMA] +}) +export class SharedModule { } \ No newline at end of file diff --git a/e2e/renderer/e2e/page-router-outlet.e2e-spec.ts b/e2e/renderer/e2e/page-router-outlet.e2e-spec.ts index 8746c5707..ad79f6116 100644 --- a/e2e/renderer/e2e/page-router-outlet.e2e-spec.ts +++ b/e2e/renderer/e2e/page-router-outlet.e2e-spec.ts @@ -93,6 +93,52 @@ describe("page-router-outlet-scenario", () => { }); }); + describe("actionBarVisibility 'never' doesn't show action bars in lazy module page", async () => { + let imagePostFix = ""; + before(async () => { + driver = await createDriver(); + await driver.driver.resetApp(); + if (driver.isIOS && driver.nsCapabilities.device.name.toLowerCase().includes("x")) { + imagePostFix = "-lazy"; + } + }); + + afterEach(async function () { + if (this.currentTest.state === "failed") { + await driver.logTestArtifacts(this.currentTest.title); + } + }); + + it("should navigate to page", async () => { + const navigationButton = + await driver.findElementByAutomationText("ActionBarVisibility Never Lazy"); + await navigationButton.click(); + + await driver.findElementByAutomationText("ShowActionBar"); + }); + + it("should hide action bar by default", async () => { + const screenMatches = await driver.compareScreen(`actionBarVisibility-never-default${imagePostFix}`, 5); + assert(screenMatches); + }); + + it("should not show action bar when shown by page", async () => { + const showActionBarButton = await driver.findElementByAutomationText("ShowActionBar"); + showActionBarButton.click(); + + const screenMatches = await driver.compareScreen(`actionBarVisibility-never-shown${imagePostFix}`, 5); + assert(screenMatches); + }); + + it("should not do anything when hidden action bar by page", async () => { + const hideActionBarButton = await driver.findElementByAutomationText("HideActionBar"); + hideActionBarButton.click(); + + const screenMatches = await driver.compareScreen(`actionBarVisibility-never-hidden${imagePostFix}`, 5); + assert(screenMatches); + }); + }); + describe("actionBarVisibility 'auto' shows action bars based on page", async () => { before(async () => { driver = await createDriver(); diff --git a/e2e/renderer/e2e/resources/images/renderer/iPhone 7 110/actionBarVisibility-never-default-lazy_actual.png b/e2e/renderer/e2e/resources/images/renderer/iPhone 7 110/actionBarVisibility-never-default-lazy_actual.png new file mode 100644 index 000000000..ab50e264d Binary files /dev/null and b/e2e/renderer/e2e/resources/images/renderer/iPhone 7 110/actionBarVisibility-never-default-lazy_actual.png differ diff --git a/e2e/renderer/e2e/resources/images/renderer/iPhone 7 110/actionBarVisibility-never-hidden-lazy_actual.png b/e2e/renderer/e2e/resources/images/renderer/iPhone 7 110/actionBarVisibility-never-hidden-lazy_actual.png new file mode 100644 index 000000000..afe670a4f Binary files /dev/null and b/e2e/renderer/e2e/resources/images/renderer/iPhone 7 110/actionBarVisibility-never-hidden-lazy_actual.png differ diff --git a/e2e/renderer/e2e/resources/images/renderer/iPhone 7 110/actionBarVisibility-never-shown-lazy_actual.png b/e2e/renderer/e2e/resources/images/renderer/iPhone 7 110/actionBarVisibility-never-shown-lazy_actual.png new file mode 100644 index 000000000..afe670a4f Binary files /dev/null and b/e2e/renderer/e2e/resources/images/renderer/iPhone 7 110/actionBarVisibility-never-shown-lazy_actual.png differ diff --git a/e2e/renderer/e2e/resources/images/renderer/iPhone X 110/actionBarVisibility-never-default-lazy.png b/e2e/renderer/e2e/resources/images/renderer/iPhone X 110/actionBarVisibility-never-default-lazy.png new file mode 100644 index 000000000..9ebe2b597 Binary files /dev/null and b/e2e/renderer/e2e/resources/images/renderer/iPhone X 110/actionBarVisibility-never-default-lazy.png differ diff --git a/e2e/renderer/e2e/resources/images/renderer/iPhone X 110/actionBarVisibility-never-hidden-lazy.png b/e2e/renderer/e2e/resources/images/renderer/iPhone X 110/actionBarVisibility-never-hidden-lazy.png new file mode 100644 index 000000000..6ed7234b1 Binary files /dev/null and b/e2e/renderer/e2e/resources/images/renderer/iPhone X 110/actionBarVisibility-never-hidden-lazy.png differ diff --git a/e2e/renderer/e2e/resources/images/renderer/iPhone X 110/actionBarVisibility-never-shown-lazy.png b/e2e/renderer/e2e/resources/images/renderer/iPhone X 110/actionBarVisibility-never-shown-lazy.png new file mode 100644 index 000000000..6ed7234b1 Binary files /dev/null and b/e2e/renderer/e2e/resources/images/renderer/iPhone X 110/actionBarVisibility-never-shown-lazy.png differ diff --git a/e2e/renderer/e2e/resources/images/renderer/iPhone XR 12/actionBarVisibility-never-default-lazy.png b/e2e/renderer/e2e/resources/images/renderer/iPhone XR 12/actionBarVisibility-never-default-lazy.png new file mode 100644 index 000000000..e6afdad26 Binary files /dev/null and b/e2e/renderer/e2e/resources/images/renderer/iPhone XR 12/actionBarVisibility-never-default-lazy.png differ diff --git a/e2e/renderer/e2e/resources/images/renderer/iPhone XR 12/actionBarVisibility-never-hidden-lazy.png b/e2e/renderer/e2e/resources/images/renderer/iPhone XR 12/actionBarVisibility-never-hidden-lazy.png new file mode 100644 index 000000000..ac403f9f9 Binary files /dev/null and b/e2e/renderer/e2e/resources/images/renderer/iPhone XR 12/actionBarVisibility-never-hidden-lazy.png differ diff --git a/e2e/renderer/e2e/resources/images/renderer/iPhone XR 12/actionBarVisibility-never-shown-lazy.png b/e2e/renderer/e2e/resources/images/renderer/iPhone XR 12/actionBarVisibility-never-shown-lazy.png new file mode 100644 index 000000000..ac403f9f9 Binary files /dev/null and b/e2e/renderer/e2e/resources/images/renderer/iPhone XR 12/actionBarVisibility-never-shown-lazy.png differ diff --git a/e2e/renderer/e2e/resources/images/renderer/iPhone XS 12/actionBarVisibility-always-default.png b/e2e/renderer/e2e/resources/images/renderer/iPhone XS 12/actionBarVisibility-always-default.png index fc09b4860..bf236a332 100644 Binary files a/e2e/renderer/e2e/resources/images/renderer/iPhone XS 12/actionBarVisibility-always-default.png and b/e2e/renderer/e2e/resources/images/renderer/iPhone XS 12/actionBarVisibility-always-default.png differ diff --git a/e2e/renderer/e2e/resources/images/renderer/iPhone XS 12/actionBarVisibility-always-hidden.png b/e2e/renderer/e2e/resources/images/renderer/iPhone XS 12/actionBarVisibility-always-hidden.png index d68c4ec93..36532a957 100644 Binary files a/e2e/renderer/e2e/resources/images/renderer/iPhone XS 12/actionBarVisibility-always-hidden.png and b/e2e/renderer/e2e/resources/images/renderer/iPhone XS 12/actionBarVisibility-always-hidden.png differ diff --git a/e2e/renderer/e2e/resources/images/renderer/iPhone XS 12/actionBarVisibility-always-shown.png b/e2e/renderer/e2e/resources/images/renderer/iPhone XS 12/actionBarVisibility-always-shown.png index d68c4ec93..67a2d2515 100644 Binary files a/e2e/renderer/e2e/resources/images/renderer/iPhone XS 12/actionBarVisibility-always-shown.png and b/e2e/renderer/e2e/resources/images/renderer/iPhone XS 12/actionBarVisibility-always-shown.png differ diff --git a/e2e/renderer/e2e/resources/images/renderer/iPhone XS 12/actionBarVisibility-auto-default.png b/e2e/renderer/e2e/resources/images/renderer/iPhone XS 12/actionBarVisibility-auto-default.png index e43126a22..2db5cadce 100644 Binary files a/e2e/renderer/e2e/resources/images/renderer/iPhone XS 12/actionBarVisibility-auto-default.png and b/e2e/renderer/e2e/resources/images/renderer/iPhone XS 12/actionBarVisibility-auto-default.png differ diff --git a/e2e/renderer/e2e/resources/images/renderer/iPhone XS 12/actionBarVisibility-auto-hidden.png b/e2e/renderer/e2e/resources/images/renderer/iPhone XS 12/actionBarVisibility-auto-hidden.png index 4af0cf3d8..c31877f38 100644 Binary files a/e2e/renderer/e2e/resources/images/renderer/iPhone XS 12/actionBarVisibility-auto-hidden.png and b/e2e/renderer/e2e/resources/images/renderer/iPhone XS 12/actionBarVisibility-auto-hidden.png differ diff --git a/e2e/renderer/e2e/resources/images/renderer/iPhone XS 12/actionBarVisibility-auto-shown.png b/e2e/renderer/e2e/resources/images/renderer/iPhone XS 12/actionBarVisibility-auto-shown.png index 2b50a8104..e547d9e3a 100644 Binary files a/e2e/renderer/e2e/resources/images/renderer/iPhone XS 12/actionBarVisibility-auto-shown.png and b/e2e/renderer/e2e/resources/images/renderer/iPhone XS 12/actionBarVisibility-auto-shown.png differ diff --git a/e2e/renderer/e2e/resources/images/renderer/iPhone XS 12/actionBarVisibility-never-default-lazy.png b/e2e/renderer/e2e/resources/images/renderer/iPhone XS 12/actionBarVisibility-never-default-lazy.png new file mode 100644 index 000000000..54f0ffdd4 Binary files /dev/null and b/e2e/renderer/e2e/resources/images/renderer/iPhone XS 12/actionBarVisibility-never-default-lazy.png differ diff --git a/e2e/renderer/e2e/resources/images/renderer/iPhone XS 12/actionBarVisibility-never-default.png b/e2e/renderer/e2e/resources/images/renderer/iPhone XS 12/actionBarVisibility-never-default.png index de5e9bd34..f22f58278 100644 Binary files a/e2e/renderer/e2e/resources/images/renderer/iPhone XS 12/actionBarVisibility-never-default.png and b/e2e/renderer/e2e/resources/images/renderer/iPhone XS 12/actionBarVisibility-never-default.png differ diff --git a/e2e/renderer/e2e/resources/images/renderer/iPhone XS 12/actionBarVisibility-never-hidden-lazy.png b/e2e/renderer/e2e/resources/images/renderer/iPhone XS 12/actionBarVisibility-never-hidden-lazy.png new file mode 100644 index 000000000..d3b34b6ab Binary files /dev/null and b/e2e/renderer/e2e/resources/images/renderer/iPhone XS 12/actionBarVisibility-never-hidden-lazy.png differ diff --git a/e2e/renderer/e2e/resources/images/renderer/iPhone XS 12/actionBarVisibility-never-hidden.png b/e2e/renderer/e2e/resources/images/renderer/iPhone XS 12/actionBarVisibility-never-hidden.png index 653bf602c..e3059e1ed 100644 Binary files a/e2e/renderer/e2e/resources/images/renderer/iPhone XS 12/actionBarVisibility-never-hidden.png and b/e2e/renderer/e2e/resources/images/renderer/iPhone XS 12/actionBarVisibility-never-hidden.png differ diff --git a/e2e/renderer/e2e/resources/images/renderer/iPhone XS 12/actionBarVisibility-never-shown-lazy.png b/e2e/renderer/e2e/resources/images/renderer/iPhone XS 12/actionBarVisibility-never-shown-lazy.png new file mode 100644 index 000000000..d3b34b6ab Binary files /dev/null and b/e2e/renderer/e2e/resources/images/renderer/iPhone XS 12/actionBarVisibility-never-shown-lazy.png differ diff --git a/e2e/renderer/e2e/resources/images/renderer/iPhone XS 12/actionBarVisibility-never-shown.png b/e2e/renderer/e2e/resources/images/renderer/iPhone XS 12/actionBarVisibility-never-shown.png index 653bf602c..11225f72b 100644 Binary files a/e2e/renderer/e2e/resources/images/renderer/iPhone XS 12/actionBarVisibility-never-shown.png and b/e2e/renderer/e2e/resources/images/renderer/iPhone XS 12/actionBarVisibility-never-shown.png differ diff --git a/e2e/renderer/e2e/resources/images/renderer/iPhone XS 12/tab-view-binding-first-tab.png b/e2e/renderer/e2e/resources/images/renderer/iPhone XS 12/tab-view-binding-first-tab.png deleted file mode 100644 index 090808fcd..000000000 Binary files a/e2e/renderer/e2e/resources/images/renderer/iPhone XS 12/tab-view-binding-first-tab.png and /dev/null differ diff --git a/e2e/renderer/e2e/resources/images/renderer/iPhone XS 12/tab-view-binding-second-tab.png b/e2e/renderer/e2e/resources/images/renderer/iPhone XS 12/tab-view-binding-second-tab.png deleted file mode 100644 index aac9eda44..000000000 Binary files a/e2e/renderer/e2e/resources/images/renderer/iPhone XS 12/tab-view-binding-second-tab.png and /dev/null differ diff --git a/e2e/renderer/e2e/resources/images/renderer/iPhone XS 12/tab-view-binding-third-tab.png b/e2e/renderer/e2e/resources/images/renderer/iPhone XS 12/tab-view-binding-third-tab.png deleted file mode 100644 index 82796824e..000000000 Binary files a/e2e/renderer/e2e/resources/images/renderer/iPhone XS 12/tab-view-binding-third-tab.png and /dev/null differ diff --git a/e2e/renderer/package.json b/e2e/renderer/package.json index f003dd9ef..f9f52bfc4 100644 --- a/e2e/renderer/package.json +++ b/e2e/renderer/package.json @@ -24,9 +24,10 @@ }, "devDependencies": { "@angular/compiler-cli": "~7.0.0", - "@types/chai": "^4.0.2", - "@types/mocha": "^2.2.41", - "@types/node": "^7.0.5", + "@ngtools/webpack": "~7.0.0", + "@types/chai": "~4.1.3", + "@types/mocha": "~5.2.1", + "@types/node": "10.11.4", "babel-traverse": "6.25.0", "babel-types": "6.25.0", "babylon": "6.17.4", @@ -34,15 +35,14 @@ "chai-as-promised": "~7.1.1", "colors": "^1.1.2", "lazy": "1.0.11", - "mocha": "~3.5.0", - "mocha-junit-reporter": "^1.13.0", - "mocha-multi": "^0.11.0", + "mocha": "~5.1.0", + "mocha-junit-reporter": "~1.17.0", + "mocha-multi": "~1.0.0", "nativescript-dev-appium": "next", "nativescript-dev-typescript": "~0.7.1", "nativescript-dev-webpack": "next", "tslib": "^1.7.1", - "typescript": "~3.1.1", - "@ngtools/webpack": "~7.0.0" + "typescript": "~3.1.1" }, "scripts": { "e2e": "tsc -p e2e && mocha --opts ../config/mocha.opts --recursive e2e --appiumCapsLocation ../config/appium.capabilities.json", diff --git a/nativescript-angular/router/ns-empty-outlet.component.ts b/nativescript-angular/router/ns-empty-outlet.component.ts index eea9a74fd..502f6e4fc 100644 --- a/nativescript-angular/router/ns-empty-outlet.component.ts +++ b/nativescript-angular/router/ns-empty-outlet.component.ts @@ -1,5 +1,6 @@ -import { Component } from "@angular/core"; +import { Component, ViewChild } from "@angular/core"; import { Page } from "tns-core-modules/ui/page"; +import { PageRouterOutlet } from "./page-router-outlet"; @Component({ // tslint:disable-next-line:component-selector selector: "ns-empty-outlet", @@ -7,9 +8,16 @@ import { Page } from "tns-core-modules/ui/page"; template: "" }) export class NSEmptyOutletComponent { + @ViewChild(PageRouterOutlet) pageRouterOutlet: PageRouterOutlet; constructor(private page: Page) { if (this.page) { this.page.actionBarHidden = true; + + this.page.on("loaded", () => { + if (this.pageRouterOutlet && this.page.frame) { + this.pageRouterOutlet.setActionBarVisibility(this.page.frame.actionBarVisibility); + } + }); } } }