feat: HMR bootstrap and livesync options #1531
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
assigned 
vakrilov
changed the title
sis0k0
reviewed
Oct 1, 2018
| @@ -224,7 +239,12 @@ export class NativeScriptPlatformRef extends PlatformRef { | |||
| if (isLogEnabled()) { | |||
| bootstrapLog("Angular livesync started."); | |||
| } | |||
| onBeforeLivesync.next(lastBootstrappedModule ? lastBootstrappedModule.get() : null); | |||
|
|
|||
| const lastModuleRef = lastBootstrappedModule ? lastBootstrappedModule.get() : null | |||
vakrilov
force-pushed
the
hmr-bootstrap
branch
from
a98c195 to
b35fa39
Compare
vakrilov
changed the title
sis0k0
suggested changes
Oct 8, 2018
|
|
||
| export interface HmrOptions { | ||
| moduleTypeFactory?: () => Type<any> | NgModuleFactory<any>; | ||
| livesyncCallback: (bootstrapPlatfrom: () => void) => void; |
There was a problem hiding this comment.
bootstrapPlatfrom -> bootstrapPlatform
| export interface AppOptions { | ||
| bootInExistingPage?: boolean; | ||
| cssFile?: string; | ||
| startPageActionBarHidden?: boolean; | ||
| createFrameOnBootstrap?: boolean; | ||
| hmr?: HmrOptions; |
There was a problem hiding this comment.
Suggestion:
hmr -> hmrOptions
I thought hmr was a boolean at first.
| @@ -103,7 +112,9 @@ export class NativeScriptPlatformRef extends PlatformRef { | |||
| moduleType: Type<M>, | |||
| compilerOptions: CompilerOptions | CompilerOptions[] = [] | |||
| ): Promise<NgModuleRef<M>> { | |||
| this._bootstrapper = () => this.platform.bootstrapModule(moduleType, compilerOptions); | |||
| this._bootstrapper = () => this.platform.bootstrapModule( | |||
| this.appOptions.hmr ? <Type<M>>this.appOptions.hmr.moduleTypeFactory() : moduleType, | |||
There was a problem hiding this comment.
That:
this.appOptions.hmr ? <Type ...
can be moved to a variable for readability.
| onBeforeLivesync.next(lastBootstrappedModule ? lastBootstrappedModule.get() : null); | ||
|
|
||
| const lastModuleRef = lastBootstrappedModule ? lastBootstrappedModule.get() : null; | ||
| onBeforeLivesync.next(lastModuleRef); |
There was a problem hiding this comment.
Do we need to emit if there's no lastBootstrappedModule?
There was a problem hiding this comment.
There will be no lastBootstrappedModule if there was an error in the initial bootstrap and lastBootstrappedModule.get() will return null if the angular app was manually killed and collected (don't think it is a common practice in NS apps, but still ...). In either case I think the onBeforeLivesync should emit to be in balance with the onAfterLivesync.
vakrilov
force-pushed
the
hmr-bootstrap
branch
from
b8927fe to
fee8fc6
Compare
sis0k0
approved these changes
Oct 9, 2018
NathanWalker
pushed a commit
to NathanWalker/nativescript-angular
that referenced
this pull request
Oct 10, 2018
Pass `hmr` specific options on application bootstrap. The hmr options are: - `moduleTypeFactory?: () => Type<any> | NgModuleFactory<any>;` A module factory for re-instantiating the bootstrap module or module-factory on livesync. - `livesyncCallback: (bootstrapPlatfrom: () => void) => void;` A `livesync` callback that will be called instead of the original livesync. It gives the `hmr` a hook to apply the module replacement. The callback also accepts `bootstrapPlatfrom` function which triggers bootstrap of the angular app with the existing platform using the `moduleTypeFactory` to get module/module-factory to be used.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pass
hmrspecific options on application bootstrap. The hmr options are:moduleTypeFactory?: () => Type<any> | NgModuleFactory<any>;A module factory for re-instantiating the bootstrap module or module-factory on livesync.livesyncCallback: (bootstrapPlatfrom: () => void) => void;Alivesynccallback that will be called instead of the original livesync. It gives thehmra hook to apply the module replacement. The callback also acceptsbootstrapPlatfromfunction which triggers bootstrap of the angular app with the existing platform using themoduleTypeFactoryto get module/module-factory to be used.