Skip to content

fix(router): navigation unresponsiveness #1485

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

NathanWalker
Copy link
Contributor

closes #1484

@ghost ghost added the ♥ community PR label Aug 13, 2018
@ADjenkov
Copy link
Contributor

test

@ADjenkov
Copy link
Contributor

Hi @NathanWalker, Thank you for the PR!

Caching the current frame, only if there is no already cached frame with the same name, will disrupt the logic that handles back navigation. It also breaks some of our tests that ensure back navigation inside modal view.

Can you share some info (sample project, playground or just steps) about the scenario that is fixed with your changes? We certainly have not covered all the scenarios with the latest router changes and your case could help a lot.

Note: We have some e2e test apps that could be helpful when contributing to nativescript-angular.

modal-navigation-ng app holds tests for modal views and your changes breaks some of them. You can run end-to-end tests locally by following these instructions.

@NathanWalker
Copy link
Contributor Author

@ADjenkov Let's hop on a brief hangout to demonstrate this - I sent you a message on {N} community Slack.

@NathanWalker
Copy link
Contributor Author

Closing in favor of this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Routing broken with mixed modal (with inner navigation) and standard routing usages
3 participants