Skip to content

feat(router): enable flexible page router outlets #1298

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 19 commits into from
May 4, 2018
Merged

feat(router): enable flexible page router outlets #1298

merged 19 commits into from
May 4, 2018

Conversation

MartoYankov
Copy link
Contributor

  • Enable multiple named page-router-outlets at root level.
  • Handle back navigation with multiple named outlets.
  • Enable navigation inside modal view.

@ghost ghost added the in progress label Apr 23, 2018
@MartoYankov
Copy link
Contributor Author

test

3 similar comments
@MartoYankov
Copy link
Contributor Author

test

@SvetoslavTsenov
Copy link
Contributor

test

@MartoYankov
Copy link
Contributor Author

test

@MartoYankov
Copy link
Contributor Author

test branch_testsappng#ns-40

vakrilov and others added 18 commits April 27, 2018 15:08
@MartoYankov
feat: NativeScript 4.0 integration
1de1ce3 
Angular application is started with `application.run()` which means the the root view of the app will be the root view of the `AppComponent`.
Previous behavior: Anagular application was started with `application.start()` - this aways creates a root `Frame`. The platfrom bootstrap was always creating the inital `Page` and loading the `AppComponent` inside.

The `<page-router-outlet>` will create a Frame as a native element and will create a page for each component activated in it (including the inital page).
@MartoYankov
feat: Introduce FrameService for working with frame
98556c3
@MartoYankov
test: TabView with multiple outlets project
3c126a4
@MartoYankov
feat(router): Implemented pageTransitionDuration for NSRouterLInks + …
2910986 
…improved relative url handling
@MartoYankov
test: Tests for tests with page outlet and navigation in multiple tabs
cc5e5ad
@vchimev @MartoYankov
fix-next(dialogs): integrate showModal method with changes in 4.0
9acc426 
Rename RootView class to AppHostView class.
Expose ngAppRoot property of AppHostView class.
Add modal-nested-test example.
@vchimev @MartoYankov
chore: tslint errors
ab607a5
@vchimev @MartoYankov
fix-next(dialogs): showModal dialog of selector template as root
a71dec6 
Extend AppHostView class to overwrite the `content` property of ContentView.
@vchimev @MartoYankov
test(ng-sample): add modal router outlet example
2e5a43f
@vchimev @MartoYankov
test(ng-sample): add modal page router outlet example
c7c7355
@vchimev @MartoYankov
chore: a tslint error
9ed3c42
@MartoYankov
feat(router): rework to support history by outlet
b2d4cb4
@vchimev @MartoYankov
refactor(dialogs): remove page wrapper
0b965a4
@MartoYankov
chore(e2e-modal): update modal-navigation-ng app to display miodal view
81fde3b
@MartoYankov
fix-next(dialogs): handle close modal
d164d7d 
Sanitize router states and cache when closing modal view
@MartoYankov
chore(app-host-view): remove unnecessary extractContentFromHost method
c83559c
@MartoYankov
test(location): add location strategy tests
81f431b
@MartoYankov
chore(tslint): fix errors
9d09e96
@MartoYankov
Copy link
Contributor Author

test branch_testsappng#ns-40

@SvetoslavTsenov
Copy link
Contributor

TestsAppNg is not building for both platforms. Probably not

ERROR in node_modules/rxjs/Observable.d.ts(1,15): error TS2307: Cannot find module 'rxjs-compat/Observable'.
app/list-view/async-pipe-template.component.ts(1,10): error TS2305: Module '"/Users/nsbuilduser/workspace/composite-testsappng/tests-app-ng/node_modules/rxjs/Observable"' has no exported member 'Observable'.
app/list-view/multiple-templates.component.ts(1,10): error TS2305: Module '"/Users/nsbuilduser/workspace/composite-testsappng/tests-app-ng/node_modules/rxjs/Observable"' has no exported member 'Observable'.
app/button/button-text-alignment.component.ts(1,10): error TS2305: Module '"/Users/nsbuilduser/workspace/composite-testsappng/tests-app-ng/node_modules/rxjs/Observable"' has no exported member 'Observable'.

@sis0k0
Copy link
Contributor

sis0k0 commented Apr 29, 2018 •
edited
Loading

@SvetoslavTsenov @MartoYankov The ns-40 branch in nativescript/tests-app-ng is not compatible with NG 6. It should be rebased on top of the master branch. NativeScript/tests-app-ng#36

@MartoYankov
Copy link
Contributor Author

test branch_testsappng#ns-40

1 similar comment
@SvetoslavTsenov
Copy link
Contributor

test branch_testsappng#ns-40

@MartoYankov MartoYankov merged commit b98da83 into master May 4, 2018
@ghost ghost removed the in progress label May 4, 2018
@vchimev vchimev deleted the ns-40 branch May 4, 2018 11:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vakrilov vakrilov vakrilov approved these changes

Assignees

@MartoYankov MartoYankov

@ADjenkov ADjenkov

@vchimev vchimev

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@MartoYankov @SvetoslavTsenov @sis0k0 @vakrilov @ADjenkov @vchimev