Skip to content

refactor(script): update animations dependency if present in the project #1129

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Dec 19, 2017

Conversation

vchimev
Copy link
Contributor

@vchimev vchimev commented Dec 19, 2017

No description provided.

@ghost ghost assigned vchimev Dec 19, 2017
@ghost ghost added the in progress label Dec 19, 2017
@vchimev vchimev requested a review from sis0k0 December 19, 2017 01:59

if (deps["@angular/animations"]) {
const ngDep = Object.keys(newDeps).find(dep => dep.startsWith("@angular"));
deps["@angular/animations"] = newDeps[ngDep]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

semicolon

@sis0k0
Copy link
Contributor

sis0k0 commented Dec 19, 2017

Change the title scope to refactor or chore.

@vchimev vchimev changed the title feat(script): update animations dependency if present in the project refactor(script): update animations dependency if present in the project Dec 19, 2017
@vchimev vchimev merged commit f3b4b65 into master Dec 19, 2017
@vchimev vchimev deleted the vchimev/script branch December 19, 2017 11:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants