From fdadbe98e8a19b9d48d408ddfc86d4db01b283f2 Mon Sep 17 00:00:00 2001 From: Alexander Djenkov Date: Thu, 2 Nov 2017 13:42:32 +0200 Subject: [PATCH 01/17] refactor: Remove ChangeDetectorRef parameter reason: https://github.com/angular/angular/pull/14311 --- nativescript-angular/directives/list-view-comp.ts | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/nativescript-angular/directives/list-view-comp.ts b/nativescript-angular/directives/list-view-comp.ts index 351441cce..7cba54526 100644 --- a/nativescript-angular/directives/list-view-comp.ts +++ b/nativescript-angular/directives/list-view-comp.ts @@ -88,15 +88,14 @@ export class ListViewComponent implements DoCheck, OnDestroy, AfterContentInit { } if (needDiffer && !this._differ && isListLikeIterable(value)) { this._differ = this._iterableDiffers.find(this._items) - .create(this._cdr, (_index, item) => { return item; }); + .create((_index, item) => { return item; }); } this.listView.items = this._items; } constructor(_elementRef: ElementRef, - private _iterableDiffers: IterableDiffers, - private _cdr: ChangeDetectorRef) { + private _iterableDiffers: IterableDiffers) { this.listView = _elementRef.nativeElement; this.listView.on("itemLoading", this.onItemLoading, this); From c3b6816b20f386d8387613c7c2ba6a134e9f11b5 Mon Sep 17 00:00:00 2001 From: Alexander Djenkov Date: Thu, 2 Nov 2017 13:45:27 +0200 Subject: [PATCH 02/17] refactor: implement AnimationDriver (WIP) --- nativescript-angular/animations/animation-driver.ts | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/nativescript-angular/animations/animation-driver.ts b/nativescript-angular/animations/animation-driver.ts index 369450208..29eae6f9e 100644 --- a/nativescript-angular/animations/animation-driver.ts +++ b/nativescript-angular/animations/animation-driver.ts @@ -68,6 +68,10 @@ class Selector { } export class NativeScriptAnimationDriver implements AnimationDriver { + validateStyleProperty(prop: string): boolean { + throw new Error("Not implemented!"); + } + matchesElement(element: NgView, rawSelector: string): boolean { traceLog( `NativeScriptAnimationDriver.matchesElement ` + From 56676c73e9fd668ccdab03b315358b84cc203110 Mon Sep 17 00:00:00 2001 From: Alexander Djenkov Date: Thu, 2 Nov 2017 13:49:14 +0200 Subject: [PATCH 03/17] refactor: Remove NSFileSystem injection (WIP) --- nativescript-angular/resource-loader.ts | 8 ++++++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/nativescript-angular/resource-loader.ts b/nativescript-angular/resource-loader.ts index 43a5091bc..10c1ee759 100644 --- a/nativescript-angular/resource-loader.ts +++ b/nativescript-angular/resource-loader.ts @@ -12,8 +12,12 @@ const extensionsFallbacks = [ @Injectable() export class FileSystemResourceLoader extends ResourceLoader { - constructor(private fs: NSFileSystem) { + fs: NSFileSystem; + + constructor() { super(); + + this.fs = new NSFileSystem(); } get(url: string): Promise { @@ -57,7 +61,7 @@ export class FileSystemResourceLoader extends ResourceLoader { const candidates = extensionsFallbacks .filter(([extension]) => url.endsWith(extension)) .map(([extension, fallback]) => - this.replaceExtension(url, extension, fallback)); + this.replaceExtension(url, extension, fallback)); const resource = candidates.find(candidate => this.fs.fileExists(candidate)); From 24550c0e890b2d988f31c39b87c040a596600b85 Mon Sep 17 00:00:00 2001 From: Alexander Djenkov Date: Thu, 2 Nov 2017 13:52:30 +0200 Subject: [PATCH 04/17] refactor: Use StaticProvider instead of Provider reason: https://github.com/angular/angular/commit/fcadbf4 --- nativescript-angular/platform-common.ts | 9 +++++---- 1 file changed, 5 insertions(+), 4 deletions(-) diff --git a/nativescript-angular/platform-common.ts b/nativescript-angular/platform-common.ts index a5fbb67e1..23220cfbc 100644 --- a/nativescript-angular/platform-common.ts +++ b/nativescript-angular/platform-common.ts @@ -18,7 +18,8 @@ import { EventEmitter, Provider, Sanitizer, - InjectionToken + InjectionToken, + StaticProvider } from "@angular/core"; import { DOCUMENT } from "@angular/common"; @@ -54,7 +55,7 @@ export interface AppOptions { startPageActionBarHidden?: boolean; } -export type PlatformFactory = (extraProviders?: Provider[]) => PlatformRef; +export type PlatformFactory = (extraProviders?: StaticProvider[]) => PlatformRef; export class NativeScriptSanitizer extends Sanitizer { sanitize(_context: any, value: string): string { @@ -70,8 +71,8 @@ export class NativeScriptDocument { export const COMMON_PROVIDERS = [ defaultPageFactoryProvider, - { provide: Sanitizer, useClass: NativeScriptSanitizer }, - { provide: DOCUMENT, useClass: NativeScriptDocument }, + { provide: Sanitizer, useClass: NativeScriptSanitizer, deps: [] }, + { provide: DOCUMENT, useClass: NativeScriptDocument, deps: [] }, ]; export class NativeScriptPlatformRef extends PlatformRef { From 3a63a769d46e01fbe9165cdf57f972cedf83afef Mon Sep 17 00:00:00 2001 From: Alexander Djenkov Date: Thu, 2 Nov 2017 14:06:55 +0200 Subject: [PATCH 05/17] refactor(platform): Use new Angular APIs - import platformCoreDynamic from @angular/platform-browser-dynamic - import INTERNAL_BROWSER_PLATFORM_PROVIDERS (COMPILER_PROVIDERS) from @angular/platform-browser --- nativescript-angular/platform.ts | 15 +++++++++++---- 1 file changed, 11 insertions(+), 4 deletions(-) diff --git a/nativescript-angular/platform.ts b/nativescript-angular/platform.ts index f1a6ad80b..0d3075109 100644 --- a/nativescript-angular/platform.ts +++ b/nativescript-angular/platform.ts @@ -9,17 +9,24 @@ import { import { ElementSchemaRegistry, ResourceLoader, - COMPILER_PROVIDERS, - platformCoreDynamic } from "@angular/compiler"; +import { + ɵplatformCoreDynamic as platformCoreDynamic +} from "@angular/platform-browser-dynamic"; + +import { + ɵINTERNAL_BROWSER_PLATFORM_PROVIDERS as INTERNAL_BROWSER_PLATFORM_PROVIDERS +} from "@angular/platform-browser"; + import { COMPILER_OPTIONS, PlatformRef, InjectionToken, ViewEncapsulation, createPlatformFactory, - MissingTranslationStrategy + MissingTranslationStrategy, + StaticProvider, } from "@angular/core"; // Work around a TS bug requiring an imports of @@ -39,7 +46,7 @@ import { NSFileSystem } from "./file-system/ns-file-system"; import { FileSystemResourceLoader } from "./resource-loader"; export const NS_COMPILER_PROVIDERS = [ - COMPILER_PROVIDERS, + INTERNAL_BROWSER_PLATFORM_PROVIDERS, { provide: COMPILER_OPTIONS, useValue: { From e0d9d3c84ec100df2080e15be136fa4748b2e2ab Mon Sep 17 00:00:00 2001 From: Alexander Djenkov Date: Thu, 2 Nov 2017 14:11:11 +0200 Subject: [PATCH 06/17] =?UTF-8?q?refactor:=20Implement=20=C9=B5DomAdapter?= MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit reason: https://github.com/angular/angular/commit/2f2d5f3 --- nativescript-angular/dom-adapter.ts | 1 + 1 file changed, 1 insertion(+) diff --git a/nativescript-angular/dom-adapter.ts b/nativescript-angular/dom-adapter.ts index e228f92a5..2a112782f 100644 --- a/nativescript-angular/dom-adapter.ts +++ b/nativescript-angular/dom-adapter.ts @@ -143,6 +143,7 @@ export class NativeScriptDomAdapter implements ɵDomAdapter { templateAwareRoot(_el: any /** TODO #9100 */): any /** TODO #9100 */ { throw new Error("Not implemented!") } createHtmlDocument(): HTMLDocument { throw new Error("Not implemented!") } defaultDoc(): HTMLDocument { throw new Error("Not implemented!") } + getDefaultDocument(): Document { throw new Error("Not implemented!") } getBoundingClientRect(_el: any /** TODO #9100 */): any /** TODO #9100 */ { throw new Error("Not implemented!") } getTitle(): string { throw new Error("Not implemented!") } setTitle(_doc: Document, _newTitle: string): any /** TODO #9100 */ { throw new Error("Not implemented!") } From 18c63f667cbe146a6d934a9bf1b316e8e3ba1aa9 Mon Sep 17 00:00:00 2001 From: Alexander Djenkov Date: Thu, 2 Nov 2017 14:27:49 +0200 Subject: [PATCH 07/17] refactor: Stop using private APIs to retrieve activated route roiteConfig property --- nativescript-angular/router/page-router-outlet.ts | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/nativescript-angular/router/page-router-outlet.ts b/nativescript-angular/router/page-router-outlet.ts index 2695026c4..3737dd7d5 100644 --- a/nativescript-angular/router/page-router-outlet.ts +++ b/nativescript-angular/router/page-router-outlet.ts @@ -359,13 +359,11 @@ export class PageRouterOutlet implements OnDestroy, OnInit { // tslint:disable-l log("Activated route marked as page: " + routeToString(nodeToMark)); } - // NOTE: Using private APIs - potential break point! private getComponentFactory( - activatedRoute: any, + activatedRoute: ActivatedRoute, loadedResolver: ComponentFactoryResolver ): ComponentFactory { - const snapshot = activatedRoute._futureSnapshot; - const component = snapshot._routeConfig.component; + const { component } = activatedRoute.routeConfig; return loadedResolver ? loadedResolver.resolveComponentFactory(component) : From 63e94f162d37da6ceb072406ac31a5c946d5da3e Mon Sep 17 00:00:00 2001 From: Alexander Djenkov Date: Thu, 2 Nov 2017 14:33:30 +0200 Subject: [PATCH 08/17] refactor: Remove NSFileSystem provider. Add deps property for ResourceLoader and ElementSchemaRegistry providers. reason:https://github.com/angular/angular/commit/fcadbf4 --- nativescript-angular/platform.ts | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/nativescript-angular/platform.ts b/nativescript-angular/platform.ts index 0d3075109..6f259abf5 100644 --- a/nativescript-angular/platform.ts +++ b/nativescript-angular/platform.ts @@ -51,9 +51,8 @@ export const NS_COMPILER_PROVIDERS = [ provide: COMPILER_OPTIONS, useValue: { providers: [ - NSFileSystem, - { provide: ResourceLoader, useClass: FileSystemResourceLoader }, - { provide: ElementSchemaRegistry, useClass: NativeScriptElementSchemaRegistry }, + { provide: ResourceLoader, useClass: FileSystemResourceLoader, deps: [] }, + { provide: ElementSchemaRegistry, useClass: NativeScriptElementSchemaRegistry, deps: [] }, ] }, multi: true From 256372781f2ff09ab4d9f7ffb98811e876c21aaa Mon Sep 17 00:00:00 2001 From: Alexander Djenkov Date: Thu, 2 Nov 2017 14:43:28 +0200 Subject: [PATCH 09/17] chore: Add @angular/platform-browse-dynamic dependency and bump version of @angular/... peer and dev deps --- nativescript-angular/package.json | 42 ++++++++++++++++--------------- 1 file changed, 22 insertions(+), 20 deletions(-) diff --git a/nativescript-angular/package.json b/nativescript-angular/package.json index 1a2c5fa01..de5784b9e 100644 --- a/nativescript-angular/package.json +++ b/nativescript-angular/package.json @@ -43,32 +43,34 @@ "reflect-metadata": "^0.1.8" }, "peerDependencies": { - "@angular/common": "~4.4.1", - "@angular/compiler": "~4.4.1", - "@angular/core": "~4.4.1", - "@angular/forms": "~4.4.1", - "@angular/http": "~4.4.1", - "@angular/platform-browser": "~4.4.1", - "@angular/router": "~4.4.1", - "rxjs": "^5.0.1", + "@angular/platform-browser-dynamic": "~5.0.0", + "@angular/common": "~5.0.0", + "@angular/compiler": "~5.0.0", + "@angular/core": "~5.0.0", + "@angular/forms": "~5.0.0", + "@angular/http": "~5.0.0", + "@angular/platform-browser": "~5.0.0", + "@angular/router": "~5.0.0", + "rxjs": "^5.5.0", "tns-core-modules": "^3.1.0 || >3.4.0-", "zone.js": "^0.8.4" }, "devDependencies": { - "@angular/animations": "~4.4.1", - "@angular/common": "~4.4.1", - "@angular/compiler": "~4.4.1", - "@angular/compiler-cli": "~4.4.1", - "@angular/core": "~4.4.1", - "@angular/forms": "~4.4.1", - "@angular/http": "~4.4.1", - "@angular/platform-browser": "~4.4.1", - "@angular/router": "~4.4.1", - "codelyzer": "^3.1.2", - "rxjs": "^5.4.2", + "@angular/platform-browser-dynamic": "~5.0.0", + "@angular/animations": "~5.0.0", + "@angular/common": "~5.0.0", + "@angular/compiler": "~5.0.0", + "@angular/compiler-cli": "~5.0.0", + "@angular/core": "~5.0.0", + "@angular/forms": "~5.0.0", + "@angular/http": "~5.0.0", + "@angular/platform-browser": "~5.0.0", + "@angular/router": "~5.0.0", + "codelyzer": "^4.0.0", + "rxjs": "^5.5.0", "tns-core-modules": "next", "tslint": "^5.5.0", - "typescript": "^2.5.1", + "typescript": "~2.4.2", "zone.js": "^0.8.12" } } From b3d01e78c42d440abf35603971b83f3a24bb5f74 Mon Sep 17 00:00:00 2001 From: Alexander Djenkov Date: Thu, 2 Nov 2017 15:51:27 +0200 Subject: [PATCH 10/17] chore: Add typescript peer dep --- nativescript-angular/package.json | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/nativescript-angular/package.json b/nativescript-angular/package.json index de5784b9e..719a0c68d 100644 --- a/nativescript-angular/package.json +++ b/nativescript-angular/package.json @@ -53,7 +53,8 @@ "@angular/router": "~5.0.0", "rxjs": "^5.5.0", "tns-core-modules": "^3.1.0 || >3.4.0-", - "zone.js": "^0.8.4" + "zone.js": "^0.8.4", + "typescript": "~2.4.2" }, "devDependencies": { "@angular/platform-browser-dynamic": "~5.0.0", From 673432b82c05a6a0fe8c9cf953b2cddd9d80d533 Mon Sep 17 00:00:00 2001 From: Alexander Djenkov Date: Thu, 2 Nov 2017 15:51:53 +0200 Subject: [PATCH 11/17] chore: Update e2e apps deps --- e2e/renderer/package.json | 25 +++++++++++++------------ e2e/router/package.json | 30 ++++++++++++++++-------------- 2 files changed, 29 insertions(+), 26 deletions(-) diff --git a/e2e/renderer/package.json b/e2e/renderer/package.json index 94403d63c..5edac50fa 100644 --- a/e2e/renderer/package.json +++ b/e2e/renderer/package.json @@ -10,20 +10,20 @@ } }, "dependencies": { - "@angular/animations": "~4.4.1", - "@angular/common": "~4.4.1", - "@angular/compiler": "~4.4.1", - "@angular/core": "~4.4.1", - "@angular/forms": "~4.4.1", - "@angular/http": "~4.4.1", - "@angular/platform-browser": "~4.4.1", - "@angular/router": "~4.4.1", + "@angular/common": "~5.0.0", + "@angular/compiler": "~5.0.0", + "@angular/core": "~5.0.0", + "@angular/forms": "~5.0.0", + "@angular/http": "~5.0.0", + "@angular/platform-browser": "~5.0.0", + "@angular/platform-browser-dynamic": "~5.0.0", + "@angular/router": "~5.0.0", "nativescript-angular": "file:../../nativescript-angular", "nativescript-intl": "^3.0.0", "reflect-metadata": "~0.1.8", - "rxjs": "~5.3.0", + "rxjs": "^5.5.0", "tns-core-modules": "next", - "zone.js": "~0.8.2" + "zone.js": "^0.8.4" }, "devDependencies": { "@types/chai": "^4.0.2", @@ -42,10 +42,11 @@ "nativescript-dev-appium": "next", "nativescript-dev-typescript": "~0.4.0", "tslib": "^1.7.1", - "typescript": "~2.2.1" + "typescript": "~2.4.2" }, "scripts": { "e2e": "tsc -p e2e && mocha --opts ./e2e/config/mocha.opts", - "compile-tests-w": "tsc -p e2e --watch" + "compile-tests-w": "tsc -p e2e --watch", + "update-app-ng-deps": "update-app-ng-deps" } } diff --git a/e2e/router/package.json b/e2e/router/package.json index e99f48117..04c9aa423 100644 --- a/e2e/router/package.json +++ b/e2e/router/package.json @@ -6,27 +6,28 @@ "nativescript": { "id": "org.nativescript.router", "tns-android": { - "version": "3.2.0-2017-9-4-1" + "version": "next" }, "tns-ios": { - "version": "3.2.0" + "version": "next" } }, "dependencies": { "@angular/animations": "~4.4.1", - "@angular/common": "~4.4.1", - "@angular/compiler": "~4.4.1", - "@angular/core": "~4.4.1", - "@angular/forms": "~4.4.1", - "@angular/http": "~4.4.1", - "@angular/platform-browser": "~4.4.1", - "@angular/router": "~4.4.1", + "@angular/common": "~5.0.0", + "@angular/compiler": "~5.0.0", + "@angular/core": "~5.0.0", + "@angular/forms": "~5.0.0", + "@angular/http": "~5.0.0", + "@angular/platform-browser": "~5.0.0", + "@angular/router": "~5.0.0", "nativescript-angular": "file:../../nativescript-angular", "nativescript-intl": "^3.0.0", "reflect-metadata": "~0.1.8", - "rxjs": "~5.3.0", + "rxjs": "^5.5.0", "tns-core-modules": "next", - "zone.js": "~0.8.2" + "zone.js": "^0.8.4", + "@angular/platform-browser-dynamic": "~5.0.0" }, "devDependencies": { "@types/chai": "^4.0.2", @@ -45,10 +46,11 @@ "nativescript-dev-appium": "next", "nativescript-dev-typescript": "~0.4.0", "tslib": "^1.7.1", - "typescript": "~2.2.1" + "typescript": "~2.4.2" }, "scripts": { "e2e": "tsc -p e2e && mocha --opts ./e2e/config/mocha.opts", - "compile-tests-w": "tsc -p e2e --watch" + "compile-tests-w": "tsc -p e2e --watch", + "update-app-ng-deps": "update-app-ng-deps" } -} +} \ No newline at end of file From 5c05dd4a3eb03d74e81836055550ba66b30961f5 Mon Sep 17 00:00:00 2001 From: Alexander Djenkov Date: Thu, 2 Nov 2017 15:54:03 +0200 Subject: [PATCH 12/17] refactor: Update update-app-ng-deps script - Update dev deps - Add new deps in deps - Update to work with NPM5 --- nativescript-angular/bin/update-app-ng-deps | 41 +++++++-------------- 1 file changed, 14 insertions(+), 27 deletions(-) diff --git a/nativescript-angular/bin/update-app-ng-deps b/nativescript-angular/bin/update-app-ng-deps index 7676e3313..1cf6786ce 100644 --- a/nativescript-angular/bin/update-app-ng-deps +++ b/nativescript-angular/bin/update-app-ng-deps @@ -11,47 +11,34 @@ const pluginPackageJson = JSON.parse(fs.readFileSync(pluginPackageJsonPath, "utf const isNgDependency = name => name.startsWith("@angular") || name === "rxjs" || - name === "zone.js"; + name === "zone.js" || + name === "typescript"; -function updateDeps(deps, newDeps) { - // set app dependencies to ones required from plugin +function updateDeps(deps, devDeps, newDeps) { Object.keys(newDeps) .filter(isNgDependency) - .filter(dependencyName => deps.hasOwnProperty(dependencyName)) .map(dependencyName => ({ dependencyName, - version: pluginPackageJson.peerDependencies[dependencyName] + version: newDeps[dependencyName] })) - .filter(({ dependencyName, version }) => deps[dependencyName] !== version) .forEach(({ dependencyName, version }) => { - deps[dependencyName] = version; + if (devDeps[dependencyName]) { + devDeps[dependencyName] = version; + } else { + deps[dependencyName] = version; + } + console.log(`Updated dependency ${dependencyName} to version: ${version}.`); }); - - // remove platform-browser-dynamic if present - if (deps.hasOwnProperty(browserDynamicDependency)) { - delete deps[browserDynamicDependency]; - console.log(`Removed ${browserDynamicDependency}`); - } - - - return deps; } -let pluginDeps = pluginPackageJson.peerDependencies; -Object.keys(pluginPackageJson.devDependencies) - .filter(isNgDependency) - .filter(depName => !pluginDeps.hasOwnProperty(depName)) - .forEach(depName => { - pluginDeps[depName] = pluginPackageJson.devDependencies[depName]; - }); - -const projectPath = path.dirname(path.dirname(pluginPath)); +const pluginDeps = pluginPackageJson.peerDependencies; +const projectPath = process.env.INIT_CWD || path.dirname(path.dirname(pluginPath)); const appPackageJsonPath = path.join(projectPath, "package.json"); const appPackageJson = JSON.parse(fs.readFileSync(appPackageJsonPath, "utf8")); -appPackageJson.dependencies = updateDeps(appPackageJson.dependencies, pluginDeps); -appPackageJson.devDependencies = updateDeps(appPackageJson.devDependencies, pluginDeps); +const { dependencies, devDependencies } = appPackageJson; +updateDeps(dependencies, devDependencies, pluginDeps); fs.writeFileSync(appPackageJsonPath, JSON.stringify(appPackageJson, null, 2)); From 8427c9ddb09c90c808a4c890cf348d849cfd1d4c Mon Sep 17 00:00:00 2001 From: Alexander Djenkov Date: Thu, 2 Nov 2017 16:54:17 +0200 Subject: [PATCH 13/17] fix:tslint errors --- nativescript-angular/directives/list-view-comp.ts | 1 - nativescript-angular/platform-common.ts | 1 - nativescript-angular/platform.ts | 3 +-- 3 files changed, 1 insertion(+), 4 deletions(-) diff --git a/nativescript-angular/directives/list-view-comp.ts b/nativescript-angular/directives/list-view-comp.ts index 7cba54526..a04f244b4 100644 --- a/nativescript-angular/directives/list-view-comp.ts +++ b/nativescript-angular/directives/list-view-comp.ts @@ -1,7 +1,6 @@ import { AfterContentInit, ChangeDetectionStrategy, - ChangeDetectorRef, Component, ContentChild, Directive, diff --git a/nativescript-angular/platform-common.ts b/nativescript-angular/platform-common.ts index 23220cfbc..d22f1dbf7 100644 --- a/nativescript-angular/platform-common.ts +++ b/nativescript-angular/platform-common.ts @@ -16,7 +16,6 @@ import { NgModuleFactory, NgModuleRef, EventEmitter, - Provider, Sanitizer, InjectionToken, StaticProvider diff --git a/nativescript-angular/platform.ts b/nativescript-angular/platform.ts index 6f259abf5..03633089f 100644 --- a/nativescript-angular/platform.ts +++ b/nativescript-angular/platform.ts @@ -42,10 +42,9 @@ if ((global).___TS_UNUSED) { import "./dom-adapter"; import { NativeScriptElementSchemaRegistry } from "./schema-registry"; -import { NSFileSystem } from "./file-system/ns-file-system"; import { FileSystemResourceLoader } from "./resource-loader"; -export const NS_COMPILER_PROVIDERS = [ +export const NS_COMPILER_PROVIDERS: StaticProvider[] = [ INTERNAL_BROWSER_PLATFORM_PROVIDERS, { provide: COMPILER_OPTIONS, From 26c5e4fac953f0f1855dd306436069a7bf8cd128 Mon Sep 17 00:00:00 2001 From: Alexander Djenkov Date: Thu, 2 Nov 2017 17:49:51 +0200 Subject: [PATCH 14/17] refactor: Replace OpaqueToken with InjectionToken since it's removed from @angular/core --- tests/app/base.component.ts | 4 ++-- tests/app/main.ts | 2 +- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/tests/app/base.component.ts b/tests/app/base.component.ts index 6909d5921..2ca048204 100644 --- a/tests/app/base.component.ts +++ b/tests/app/base.component.ts @@ -1,5 +1,5 @@ -import { OpaqueToken, OnInit, OnDestroy } from "@angular/core"; -export const HOOKS_LOG = new OpaqueToken("Hooks log"); +import { InjectionToken, OnInit, OnDestroy } from "@angular/core"; +export const HOOKS_LOG = new InjectionToken("Hooks log"); import { BehaviorSubject } from "rxjs/BehaviorSubject"; export class BaseComponent implements OnInit, OnDestroy { diff --git a/tests/app/main.ts b/tests/app/main.ts index ce33b3f50..f5c652ff7 100644 --- a/tests/app/main.ts +++ b/tests/app/main.ts @@ -24,7 +24,7 @@ import { SinglePageMain, routes as singlePageRoutes } from "./single-page-main.c import { LazyLoadMain, routes as lazyLoadRoutes } from "./lazy-load-main"; import { FirstComponent } from "./first.component"; import { SecondComponent } from "./second.component"; -import { OpaqueToken, NgModule, NgModuleFactoryLoader } from "@angular/core"; +import { InjectionToken, NgModule, NgModuleFactoryLoader } from "@angular/core"; import { PageNavigationApp } from "./snippets/navigation/page-outlet"; import { NavigationApp } from "./snippets/navigation/router-outlet"; From 2d3dd61f3be2697dfaca38cc6715ea0df70434f7 Mon Sep 17 00:00:00 2001 From: Alexander Djenkov Date: Thu, 2 Nov 2017 17:50:45 +0200 Subject: [PATCH 15/17] chore: Update tests app deps --- tests/package.json | 25 +++++++++++++------------ 1 file changed, 13 insertions(+), 12 deletions(-) diff --git a/tests/package.json b/tests/package.json index 9cfb0bb66..38bef7bb7 100644 --- a/tests/package.json +++ b/tests/package.json @@ -27,19 +27,19 @@ "homepage": "http://nativescript.org", "dependencies": { "@angular/animations": "~4.4.1", - "@angular/common": "~4.4.1", - "@angular/compiler": "~4.4.1", - "@angular/core": "~4.4.1", - "@angular/forms": "~4.4.1", - "@angular/http": "~4.4.1", - "@angular/platform-browser": "~4.4.1", - "@angular/platform-browser-dynamic": "~4.4.1", - "@angular/router": "~4.4.1", + "@angular/common": "~5.0.0", + "@angular/compiler": "~5.0.0", + "@angular/core": "~5.0.0", + "@angular/forms": "~5.0.0", + "@angular/http": "~5.0.0", + "@angular/platform-browser": "~5.0.0", + "@angular/platform-browser-dynamic": "~5.0.0", + "@angular/router": "~5.0.0", "nativescript-angular": "../nativescript-angular", "nativescript-unit-test-runner": "^0.3.4", - "rxjs": "^5.2.0", + "rxjs": "^5.5.0", "tns-core-modules": "next", - "zone.js": "^0.8.2" + "zone.js": "^0.8.4" }, "devDependencies": { "@types/chai": "^4.0.2", @@ -66,11 +66,12 @@ "socket.io-client": "1.4.8", "tslib": "^1.7.1", "tslint": "^4.5.1", - "typescript": "~2.5.0", + "typescript": "~2.4.2", "mocha": "~3.5.0" }, "scripts": { "e2e": "tsc -p e2e && mocha --opts ./e2e/config/mocha.opts", - "compile-tests-w": "tsc -p e2e --watch" + "compile-tests-w": "tsc -p e2e --watch", + "update-app-ng-deps": "update-app-ng-deps" } } From c2c4e45bd23d1c423a386bd33e11f0c2a6898659 Mon Sep 17 00:00:00 2001 From: Alexander Djenkov Date: Thu, 2 Nov 2017 17:52:01 +0200 Subject: [PATCH 16/17] refactor: FileSystemResourceLoader now inits NSFileSystemMock internally (WIP) --- tests/app/tests/xhr-paths.ts | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/tests/app/tests/xhr-paths.ts b/tests/app/tests/xhr-paths.ts index c3de6a6dc..818d59e17 100644 --- a/tests/app/tests/xhr-paths.ts +++ b/tests/app/tests/xhr-paths.ts @@ -25,7 +25,8 @@ const fsMock = new NSFileSystemMock(); describe("XHR name resolution", () => { let resourceLoader: FileSystemResourceLoader; before(() => { - resourceLoader = new FileSystemResourceLoader(new NSFileSystemMock()); + resourceLoader = new FileSystemResourceLoader(); + resourceLoader.fs = new NSFileSystemMock(); }); it("resolves relative paths from app root", () => { From 93f72815a4eea628ec56d3a7b23b780169b16ba2 Mon Sep 17 00:00:00 2001 From: sis0k0 Date: Fri, 3 Nov 2017 15:15:57 +0200 Subject: [PATCH 17/17] chore: bump version to publish @next with 5.0 --- nativescript-angular/package.json | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/nativescript-angular/package.json b/nativescript-angular/package.json index 719a0c68d..ebb23d811 100644 --- a/nativescript-angular/package.json +++ b/nativescript-angular/package.json @@ -1,7 +1,7 @@ { "private": true, "name": "nativescript-angular", - "version": "4.4.1", + "version": "5.0.0", "description": "An Angular renderer that lets you build mobile apps with NativeScript.", "homepage": "https://www.nativescript.org/", "bugs": "https://github.com/NativeScript/nativescript-angular/issues",