From 718a307ad73a67bd716de61ce9e3ee3f2dad30f3 Mon Sep 17 00:00:00 2001 From: vakrilov Date: Wed, 11 Oct 2017 17:23:09 +0300 Subject: [PATCH] fix(tests): Fix tests: value convertion and async test. --- tests/app/tests/list-view-tests.ts | 6 +++--- tests/app/tests/modal-dialog.ts | 2 +- tests/app/tests/property-sets.ts | 8 ++++---- 3 files changed, 8 insertions(+), 8 deletions(-) diff --git a/tests/app/tests/list-view-tests.ts b/tests/app/tests/list-view-tests.ts index 20d4bf1d6..3c3d7fb54 100644 --- a/tests/app/tests/list-view-tests.ts +++ b/tests/app/tests/list-view-tests.ts @@ -100,7 +100,7 @@ describe("ListView-tests", () => { }); it("setupItemView is called for every item", (done) => { - return testApp.loadComponent(TestListViewComponent).then((componentRef) => { + testApp.loadComponent(TestListViewComponent).then((componentRef) => { const component = componentRef.instance; setTimeout(() => { assert.equal(component.counter, 3); @@ -112,9 +112,9 @@ describe("ListView-tests", () => { it("itemTemplateSelector selects templates", (done) => { - return testApp.loadComponent(TestListViewSelectorComponent).then((componentRef) => { + testApp.loadComponent(TestListViewSelectorComponent).then((componentRef) => { setTimeout(() => { - assert.deepEqual(testTemplates, { first: 2, second: 1 }); + assert.deepEqual(testTemplates, { first: 2, second: 1 }); done(); }, 1000); }) diff --git a/tests/app/tests/modal-dialog.ts b/tests/app/tests/modal-dialog.ts index c14a13f36..69a909c73 100644 --- a/tests/app/tests/modal-dialog.ts +++ b/tests/app/tests/modal-dialog.ts @@ -50,7 +50,7 @@ describe("modal-dialog", () => { let testApp: TestApp = null; before((done) => { - return TestApp.create([], [ModalComponent, FailComponent, SuccessComponent]).then((app) => { + TestApp.create([], [ModalComponent, FailComponent, SuccessComponent]).then((app) => { testApp = app; // HACK: Wait for the navigations from the test runner app diff --git a/tests/app/tests/property-sets.ts b/tests/app/tests/property-sets.ts index 3b5c5253e..26e78a036 100644 --- a/tests/app/tests/property-sets.ts +++ b/tests/app/tests/property-sets.ts @@ -46,10 +46,10 @@ describe("setting View properties", () => { it("doesn\'t convert number values", () => { let view = new TestView(); viewUtil.setProperty(view, "numValue", "42"); - assert.strictEqual(42, view.numValue); + assert.strictEqual("42", view.numValue); viewUtil.setProperty(view, "numValue", "42."); - assert.strictEqual(42., view.numValue); + assert.strictEqual("42.", view.numValue); viewUtil.setProperty(view, "numValue", 0); assert.strictEqual(0, view.numValue); @@ -58,9 +58,9 @@ describe("setting View properties", () => { it("doesn\'t convert boolean values", () => { let view = new TestView(); viewUtil.setProperty(view, "boolValue", "true"); - assert.strictEqual(true, view.boolValue); + assert.strictEqual("true", view.boolValue); viewUtil.setProperty(view, "boolValue", "false"); - assert.strictEqual(false, view.boolValue); + assert.strictEqual("false", view.boolValue); }); it("sets style values", () => {