From eca653215388fc578e9123b7e65e506d27d7d675 Mon Sep 17 00:00:00 2001 From: Vasil Chimev Date: Fri, 6 Oct 2017 14:51:12 +0300 Subject: [PATCH 1/4] docs: describe comment messages available to test --- PULL_REQUEST_TESTS.md | 11 +++++++++++ 1 file changed, 11 insertions(+) create mode 100644 PULL_REQUEST_TESTS.md diff --git a/PULL_REQUEST_TESTS.md b/PULL_REQUEST_TESTS.md new file mode 100644 index 000000000..1784679e7 --- /dev/null +++ b/PULL_REQUEST_TESTS.md @@ -0,0 +1,11 @@ +This document describes comment messages available to execute tests on pull request. + +|Comment |Description| +|:----------------------:|:---------:| +|`run ci` |Executes all described below.| +|`renderer-android` |Executes [renderer](https://github.com/NativeScript/nativescript-angular/tree/master/e2e/renderer) tests app for Android.| +|`renderer-ios` |Executes [renderer](https://github.com/NativeScript/nativescript-angular/tree/master/e2e/renderer) tests app for iOS.| +|`router-android` |Executes [router](https://github.com/NativeScript/nativescript-angular/tree/master/e2e/router) tests app for Android.| +|`router-ios` |Executes [router](https://github.com/NativeScript/nativescript-angular/tree/master/e2e/router) tests app for iOS.| +|`tests-android` |Executes [tests](https://github.com/NativeScript/nativescript-angular/tree/master/tests) app for Android.| +|`tests-ios` |Executes [tests](https://github.com/NativeScript/nativescript-angular/tree/master/tests) app for iOS.| From 52139da8aeac1b343ec6f9e8edaffcff3a2f1551 Mon Sep 17 00:00:00 2001 From: Vasil Chimev Date: Fri, 6 Oct 2017 15:08:06 +0300 Subject: [PATCH 2/4] docs: add describe comment messages to test --- PULL_REQUEST_TESTS.md | 3 +++ 1 file changed, 3 insertions(+) diff --git a/PULL_REQUEST_TESTS.md b/PULL_REQUEST_TESTS.md index 1784679e7..befa24239 100644 --- a/PULL_REQUEST_TESTS.md +++ b/PULL_REQUEST_TESTS.md @@ -7,5 +7,8 @@ This document describes comment messages available to execute tests on pull requ |`renderer-ios` |Executes [renderer](https://github.com/NativeScript/nativescript-angular/tree/master/e2e/renderer) tests app for iOS.| |`router-android` |Executes [router](https://github.com/NativeScript/nativescript-angular/tree/master/e2e/router) tests app for Android.| |`router-ios` |Executes [router](https://github.com/NativeScript/nativescript-angular/tree/master/e2e/router) tests app for iOS.| +|`sdkwebpack` |Webpacks [SDK](https://github.com/NativeScript/nativescript-sdk-examples-ng) examples app for both Android and iOS.| |`tests-android` |Executes [tests](https://github.com/NativeScript/nativescript-angular/tree/master/tests) app for Android.| |`tests-ios` |Executes [tests](https://github.com/NativeScript/nativescript-angular/tree/master/tests) app for iOS.| +|`testsappng-android` |Executes [TestsAppNg](https://github.com/NativeScript/tests-app-ng) app for Android.| +|`testsappng-ios` |Executes [TestsAppNg](https://github.com/NativeScript/tests-app-ng) app for iOS.| From 98aec2b36ecae98b1fe64080db3318bc047e019a Mon Sep 17 00:00:00 2001 From: vchimev Date: Thu, 12 Oct 2017 11:49:35 +0300 Subject: [PATCH 3/4] docs: add notes --- PULL_REQUEST_TESTS.md | 38 ++++++++++++++++++++++++-------------- 1 file changed, 24 insertions(+), 14 deletions(-) diff --git a/PULL_REQUEST_TESTS.md b/PULL_REQUEST_TESTS.md index befa24239..bfa44a42c 100644 --- a/PULL_REQUEST_TESTS.md +++ b/PULL_REQUEST_TESTS.md @@ -1,14 +1,24 @@ -This document describes comment messages available to execute tests on pull request. - -|Comment |Description| -|:----------------------:|:---------:| -|`run ci` |Executes all described below.| -|`renderer-android` |Executes [renderer](https://github.com/NativeScript/nativescript-angular/tree/master/e2e/renderer) tests app for Android.| -|`renderer-ios` |Executes [renderer](https://github.com/NativeScript/nativescript-angular/tree/master/e2e/renderer) tests app for iOS.| -|`router-android` |Executes [router](https://github.com/NativeScript/nativescript-angular/tree/master/e2e/router) tests app for Android.| -|`router-ios` |Executes [router](https://github.com/NativeScript/nativescript-angular/tree/master/e2e/router) tests app for iOS.| -|`sdkwebpack` |Webpacks [SDK](https://github.com/NativeScript/nativescript-sdk-examples-ng) examples app for both Android and iOS.| -|`tests-android` |Executes [tests](https://github.com/NativeScript/nativescript-angular/tree/master/tests) app for Android.| -|`tests-ios` |Executes [tests](https://github.com/NativeScript/nativescript-angular/tree/master/tests) app for iOS.| -|`testsappng-android` |Executes [TestsAppNg](https://github.com/NativeScript/tests-app-ng) app for Android.| -|`testsappng-ios` |Executes [TestsAppNg](https://github.com/NativeScript/tests-app-ng) app for iOS.| +### Pull Requests Checks + +Builds distributed between Travis CI and internal Jenkins CI execute on pull requests. By default, Travis CI builds trigger on community pull requests and both Travis CI and Jenkins CI builds trigger on core team pull requests. Only NativeScript members have rights to trigger internal Jenkins CI builds. In long term, we aim to migrate all the builds in a public cloud environment. + +### Travis + +This build compiles the `nativescript-angular` plugin and builds the [tests](https://github.com/NativeScript/nativescript-angular/tree/master/tests) app for Android. Please, refer to the [.travis.yml](https://github.com/NativeScript/nativescript-angular/blob/master/.travis.yml) config file for complete information. + +### Jenkins + +More extensive tests execute in Jenkins CI. The table below describes how to trigger and the location of the app/tests of all builds available to execute tests on pull requests. + +|Comment |Description| +|:------------------:|:---------:| +|`run ci` |Executes all described below.| +|`renderer-android` |Executes [renderer](https://github.com/NativeScript/nativescript-angular/tree/master/e2e/renderer) tests app for Android.| +|`renderer-ios` |Executes [renderer](https://github.com/NativeScript/nativescript-angular/tree/master/e2e/renderer) tests app for iOS.| +|`router-android` |Executes [router](https://github.com/NativeScript/nativescript-angular/tree/master/e2e/router) tests app for Android.| +|`router-ios` |Executes [router](https://github.com/NativeScript/nativescript-angular/tree/master/e2e/router) tests app for iOS.| +|`sdkwebpack` |Webpacks [SDK](https://github.com/NativeScript/nativescript-sdk-examples-ng) examples app for both Android and iOS.| +|`tests-android` |Executes [tests](https://github.com/NativeScript/nativescript-angular/tree/master/tests) app for Android.| +|`tests-ios` |Executes [tests](https://github.com/NativeScript/nativescript-angular/tree/master/tests) app for iOS.| +|`testsappng-android`|Executes [TestsAppNg](https://github.com/NativeScript/tests-app-ng) app for Android.| +|`testsappng-ios` |Executes [TestsAppNg](https://github.com/NativeScript/tests-app-ng) app for iOS.| From 85fb879b3e98d2eb32c044069237b465ee5cec0a Mon Sep 17 00:00:00 2001 From: Vasil Chimev Date: Mon, 16 Oct 2017 01:36:08 +0300 Subject: [PATCH 4/4] docs: add notes --- PULL_REQUEST_TESTS.md | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/PULL_REQUEST_TESTS.md b/PULL_REQUEST_TESTS.md index bfa44a42c..db4207541 100644 --- a/PULL_REQUEST_TESTS.md +++ b/PULL_REQUEST_TESTS.md @@ -4,11 +4,11 @@ Builds distributed between Travis CI and internal Jenkins CI execute on pull req ### Travis -This build compiles the `nativescript-angular` plugin and builds the [tests](https://github.com/NativeScript/nativescript-angular/tree/master/tests) app for Android. Please, refer to the [.travis.yml](https://github.com/NativeScript/nativescript-angular/blob/master/.travis.yml) config file for complete information. +This builds the `nativescript-angular` package and the [tests](https://github.com/NativeScript/nativescript-angular/tree/master/tests) app for Android. Please, refer to the [.travis.yml](https://github.com/NativeScript/nativescript-angular/blob/master/.travis.yml) config file for complete information. ### Jenkins -More extensive tests execute in Jenkins CI. The table below describes how to trigger and the location of the app/tests of all builds available to execute tests on pull requests. +More extensive tests execute in Jenkins CI. As it is an internal environment, these builds cannot be triggered from people outside the NativeScript organization. In order to trigger a build mannually, you need to comment inside the pull request. The table below describes the comment messages and the locations of the app/tests of all builds available to execute tests on pull requests. |Comment |Description| |:------------------:|:---------:|