Skip to content

Update zone.js peer dependency #1867

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
m-abs opened this issue Jun 18, 2019 · 1 comment
Closed

Update zone.js peer dependency #1867

m-abs opened this issue Jun 18, 2019 · 1 comment
Labels
done enhancement

Comments

@m-abs
Copy link
Contributor

m-abs commented Jun 18, 2019

Environment
Provide version numbers for the following components (information can be retrieved by running tns info in your project folder or by inspecting the package.json of the project):

  • CLI: 5.4.x
  • Cross-platform modules: 5.4.2
  • Android Runtime: 5.4.0
  • iOS Runtime:
  • Plugin(s):
  • NativeScript-Angular: 8.0.1
  • Angular: 8.0.0

Describe the bug

Angular 8+ depends on zone.js@^0.9.1 but nativescript-angular wants zone.js@^0.8.4.

To Reproduce

On a nativescript-angular 8.0.1 project -> Run: npm ls

npm WARN [email protected] requires a peer of zone.js@^0.8.4 but none is installed. You must install peer dependencies yourself.

Expected behavior
No warning about peer dependency.
@tsonevn
Copy link
Contributor

tsonevn commented Jun 19, 2019

PR: #1869

@tsonevn tsonevn added the done label Jun 20, 2019
@tsonevn tsonevn closed this as completed Jun 20, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
done enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@m-abs @tsonevn