Skip to content

_routerExtensions.back() causes crash after closing modal #1735

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
jeffswitzer opened this issue Feb 15, 2019 · 1 comment
Closed

_routerExtensions.back() causes crash after closing modal #1735

jeffswitzer opened this issue Feb 15, 2019 · 1 comment
Assignees

Comments

@jeffswitzer
Copy link

Environment
have only tried on android

Describe the bug
After closing a modal, back navigation via routerExtension doesn't work resulting in a runtime error.

To Reproduce
Open this nativescript playground

  1. using router, navigate from component1 to component2
  2. open a modal inside component2
  3. close the modal
  4. click back to attempt to navigate back from component2 to component1
  5. runtime error says: ERROR TypeError: Cannot read property 'isPageNavigationBack' of undefined

Expected behavior
The back navigation should take you back to component 1

Additional context
This may be related to #1350

@tsonevn tsonevn self-assigned this Feb 18, 2019
@tsonevn
Copy link
Contributor

tsonevn commented Feb 18, 2019

Hi @jeffswitzer,
I was able to recreate the issue while using your demo app and will mark this problem as a bug. It seems that there is an issue with the router-outlet. As a workaround, I would suggest using page-router-outlet. Check out the example here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants