Skip to content

fix: Import reflect-metadata(needed in JIT mode) before @angular #1530

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Sep 25, 2018

Conversation

vakrilov
Copy link
Contributor

@vakrilov vakrilov commented Sep 25, 2018

reflect-metadata is need in JIT mode and needs to be imported before @angular\core. It contains calls to __metadata and other methods that rely on global Reflect to be defined.

Related to #1454

@ghost ghost assigned vakrilov Sep 25, 2018
@ghost ghost added the in progress label Sep 25, 2018
@vakrilov vakrilov requested a review from sis0k0 September 25, 2018 11:58
@vakrilov vakrilov force-pushed the fix-reflect-metadata-jit branch from 2926cfb to ab166c9 Compare September 25, 2018 12:04
@ghost ghost assigned vchimev Sep 25, 2018
@SvetoslavTsenov SvetoslavTsenov self-requested a review September 25, 2018 12:51
@vakrilov vakrilov merged commit 6e45af0 into master Sep 25, 2018
@vakrilov vakrilov deleted the fix-reflect-metadata-jit branch September 25, 2018 12:53
@ghost ghost removed the in progress label Sep 25, 2018
NathanWalker pushed a commit to NathanWalker/nativescript-angular that referenced this pull request Oct 10, 2018
…iveScript#1530)

* fix: Import reflect-metadata(needed in JIT mode) before @angular

* docs: update a comment
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants