fix(animations): provide fake document object in both AoT and JiT mode #1164
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The fake document object that is needed for the angular animations should be provided both when using the static platform and the dynamic one. Can be tested with https://github.com/nativescript/ns-ng-animation-examples. ```bash // 1 git clone https://github.com/nativescript/ns-ng-animation-examples // 2 tns run android --bundle --env.aot // 3 // Navigate to the first example and expect the button to animate to opacity 0 when tapped. ``` fixes #1163
ghost
assigned 
vakrilov
approved these changes
Jan 23, 2018
manoldonev
approved these changes
Jan 23, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The fake document object that is needed for the angular animations
should be provided both when using the static platform and the dynamic
one.
Can be tested with
https://github.com/nativescript/ns-ng-animation-examples.
fixes #1163