Skip to content

Commit f8dfb2a

Browse files
author
vakrilov
committed
refactor: Renamed some methods for clarity
1 parent 1ad18cc commit f8dfb2a

File tree

3 files changed

+10
-10
lines changed

3 files changed

+10
-10
lines changed

Diff for: nativescript-angular/http-client/http-utils.ts

+1-1
Original file line numberDiff line numberDiff line change
@@ -17,7 +17,7 @@ export function getAbsolutePath(url: string, nsFileSystem: NSFileSystem): string
1717
return url;
1818
}
1919

20-
export function handleLocalRequest<T>(
20+
export function processLocalFileRequest<T>(
2121
url: string,
2222
nsFileSystem: NSFileSystem,
2323
successResponse: httpResponseFactory<T>,

Diff for: nativescript-angular/http-client/ns-http-backend.ts

+4-4
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@ import {
77
import { Observable } from "rxjs/Observable";
88

99
import { NSFileSystem } from "../file-system/ns-file-system";
10-
import { isLocalRequest, handleLocalRequest } from "./http-utils";
10+
import { isLocalRequest, processLocalFileRequest } from "./http-utils";
1111

1212
@Injectable()
1313
export class NsHttpBackEnd extends HttpXhrBackend {
@@ -19,16 +19,16 @@ export class NsHttpBackEnd extends HttpXhrBackend {
1919
let result: Observable<HttpEvent<any>>;
2020

2121
if (isLocalRequest(req.url)) {
22-
result = this.handleLocalRequest(req.url);
22+
result = this.handleLocalFileRequest(req.url);
2323
} else {
2424
result = super.handle(req);
2525
}
2626

2727
return result;
2828
}
2929

30-
private handleLocalRequest(url: string): Observable<HttpEvent<any>> {
31-
return handleLocalRequest(
30+
private handleLocalFileRequest(url: string): Observable<HttpEvent<any>> {
31+
return processLocalFileRequest(
3232
url,
3333
this.nsFileSystem,
3434
createSuccessResponse,

Diff for: nativescript-angular/http/ns-http.ts

+5-5
Original file line numberDiff line numberDiff line change
@@ -12,7 +12,7 @@ import {
1212
import { Observable } from "rxjs/Observable";
1313
import "rxjs/add/observable/fromPromise";
1414

15-
import { isLocalRequest, handleLocalRequest } from "../http-client/http-utils";
15+
import { isLocalRequest, processLocalFileRequest } from "../http-client/http-utils";
1616

1717
import { NSFileSystem } from "../file-system/ns-file-system";
1818

@@ -34,7 +34,7 @@ export class NSHttp extends Http {
3434
request(req: string | Request, options?: RequestOptionsArgs): Observable<Response> {
3535
const urlString = typeof req === "string" ? req : req.url;
3636
if (isLocalRequest(urlString)) {
37-
return this.handleLocalRequest(urlString);
37+
return this.requestLocalFile(urlString);
3838
} else {
3939
return super.request(req, options);
4040
}
@@ -45,14 +45,14 @@ export class NSHttp extends Http {
4545
*/
4646
get(url: string, options?: RequestOptionsArgs): Observable<Response> {
4747
if (isLocalRequest(url)) {
48-
return this.handleLocalRequest(url);
48+
return this.requestLocalFile(url);
4949
} else {
5050
return super.get(url, options);
5151
}
5252
}
5353

54-
private handleLocalRequest(url: string): Observable<Response> {
55-
return handleLocalRequest(
54+
private requestLocalFile(url: string): Observable<Response> {
55+
return processLocalFileRequest(
5656
url,
5757
this.nsFileSystem,
5858
createResponse,

0 commit comments

Comments
 (0)