refactor: separate NativeScriptCommonModule from NativeScriptModule

All common providers, such as CommonModule (from @angular/common), Frame, Page, Device and Modals are moved from NativeScriptModule to NativeScriptCommonModule. It can be required from "nativescript-angular/common". The NativeScriptRouterModule also imports the common module now.
Importing NativeScriptModule more than once causes reinstantiating of
the NativeScriptRenderer, which breaks animations.

BREAKING CHANGES:
NativeScriptModule should be imported only in the root application
module (usually named AppModule). It provides essential the Renderer, ModuleLoader and exports the
ApplicationModule.
All other NgModules in the app (both feature and lazy-loaded ones)
should import the NativeScriptCommonModule instead.
The behaviour is alligned with BrowserModule and CommonModule in web
Angular apps. https://angular.io/guide/ngmodule-faq#q-browser-vs-common-module

Author: sis0k0

Diff for: nativescript-angular/common.ts

@@ -0,0 +1,40 @@
+import { CommonModule } from "@angular/common";
+import {
+    NO_ERRORS_SCHEMA,
+    NgModule,
+} from "@angular/core";
+
+import {
+    ModalDialogHost,
+    ModalDialogService,
+} from "./directives/dialogs";
+import {
+    defaultDeviceProvider,
+    defaultFrameProvider,
+    defaultPageProvider,
+} from "./platform-providers";
+import { NS_DIRECTIVES } from "./directives";
+
+@NgModule({
+    declarations: [
+        ModalDialogHost,
+        ...NS_DIRECTIVES,
+    ],
+    providers: [
+        ModalDialogService,
+        defaultDeviceProvider,
+        defaultFrameProvider,
+        defaultPageProvider,
+    ],
+    imports: [
+        CommonModule,
+    ],
+    exports: [
+        CommonModule,
+        ModalDialogHost,
+        ...NS_DIRECTIVES,
+    ],
+    schemas: [NO_ERRORS_SCHEMA]
+})
+export class NativeScriptCommonModule {
+}

Diff for: nativescript-angular/nativescript.module.ts

@@ -7,7 +7,6 @@ import "reflect-metadata";
 import "./polyfills/array";
 import "./polyfills/console";
 
-import { CommonModule } from "@angular/common";
 import {
     ApplicationModule,
     ErrorHandler,
@@ -17,18 +16,9 @@ import {
     SystemJsNgModuleLoader,
 } from "@angular/core";
 
+import { NativeScriptCommonModule } from "./common";
 import { NativeScriptRendererFactory } from "./renderer";
 import { DetachedLoader } from "./common/detached-loader";
-import {
-    ModalDialogHost,
-    ModalDialogService,
-} from "./directives/dialogs";
-import {
-    defaultDeviceProvider,
-    defaultFrameProvider,
-    defaultPageProvider,
-} from "./platform-providers";
-import { NS_DIRECTIVES } from "./directives";
 
 export function errorHandlerFactory() {
     return new ErrorHandler(true);
@@ -37,32 +27,24 @@ export function errorHandlerFactory() {
 @NgModule({
     declarations: [
         DetachedLoader,
-        ModalDialogHost,
-        ...NS_DIRECTIVES,
     ],
     providers: [
-        ModalDialogService,
         NativeScriptRendererFactory,
         SystemJsNgModuleLoader,
-        defaultDeviceProvider,
-        defaultFrameProvider,
-        defaultPageProvider,
         { provide: ErrorHandler, useFactory: errorHandlerFactory },
-        { provide: RendererFactory2, useClass: NativeScriptRendererFactory },
+        { provide: RendererFactory2, useExisting: NativeScriptRendererFactory },
     ],
     entryComponents: [
         DetachedLoader,
     ],
     imports: [
-        CommonModule,
         ApplicationModule,
+        NativeScriptCommonModule,
     ],
     exports: [
-        CommonModule,
         ApplicationModule,
+        NativeScriptCommonModule,
         DetachedLoader,
-        ModalDialogHost,
-        ...NS_DIRECTIVES,
     ],
     schemas: [NO_ERRORS_SCHEMA]
 })

Diff for: nativescript-angular/router.ts

@@ -14,7 +14,7 @@ import { PageRouterOutlet } from "./router/page-router-outlet";
 import { NSLocationStrategy, LocationState } from "./router/ns-location-strategy";
 import { NativescriptPlatformLocation } from "./router/ns-platform-location";
 import { RouterExtensions } from "./router/router-extensions";
-import { NativeScriptModule } from "./nativescript.module";
+import { NativeScriptCommonModule } from "./common";
 
 export { PageRoute } from "./router/page-router-outlet";
 export { RouterExtensions } from "./router/router-extensions";
@@ -40,7 +40,7 @@ export type LocationState = LocationState;
     ],
     imports: [
         RouterModule,
-        NativeScriptModule
+        NativeScriptCommonModule,
     ],
     exports: [
         RouterModule,