Skip to content

Commit d8302c4

Browse files
author
vakrilov
committed
refactor(typo): Fix mor typos
1 parent 1828df5 commit d8302c4

File tree

3 files changed

+10
-10
lines changed

3 files changed

+10
-10
lines changed

Diff for: nativescript-angular/router.ts

+3-3
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,7 @@ import { NSRouterLinkActive } from "./router/ns-router-link-active";
1313
import { PageRouterOutlet } from "./router/page-router-outlet";
1414
import { NSLocationStrategy, LocationState } from "./router/ns-location-strategy";
1515
import { NativescriptPlatformLocation } from "./router/ns-platform-location";
16-
import { NsRouteReuseStrategy } from "./router/ns-route-reuse-strategy";
16+
import { NSRouteReuseStrategy } from "./router/ns-route-reuse-strategy";
1717
import { RouterExtensions } from "./router/router-extensions";
1818
import { NativeScriptCommonModule } from "./common";
1919

@@ -38,8 +38,8 @@ export type LocationState = LocationState;
3838
NativescriptPlatformLocation,
3939
{ provide: PlatformLocation, useClass: NativescriptPlatformLocation },
4040
RouterExtensions,
41-
NsRouteReuseStrategy,
42-
{ provide: RouteReuseStrategy, useExisting: NsRouteReuseStrategy }
41+
NSRouteReuseStrategy,
42+
{ provide: RouteReuseStrategy, useExisting: NSRouteReuseStrategy }
4343
],
4444
imports: [
4545
RouterModule,

Diff for: nativescript-angular/router/ns-route-reuse-strategy.ts

+5-5
Original file line numberDiff line numberDiff line change
@@ -50,7 +50,7 @@ class DetachedStateCache {
5050
* Does not detach any subtrees. Reuses routes as long as their route config is the same.
5151
*/
5252
@Injectable()
53-
export class NsRouteReuseStrategy implements RouteReuseStrategy {
53+
export class NSRouteReuseStrategy implements RouteReuseStrategy {
5454
private cache: DetachedStateCache = new DetachedStateCache();
5555

5656
constructor(private location: NSLocationStrategy) { }
@@ -69,11 +69,11 @@ export class NsRouteReuseStrategy implements RouteReuseStrategy {
6969
shouldAttach(route: ActivatedRouteSnapshot): boolean {
7070
const key = getSnapshotKey(route);
7171
const isBack = this.location._isPageNavigatingBack();
72-
const shouldDetach = isBack && this.cache.peek().key === key;
72+
const shouldAttach = isBack && this.cache.peek().key === key;
7373

74-
log(`shouldAttach isBack: ${isBack} key: ${key} result: ${shouldDetach}`);
74+
log(`shouldAttach isBack: ${isBack} key: ${key} result: ${shouldAttach}`);
7575

76-
return shouldDetach;
76+
return shouldAttach;
7777
}
7878

7979

@@ -114,7 +114,7 @@ export class NsRouteReuseStrategy implements RouteReuseStrategy {
114114

115115
if (shouldReuse && curr && curr[pageRouterActivatedSymbol]) {
116116
// When reusing route - copy the pageRouterActivated to the new snapshot
117-
// Its needed in shouldDetach to determine if the route should be detached.
117+
// It's needed in shouldDetach to determine if the route should be detached.
118118
future[pageRouterActivatedSymbol] = curr[pageRouterActivatedSymbol];
119119
}
120120

Diff for: nativescript-angular/router/page-router-outlet.ts

+2-2
Original file line numberDiff line numberDiff line change
@@ -24,7 +24,7 @@ import { routerLog } from "../trace";
2424
import { DetachedLoader } from "../common/detached-loader";
2525
import { ViewUtil } from "../view-util";
2626
import { NSLocationStrategy } from "./ns-location-strategy";
27-
import { NsRouteReuseStrategy } from "./ns-route-reuse-strategy";
27+
import { NSRouteReuseStrategy } from "./ns-route-reuse-strategy";
2828

2929
export class PageRoute {
3030
activatedRoute: BehaviorSubject<ActivatedRoute>;
@@ -117,7 +117,7 @@ export class PageRouterOutlet implements OnDestroy, OnInit { // tslint:disable-l
117117
private changeDetector: ChangeDetectorRef,
118118
@Inject(DEVICE) device: Device,
119119
@Inject(PAGE_FACTORY) private pageFactory: PageFactory,
120-
private routeReuseStrategy: NsRouteReuseStrategy
120+
private routeReuseStrategy: NSRouteReuseStrategy
121121
) {
122122

123123
this.name = name || PRIMARY_OUTLET;

0 commit comments

Comments
 (0)