fix(forms): extract on-touch logic to BaseValueAccessor

Author: sis0k0

Diff for: nativescript-angular/value-accessors/base-value-accessor.ts

@@ -1,10 +1,11 @@
 import { ControlValueAccessor } from "@angular/forms";
 
 export class BaseValueAccessor<TView> implements ControlValueAccessor {
-    constructor(public view: TView) { }
-
-    onChange = (_) => { };
     private pendingChangeNotification: number = 0;
+    onChange = (_) => { };
+    onTouched = () => {};
+
+    constructor(public view: TView) { }
 
     registerOnChange(fn: (_: any) => void): void {
         this.onChange = (arg) => {
@@ -18,11 +19,7 @@ export class BaseValueAccessor<TView> implements ControlValueAccessor {
         };
     }
 
-    writeValue(_: any) {
-        //
-    }
+    registerOnTouched(fn: () => void): void { this.onTouched = fn; }
 
-    registerOnTouched(_: () => void): void {
-        //
-    }
+    writeValue(_: any) { }
 }

Diff for: nativescript-angular/value-accessors/checked-value-accessor.ts

@@ -29,17 +29,11 @@ const CHECKED_VALUE_ACCESSOR = {
     },
 })
 export class CheckedValueAccessor extends BaseValueAccessor<Switch> { // tslint:disable-line:directive-class-suffix
-    onChange = (_: any) => {};
-    onTouched = () => {};
-
     constructor(elementRef: ElementRef) {
         super(elementRef.nativeElement);
     }
 
     writeValue(value: any): void {
         this.view.checked = value;
     }
-
-    registerOnChange(fn: (_: any) => {}): void { this.onChange = fn; }
-    registerOnTouched(fn: () => void): void { this.onTouched = fn; }
 }

Diff for: nativescript-angular/value-accessors/date-value-accessor.ts

@@ -30,17 +30,11 @@ const DATE_VALUE_ACCESSOR = {
     },
 })
 export class DateValueAccessor extends BaseValueAccessor<DatePicker> { // tslint:disable-line:directive-class-suffix
-    onChange = (_: any) => {};
-    onTouched = () => {};
-
     constructor(elementRef: ElementRef) {
         super(elementRef.nativeElement);
     }
 
     writeValue(value: any): void {
         this.view.date = value;
     }
-
-    registerOnChange(fn: (_: any) => {}): void { this.onChange = fn; }
-    registerOnTouched(fn: () => void): void { this.onTouched = fn; }
 }

Diff for: nativescript-angular/value-accessors/number-value-accessor.ts

@@ -29,17 +29,11 @@ const NUMBER_VALUE_ACCESSOR = {
     },
 })
 export class NumberValueAccessor extends BaseValueAccessor<Slider> { // tslint:disable-line:directive-class-suffix
-    onChange = (_: any) => {};
-    onTouched = () => {};
-
     constructor(elementRef: ElementRef) {
         super(elementRef.nativeElement);
     }
 
     writeValue(value: any): void {
         this.view.value = value;
     }
-
-    registerOnChange(fn: (_: any) => {}): void { this.onChange = fn; }
-    registerOnTouched(fn: () => void): void { this.onTouched = fn; }
 }

Diff for: nativescript-angular/value-accessors/selectedIndex-value-accessor.ts

@@ -43,9 +43,6 @@ export type SelectableView = {selectedIndex: number} & View;
     },
 })
 export class SelectedIndexValueAccessor extends BaseValueAccessor<SelectableView> implements AfterViewInit { // tslint:disable-line:max-line-length directive-class-suffix
-    onChange = (_: any) => {};
-    onTouched = () => {};
-
     constructor(elementRef: ElementRef) {
         super(elementRef.nativeElement);
     }
@@ -55,6 +52,7 @@ export class SelectedIndexValueAccessor extends BaseValueAccessor<SelectableView
 
     writeValue(value: any): void {
         this.value = value;
+
         if (this.viewInitialized) {
             this.view.selectedIndex = this.value;
         }
@@ -64,7 +62,4 @@ export class SelectedIndexValueAccessor extends BaseValueAccessor<SelectableView
         this.viewInitialized = true;
         this.view.selectedIndex = this.value;
     }
-
-    registerOnChange(fn: (_: any) => {}): void { this.onChange = fn; }
-    registerOnTouched(fn: () => void): void { this.onTouched = fn; }
 }

Diff for: nativescript-angular/value-accessors/text-value-accessor.ts

@@ -39,21 +39,15 @@ export type TextView = {text: string} & View;
     providers: [TEXT_VALUE_ACCESSOR],
     host: {
         "(touch)": "onTouch()",
-        "(textChange)": "onChange(event.value)",
+        "(textChange)": "onChange($event.value)",
     },
 })
 export class TextValueAccessor extends BaseValueAccessor<TextView> { // tslint:disable-line:directive-class-suffix
-    onChange = (_: any) => {};
-    onTouched = () => {};
-
     constructor(elementRef: ElementRef) {
         super(elementRef.nativeElement);
     }
 
     writeValue(value: any): void {
         this.view.text = value;
     }
-
-    registerOnChange(fn: (_: any) => {}): void { this.onChange = fn; }
-    registerOnTouched(fn: () => void): void { this.onTouched = fn; }
 }

Diff for: nativescript-angular/value-accessors/time-value-accessor.ts

@@ -31,17 +31,11 @@ const TIME_VALUE_ACCESSOR = {
     },
 })
 export class TimeValueAccessor extends BaseValueAccessor<TimePicker> { // tslint:disable-line:directive-class-suffix
-    onChange = (_: any) => {};
-    onTouched = () => { };
-
     constructor(elementRef: ElementRef) {
         super(elementRef.nativeElement);
     }
 
     writeValue(value: any): void {
         this.view.time = value;
     }
-
-    registerOnChange(fn: (_: any) => {}): void { this.onChange = fn; }
-    registerOnTouched(fn: () => void): void { this.onTouched = fn; }
 }