Enable TypeScript checks for unused locals and parameters.

Author: hdeshev

Diff for: nativescript-angular/animation-driver.ts

@@ -16,7 +16,7 @@ export class NativeScriptAnimationDriver implements AnimationDriver {
         return (<View>element).style._getValue(getPropertyByCssName(prop));
     }
 
-    animate(element: any, startingStyles: AnimationStyles, keyframes: AnimationKeyframe[], duration: number, delay: number, easing: string): AnimationPlayer {
+    animate(element: any, _startingStyles: AnimationStyles, keyframes: AnimationKeyframe[], duration: number, delay: number, easing: string): AnimationPlayer {
         return new NativeScriptAnimationPlayer(element, keyframes, duration, delay, easing);
     }
 }

Diff for: nativescript-angular/animation-player.ts

@@ -98,7 +98,7 @@ export class NativeScriptAnimationPlayer implements AnimationPlayer {
             this._onStart();
             this.animation.play(this.target)
                 .then(() => { this._onFinish(); })
-                .catch((e) => { });
+                .catch((_e) => { });
         }
     }
 
@@ -126,7 +126,7 @@ export class NativeScriptAnimationPlayer implements AnimationPlayer {
         this._onFinish();
     }
 
-    setPosition(p: any): void {
+    setPosition(_p: any): void {
         throw new Error("AnimationPlayer.setPosition method is not supported!");
     }
 

Diff for: nativescript-angular/collection-facade.ts

@@ -131,66 +131,3 @@ function _flattenArray(source: any[], target: any[]): any[] {
   }
   return target;
 }
-
-export class StringMapWrapper {
-  static create(): {[k: /*any*/ string]: any} {
-    // Note: We are not using Object.create(null) here due to
-    // performance!
-    // http://jsperf.com/ng2-object-create-null
-    return {};
-  }
-  static contains(map: {[key: string]: any}, key: string): boolean {
-    return map.hasOwnProperty(key);
-  }
-  static get<V>(map: {[key: string]: V}, key: string): V {
-    return map.hasOwnProperty(key) ? map[key] : undefined;
-  }
-  static set<V>(map: {[key: string]: V}, key: string, value: V) { map[key] = value; }
-
-  static keys(map: {[key: string]: any}): string[] { return Object.keys(map); }
-  static values<T>(map: {[key: string]: T}): T[] {
-    return Object.keys(map).map((k: string): T => map[k]);
-  }
-  static isEmpty(map: {[key: string]: any}): boolean {
-    for (var prop in map) {
-      return false;
-    }
-    return true;
-  }
-  static delete (map: {[key: string]: any}, key: string) { delete map[key]; }
-  static forEach<K, V>(map: {[key: string]: V}, callback: (v: V, K: string) => void) {
-    for (let k of Object.keys(map)) {
-      callback(map[k], k);
-    }
-  }
-
-  static merge<V>(m1: {[key: string]: V}, m2: {[key: string]: V}): {[key: string]: V} {
-    var m: {[key: string]: V} = {};
-
-    for (let k of Object.keys(m1)) {
-      m[k] = m1[k];
-    }
-
-    for (let k of Object.keys(m2)) {
-      m[k] = m2[k];
-    }
-
-    return m;
-  }
-
-  static equals<V>(m1: {[key: string]: V}, m2: {[key: string]: V}): boolean {
-    var k1 = Object.keys(m1);
-    var k2 = Object.keys(m2);
-    if (k1.length != k2.length) {
-      return false;
-    }
-    var key: any /** TODO #???? */;
-    for (var i = 0; i < k1.length; i++) {
-      key = k1[i];
-      if (m1[key] !== m2[key]) {
-        return false;
-      }
-    }
-    return true;
-  }
-}

Diff for: nativescript-angular/common/detached-loader.ts

@@ -4,12 +4,6 @@ import {
 } from '@angular/core';
 import * as trace from "trace";
 
-type AnyComponentRef = ComponentRef<any>;
-interface PendingLoadEntry {
-    componentType: Type<any>;
-    resolveCallback: (AnyComponentRef) => void;
-}
-
 export const CATEGORY = "detached-loader";
 function log(message: string) {
     trace.write(message, CATEGORY);

Diff for: nativescript-angular/directives/action-bar.ts

@@ -7,7 +7,7 @@ import { registerElement, ViewClassMeta, NgView } from '../element-registry';
 
 var actionBarMeta: ViewClassMeta = {
     skipAddToDom: true,
-    insertChild: (parent: NgView, child: NgView, atIndex: number) => {
+    insertChild: (parent: NgView, child: NgView, _atIndex: number) => {
         const bar = <ActionBar>(<any>parent);
         const childView = <any>child;
 

Diff for: nativescript-angular/directives/dialogs.ts

@@ -39,7 +39,7 @@ export class ModalDialogService {
         const resolver: ComponentFactoryResolver = viewContainerRef.injector.get(ComponentFactoryResolver);
         const pageFactory: PageFactory = viewContainerRef.injector.get(PAGE_FACTORY);
 
-        return new Promise((resolve, reject) => {
+        return new Promise((resolve) => {
             setTimeout(() => ModalDialogService.showDialog(type, options, resolve, viewContainerRef, resolver, parentPage, pageFactory), 10);
         });
     }

Diff for: nativescript-angular/directives/list-view-comp.ts

@@ -79,13 +79,13 @@ export class ListViewComponent implements DoCheck, OnDestroy, AfterContentInit {
             needDiffer = false;
         }
         if (needDiffer && !this._differ && isListLikeIterable(value)) {
-            this._differ = this._iterableDiffers.find(this._items).create(this._cdr, (index, item) => { return item; });
+            this._differ = this._iterableDiffers.find(this._items).create(this._cdr, (_index, item) => { return item; });
         }
 
         this.listView.items = this._items;
     }
 
-    constructor(private _elementRef: ElementRef,
+    constructor(_elementRef: ElementRef,
         private _iterableDiffers: IterableDiffers,
         private _cdr: ChangeDetectorRef) {
         this.listView = _elementRef.nativeElement;

Diff for: nativescript-angular/directives/tab-view.ts

@@ -1,8 +1,8 @@
-import {ElementRef, Directive, Input, TemplateRef, ViewContainerRef} from "@angular/core";
-import {TabView, TabViewItem} from "ui/tab-view";
+import { ElementRef, Directive, Input, TemplateRef, ViewContainerRef } from "@angular/core";
+import { TabView, TabViewItem } from "ui/tab-view";
 import * as utils from '../common/utils';
-import {rendererLog, rendererError} from "../trace";
-import {isBlank} from "../lang-facade";
+import { rendererLog } from "../trace";
+import { isBlank } from "../lang-facade";
 
 @Directive({
     selector: 'TabView',
@@ -24,7 +24,7 @@ export class TabViewDirective {
         }
     }
 
-    constructor(private element: ElementRef) {
+    constructor(element: ElementRef) {
         this.tabView = element.nativeElement;
     }
 

Diff for: nativescript-angular/dom-adapter.ts

@@ -1,8 +1,8 @@
 import { ElementSchemaRegistry } from '@angular/compiler';
-import { Sanitizer, SchemaMetadata } from '@angular/core';
+import { SchemaMetadata } from '@angular/core';
 import { Parse5DomAdapter } from "./parse5_adapter";
 import { setRootDomAdapter } from './private_import_platform-browser';
-import { rendererLog, rendererError } from "./trace";
+import { rendererLog } from "./trace";
 import { print } from "./lang-facade";
 
 export enum SecurityContext {
@@ -15,11 +15,11 @@ export enum SecurityContext {
 }
 
 export class NativeScriptElementSchemaRegistry extends ElementSchemaRegistry {
-  hasProperty(tagName: string, propName: string): boolean {
+  hasProperty(_tagName: string, _propName: string): boolean {
     return true;
   }
 
-  hasElement(tagName: string, schemaMetas: SchemaMetadata[]): boolean {
+  hasElement(_tagName: string, _schemaMetas: SchemaMetadata[]): boolean {
     return true;
   }
 
@@ -32,15 +32,15 @@ export class NativeScriptElementSchemaRegistry extends ElementSchemaRegistry {
     return 'ng-component';
   }
 
-  securityContext(tagName: string, propName: string): any {
+  securityContext(_tagName: string, _propName: string): any {
     return SecurityContext.NONE;
   }
 
-  validateProperty(name: string): { error: boolean, msg?: string } {
+  validateProperty(_name: string): { error: boolean, msg?: string } {
     return { error: false };
   }
 
-  validateAttribute(name: string): { error: boolean, msg?: string } {
+  validateAttribute(_name: string): { error: boolean, msg?: string } {
     return { error: false };
   }
 
@@ -52,7 +52,7 @@ export class NativeScriptElementSchemaRegistry extends ElementSchemaRegistry {
     return propName;
   }
 
-  normalizeAnimationStyleValue(camelCaseProp: string, userProvidedProp: string, val: string | number):
+  normalizeAnimationStyleValue(_camelCaseProp: string, _userProvidedProp: string, val: string | number):
     { error: string, value: string } {
     return { error: null, value: val.toString() };
   }
@@ -64,7 +64,7 @@ export class NativeScriptDomAdapter extends Parse5DomAdapter {
     setRootDomAdapter(new NativeScriptDomAdapter());
   }
 
-  hasProperty(element, name: string) {
+  hasProperty(_element: any, _name: string) {
     //TODO: actually check if the property exists.
     return true;
   }

Diff for: nativescript-angular/http/ns-http.ts

@@ -1,11 +1,11 @@
 import {Injectable} from '@angular/core';
-import {Http, XHRBackend, ConnectionBackend, RequestOptions, RequestOptionsArgs, ResponseOptions, ResponseType, Response, XSRFStrategy} from '@angular/http';
+import {Http, ConnectionBackend, RequestOptionsArgs, ResponseOptions, ResponseType, Response} from '@angular/http';
 import {Observable} from 'rxjs/Observable';
 import 'rxjs/add/observable/fromPromise';
 import {NSFileSystem} from '../file-system/ns-file-system';
 
 export class NSXSRFStrategy {
-  public configureRequest(req: any) {
+  public configureRequest(_req: any) {
     // noop
   }
 }

Diff for: nativescript-angular/parse5_adapter.ts

@@ -47,7 +47,7 @@ export class Parse5DomAdapter extends DomAdapter {
     setRootDomAdapter(new Parse5DomAdapter());
   }
 
-  hasProperty(element: any, name: string): boolean {
+  hasProperty(_element: any, name: string): boolean {
     return _HTMLElementPropertyList.indexOf(name) > -1;
   }
   // TODO(tbosch): don't even call this method when we run the tests on server side
@@ -75,7 +75,7 @@ export class Parse5DomAdapter extends DomAdapter {
 
   get attrToPropMap() { return _attrToPropMap; }
 
-  query(selector: any) { throw _notImplemented('query'); }
+  query(_selector: any) { throw _notImplemented('query'); }
   querySelector(el: any, selector: string): any { return this.querySelectorAll(el, selector)[0]; }
   querySelectorAll(el: any, selector: string): any[] {
     const res: any[] = [];
@@ -121,7 +121,7 @@ export class Parse5DomAdapter extends DomAdapter {
         cssSelector.addClassName(classList[i]);
       }
 
-      matcher.match(cssSelector, function(selector: any, cb: any) { result = true; });
+      matcher.match(cssSelector, function(_selector: any, _cb: any) { result = true; });
     }
     return result;
   }
@@ -171,15 +171,15 @@ export class Parse5DomAdapter extends DomAdapter {
   getInnerHTML(el: any): string {
     return parse5.serialize(this.templateAwareRoot(el), {treeAdapter});
   }
-  getTemplateContent(el: any): Node { return null; }
+  getTemplateContent(_el: any): Node { return null; }
   getOuterHTML(el: any): string {
     const fragment = treeAdapter.createDocumentFragment();
     this.appendChild(fragment, el);
     return parse5.serialize(fragment, {treeAdapter});
   }
   nodeName(node: any): string { return node.tagName; }
   nodeValue(node: any): string { return node.nodeValue; }
-  type(node: any): string { throw _notImplemented('type'); }
+  type(_node: any): string { throw _notImplemented('type'); }
   content(node: any): string { return node.childNodes[0]; }
   firstChild(el: any): Node { return el.firstChild; }
   nextSibling(el: any): Node { return el.nextSibling; }
@@ -313,7 +313,7 @@ export class Parse5DomAdapter extends DomAdapter {
   }
   getShadowRoot(el: any): Element { return el.shadowRoot; }
   getHost(el: any): string { return el.host; }
-  getDistributedNodes(el: any): Node[] { throw _notImplemented('getDistributedNodes'); }
+  getDistributedNodes(_el: any): Node[] { throw _notImplemented('getDistributedNodes'); }
   clone(node: Node): Node {
     const _recursive = (node: any) => {
       const nodeClone = Object.create(Object.getPrototypeOf(node));
@@ -358,7 +358,7 @@ export class Parse5DomAdapter extends DomAdapter {
   getElementsByClassName(element: any, name: string): HTMLElement[] {
     return this.querySelectorAll(element, '.' + name);
   }
-  getElementsByTagName(element: any, name: string): HTMLElement[] {
+  getElementsByTagName(_element: any, _name: string): HTMLElement[] {
     throw _notImplemented('getElementsByTagName');
   }
   classList(element: any): string[] {
@@ -442,13 +442,13 @@ export class Parse5DomAdapter extends DomAdapter {
   hasAttribute(element: any, attribute: string): boolean {
     return element.attribs && element.attribs.hasOwnProperty(attribute);
   }
-  hasAttributeNS(element: any, ns: string, attribute: string): boolean { throw 'not implemented'; }
+  hasAttributeNS(_element: any, _ns: string, _attribute: string): boolean { throw 'not implemented'; }
   getAttribute(element: any, attribute: string): string {
     return element.attribs && element.attribs.hasOwnProperty(attribute) ?
         element.attribs[attribute] :
         null;
   }
-  getAttributeNS(element: any, ns: string, attribute: string): string { throw 'not implemented'; }
+  getAttributeNS(_element: any, _ns: string, _attribute: string): string { throw 'not implemented'; }
   setAttribute(element: any, attribute: string, value: string) {
     if (attribute) {
       element.attribs[attribute] = value;
@@ -457,15 +457,15 @@ export class Parse5DomAdapter extends DomAdapter {
       }
     }
   }
-  setAttributeNS(element: any, ns: string, attribute: string, value: string) {
+  setAttributeNS(_element: any, _ns: string, _attribute: string, _value: string) {
     throw 'not implemented';
   }
   removeAttribute(element: any, attribute: string) {
     if (attribute) {
       delete element.attribs[attribute];
     }
   }
-  removeAttributeNS(element: any, ns: string, name: string) { throw 'not implemented'; }
+  removeAttributeNS(_element: any, _ns: string, _name: string) { throw 'not implemented'; }
   templateAwareRoot(el: any): any {
     return this.isTemplateElement(el) ? treeAdapter.getTemplateContent(el) : el;
   }
@@ -482,7 +482,7 @@ export class Parse5DomAdapter extends DomAdapter {
     return newDoc;
   }
   defaultDoc(): Document { return defDoc = defDoc || this.createHtmlDocument(); }
-  getBoundingClientRect(el: any): any { return {left: 0, top: 0, width: 0, height: 0}; }
+  getBoundingClientRect(_el: any): any { return {left: 0, top: 0, width: 0, height: 0}; }
   getTitle(): string { return this.defaultDoc().title || ''; }
   setTitle(newTitle: string) { this.defaultDoc().title = newTitle; }
   isTemplateElement(el: any): boolean {
@@ -556,7 +556,7 @@ export class Parse5DomAdapter extends DomAdapter {
   getLocation(): Location { throw 'not implemented'; }
   getUserAgent(): string { return 'Fake user agent'; }
   getData(el: any, name: string): string { return this.getAttribute(el, 'data-' + name); }
-  getComputedStyle(el: any): any { throw 'not implemented'; }
+  getComputedStyle(_el: any): any { throw 'not implemented'; }
   setData(el: any, name: string, value: string) { this.setAttribute(el, 'data-' + name, value); }
   // TODO(tbosch): move this into a separate environment class once we have it
   setGlobalVar(path: string, value: any) { setValueOnPath(global, path, value); }
@@ -566,15 +566,15 @@ export class Parse5DomAdapter extends DomAdapter {
   getTransitionEnd(): string { return 'transitionend'; }
   supportsAnimation(): boolean { return true; }
 
-  replaceChild(el: any, newNode: any, oldNode: any) { throw new Error('not implemented'); }
-  parse(templateHtml: string) { throw new Error('not implemented'); }
-  invoke(el: Element, methodName: string, args: any[]): any { throw new Error('not implemented'); }
-  getEventKey(event: any): string { throw new Error('not implemented'); }
+  replaceChild(_el: any, _newNode: any, _oldNode: any) { throw new Error('not implemented'); }
+  parse(_templateHtml: string) { throw new Error('not implemented'); }
+  invoke(_el: Element, _methodName: string, _args: any[]): any { throw new Error('not implemented'); }
+  getEventKey(_event: any): string { throw new Error('not implemented'); }
 
   supportsCookies(): boolean { return false; }
-  getCookie(name: string): string { throw new Error('not implemented'); }
-  setCookie(name: string, value: string) { throw new Error('not implemented'); }
-  animate(element: any, keyframes: any[], options: any): any { throw new Error('not implemented'); }
+  getCookie(_name: string): string { throw new Error('not implemented'); }
+  setCookie(_name: string, _value: string) { throw new Error('not implemented'); }
+  animate(_element: any, _keyframes: any[], _options: any): any { throw new Error('not implemented'); }
 }
 
 // TODO: build a proper list, this one is all the keys of a HTMLInputElement