Skip to content

Commit cb4fd3a

Browse files
author
Alexander Vakrilov
authored
Merge pull request #2112 from NativeScript/merge-release-in-master-8-20-4
chore: merge release(8.20.4) in master
2 parents 362e893 + ea6d2fc commit cb4fd3a

File tree

6 files changed

+28
-16
lines changed

6 files changed

+28
-16
lines changed

Diff for: CHANGELOG.md

+11
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,14 @@
1+
<a name="8.20.4"></a>
2+
## [8.20.4](https://github.com/NativeScript/nativescript-angular/compare/8.20.3...8.20.4) (2020-01-07)
3+
4+
5+
### Bug Fixes
6+
7+
* add context to frame navigation ([#2100](https://github.com/NativeScript/nativescript-angular/pull/2100))
8+
* wrong import path in compat package ([#2097](https://github.com/NativeScript/nativescript-angular/pull/2097))
9+
10+
11+
112
<a name="8.20.3"></a>
213
## [8.20.3](https://github.com/NativeScript/nativescript-angular/compare/8.20.2...8.20.3) (2019-11-13)
314

Diff for: nativescript-angular-package/package.json

+1-1
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
{
22
"name": "nativescript-angular",
3-
"version": "8.30.0",
3+
"version": "8.21.0",
44
"description": "An Angular renderer that lets you build mobile apps with NativeScript.",
55
"homepage": "https://www.nativescript.org/",
66
"bugs": "https://github.com/NativeScript/nativescript-angular/issues",
+1-1
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,3 @@
11
// Bootstrap helper module for jasmine spec tests
22
import "@nativescript/angular/platform";
3-
import "@nativescript/angular/dist/zone-nativescript.jasmine.js";
3+
import "@nativescript/angular/zone-js/dist/zone-nativescript.jasmine.js";

Diff for: nativescript-angular/package.json

+1-1
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
{
22
"name": "@nativescript/angular",
3-
"version": "8.30.0",
3+
"version": "8.21.0",
44
"description": "An Angular renderer that lets you build mobile apps with NativeScript.",
55
"homepage": "https://www.nativescript.org/",
66
"bugs": "https://github.com/NativeScript/nativescript-angular/issues",

Diff for: nativescript-angular/platform-common.ts

+11-11
Original file line numberDiff line numberDiff line change
@@ -191,19 +191,8 @@ export class NativeScriptPlatformRef extends PlatformRef {
191191
@profile
192192
private bootstrapNativeScriptApp() {
193193
const autoCreateFrame = !!this.appOptions.createFrameOnBootstrap;
194-
let tempAppHostView: AppHostView;
195194
let rootContent: View;
196195

197-
if (autoCreateFrame) {
198-
const { page, frame } = this.createFrameAndPage(false);
199-
setRootPage(page);
200-
rootContent = frame;
201-
} else {
202-
// Create a temp page for root of the renderer
203-
tempAppHostView = new AppHostView();
204-
setRootPage(<any>tempAppHostView);
205-
}
206-
207196
if (isLogEnabled()) {
208197
bootstrapLog("NativeScriptPlatform bootstrap started.");
209198
}
@@ -214,6 +203,17 @@ export class NativeScriptPlatformRef extends PlatformRef {
214203
bootstrapLog("Application launch event fired");
215204
}
216205

206+
let tempAppHostView: AppHostView;
207+
if (autoCreateFrame) {
208+
const { page, frame } = this.createFrameAndPage(false);
209+
setRootPage(page);
210+
rootContent = frame;
211+
} else {
212+
// Create a temp page for root of the renderer
213+
tempAppHostView = new AppHostView();
214+
setRootPage(<any>tempAppHostView);
215+
}
216+
217217
let bootstrapPromiseCompleted = false;
218218
this._bootstrapper().then(
219219
moduleRef => {

Diff for: nativescript-angular/router/page-router-outlet.ts

+3-2
Original file line numberDiff line numberDiff line change
@@ -361,13 +361,13 @@ export class PageRouterOutlet implements OnDestroy { // tslint:disable-line:dire
361361
this.changeDetector.markForCheck();
362362

363363
this.activated = loaderRef.instance.loadWithFactory(factory);
364-
this.loadComponentInPage(page, this.activated);
364+
this.loadComponentInPage(page, this.activated, { activatedRoute });
365365

366366
this.activated[loaderRefSymbol] = loaderRef;
367367
}
368368

369369
@profile
370-
private loadComponentInPage(page: Page, componentRef: ComponentRef<any>): void {
370+
private loadComponentInPage(page: Page, componentRef: ComponentRef<any>, navigationContext): void {
371371
// Component loaded. Find its root native view.
372372
const componentView = componentRef.location.nativeElement;
373373
// Remove it from original native parent.
@@ -406,6 +406,7 @@ export class PageRouterOutlet implements OnDestroy { // tslint:disable-line:dire
406406
create() {
407407
return page;
408408
},
409+
context: navigationContext,
409410
clearHistory: navOptions.clearHistory,
410411
animated: navOptions.animated,
411412
transition: navOptions.transition

0 commit comments

Comments
 (0)