chore: fix issue where nTestBedBeforeEach overwrote its own imports

 - Fixes the DetachedLoader tests, and makes them MUCH simpler.
 - When you configure the test bed module, you need to specify a full list of imports, because they completely overwrite the imports array that is used.
 - That's yet another reason to use the provided helper functions, they merge in the common {N} imports for you.
 - ... and some lint cleanup

Author: justindujardin

Diff for: nativescript-angular/testing/src/util.ts

@@ -80,12 +80,8 @@ export function nTestBedBeforeEach(
             // There's got to be a better way... (o_O)
             TestBed.resetTestEnvironment();
             @NgModule({
-                imports: [
-                    NativeScriptModule, NativeScriptTestingModule, CommonModule
-                ],
-                providers: NATIVESCRIPT_TESTING_PROVIDERS,
-                exports: entryComponents,
                 declarations: entryComponents,
+                exports: entryComponents,
                 entryComponents: entryComponents
             })
             class EntryComponentsTestModule {
@@ -95,9 +91,12 @@ export function nTestBedBeforeEach(
                 platformBrowserDynamicTesting(NS_COMPILER_PROVIDERS)
             );
             TestBed.configureTestingModule({
-                declarations: [...components],
-                imports: [...imports],
-                providers: [...providers],
+                declarations: components,
+                imports: [
+                    NativeScriptModule, NativeScriptTestingModule, CommonModule,
+                    ...imports
+                ],
+                providers: [...providers, ...NATIVESCRIPT_TESTING_PROVIDERS],
             });
         }
         TestBed.compileComponents()

Diff for: tests/app/tests/detached-loader-tests.ts

@@ -1,7 +1,7 @@
 // make sure you import mocha-config before @angular/core
-import {ChangeDetectionStrategy, Component, ViewChild} from '@angular/core';
-import {DetachedLoader} from 'nativescript-angular/common/detached-loader';
-import {nTestBedAfterEach, nTestBedBeforeEach, nTestBedRender} from 'nativescript-angular/testing';
+import { ChangeDetectionStrategy, Component, ViewChild } from "@angular/core";
+import { DetachedLoader } from "nativescript-angular";
+import { nTestBedAfterEach, nTestBedBeforeEach, nTestBedRender } from "nativescript-angular/testing";
 
 @Component({
     template: `<StackLayout><Label text="COMPONENT"></Label></StackLayout>`
@@ -11,18 +11,6 @@ class TestComponent { }
 
 class LoaderComponentBase {
     @ViewChild(DetachedLoader) public loader: DetachedLoader;
-
-    public ready: Promise<LoaderComponentBase>;
-    private resolve;
-    constructor() {
-        this.ready = new Promise((reslove, reject) => {
-            this.resolve = reslove;
-        });
-    }
-    ngAfterViewInit() {
-        console.log("!!! ngAfterViewInit -> loader: " + this.loader);
-        this.resolve(this);
-    }
 }
 
 @Component({
@@ -46,35 +34,23 @@ export class LoaderComponent extends LoaderComponentBase {}
 })
 export class LoaderComponentOnPush extends LoaderComponentBase { }
 
-// TODO(JD): These tests should work, but demonstrate an annoying bug I've noticed sometimes with @ViewChild
-//
-// The @ViewChild(DetachedLoader) on LoaderComponentBase fails. Can anyone shed some light on why?
-xdescribe("DetachedLoader", () => {
+describe("DetachedLoader", () => {
 
     beforeEach(nTestBedBeforeEach([LoaderComponent, LoaderComponentOnPush], [], [], [TestComponent]));
     afterEach(nTestBedAfterEach());
 
-    it("creates component", (done) => {
-        let component: LoaderComponent;
-
-        nTestBedRender(LoaderComponent)
-            .then((fixture) => {
-                component = fixture.componentRef.instance;
-                return component.ready;
-            })
-            .then(() => component.loader.loadComponent(TestComponent))
-            .then(() => done())
-            .catch(done);
+    it("creates component", () => {
+        return nTestBedRender(LoaderComponent).then((fixture) => {
+            const component: LoaderComponent = fixture.componentRef.instance;
+            return component.loader.loadComponent(TestComponent);
+        });
     });
 
 
-    it("creates component when ChangeDetectionStrategy is OnPush", (done) => {
-        nTestBedRender(LoaderComponentOnPush)
-            .then((fixture) => {
-                const component: LoaderComponent = fixture.componentRef.instance;
-                return component.loader.loadComponent(TestComponent);
-            })
-            .then(() => done())
-            .catch(done);
+    it("creates component when ChangeDetectionStrategy is OnPush", () => {
+        return nTestBedRender(LoaderComponentOnPush).then((fixture) => {
+            const component: LoaderComponentOnPush = fixture.componentRef.instance;
+            return component.loader.loadComponent(TestComponent);
+        });
     });
 });

Diff for: tests/app/tests/modal-dialog.ts

@@ -39,9 +39,9 @@ export class FailComponent {
     selector: "sucess-comp",
     providers: [ModalDialogService],
     template: `
-        <GridLayout margin="20">
-            <Label text="Modal dialogs"></Label>
-        </GridLayout>`
+    <GridLayout margin="20">
+        <Label text="Modal dialogs"></Label>
+    </GridLayout>`
 })
 export class SuccessComponent {
     constructor(public service: ModalDialogService, public vcRef: ViewContainerRef) {

Diff for: tests/app/tests/platform-filter-components.ts

@@ -37,9 +37,6 @@ export class PlatformSpecificAttributeComponent {
 }
 
 describe("Platform filter directives", () => {
-    // TODO: Something is different in dumpView. I suspect it has to do with the fact that the old
-    // test app class rendered directly into a view container and returned the exact component, whereas
-    // testbed appears to return a reference to the root component? Needs investigation.
     describe("on IOS device", () => {
         beforeEach(nTestBedBeforeEach(
             [PlatformSpecificAttributeComponent, AndroidSpecificComponent, IosSpecificComponent],