Skip to content

Commit a738985

Browse files
committed
fix(router): export module loader, don't use it by default
1 parent dad72c1 commit a738985

File tree

2 files changed

+4
-11
lines changed

2 files changed

+4
-11
lines changed

Diff for: nativescript-angular/router.ts

+3-10
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
import { NgModule, ModuleWithProviders, NO_ERRORS_SCHEMA, NgModuleFactoryLoader } from "@angular/core";
1+
import { NgModule, ModuleWithProviders, NO_ERRORS_SCHEMA } from "@angular/core";
22
import { RouterModule, Routes, ExtraOptions } from "@angular/router";
33
import { LocationStrategy, PlatformLocation } from "@angular/common";
44
import { NSRouterLink } from "./router/ns-router-link";
@@ -8,7 +8,7 @@ import { NSLocationStrategy, LocationState } from "./router/ns-location-strategy
88
import { NativescriptPlatformLocation } from "./router/ns-platform-location";
99
import { RouterExtensions } from "./router/router-extensions";
1010
import { NativeScriptModule } from "./nativescript.module";
11-
import { NsModuleFactoryLoader } from "./router/ns-module-factory-loader";
11+
export { NSModuleFactoryLoader } from "./router/ns-module-factory-loader";
1212

1313
export { PageRoute } from "./router/page-router-outlet";
1414
export { RouterExtensions } from "./router/router-extensions";
@@ -42,14 +42,7 @@ export type LocationState = LocationState;
4242
})
4343
export class NativeScriptRouterModule {
4444
static forRoot(routes: Routes, config?: ExtraOptions): ModuleWithProviders {
45-
let moduleWithProviders = RouterModule.forRoot(routes, config);
46-
47-
// Override the stock SystemJsNgModuleLoader
48-
moduleWithProviders.providers.push(
49-
{ provide: NgModuleFactoryLoader, useClass: NsModuleFactoryLoader },
50-
);
51-
52-
return moduleWithProviders;
45+
return RouterModule.forRoot(routes, config);
5346
}
5447

5548
static forChild(routes: Routes): ModuleWithProviders {

Diff for: nativescript-angular/router/ns-module-factory-loader.ts

+1-1
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,7 @@ const FACTORY_CLASS_SUFFIX = "NgFactory";
1313
const FACTORY_PATH_SUFFIX = ".ngfactory";
1414

1515
@Injectable()
16-
export class NsModuleFactoryLoader implements NgModuleFactoryLoader {
16+
export class NSModuleFactoryLoader implements NgModuleFactoryLoader {
1717
private offlineMode: boolean;
1818

1919
constructor(private compiler: Compiler) {

0 commit comments

Comments
 (0)