Skip to content

Commit 5367830

Browse files
ADjenkovADjenkov
ADjenkov
authored and
ADjenkov
committed
chore: bump version to 7.2.2
1 parent 1a79f97 commit 5367830

File tree

3 files changed

+7
-8
lines changed

3 files changed

+7
-8
lines changed

Diff for: e2e/single-page/app/second/modal/modal.component.ts

+2-2
Original file line numberDiff line numberDiff line change
@@ -12,8 +12,8 @@ export class ModalComponent {
1212
constructor(private params: ModalDialogParams) {
1313
}
1414

15-
public close(result: string) {
16-
this.params.closeCallback(result);
15+
public close() {
16+
this.params.closeCallback();
1717
}
1818

1919
}

Diff for: nativescript-angular/package.json

+1-1
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
{
22
"name": "nativescript-angular",
3-
"version": "7.2.2",
3+
"version": "7.2.3",
44
"description": "An Angular renderer that lets you build mobile apps with NativeScript.",
55
"homepage": "https://www.nativescript.org/",
66
"bugs": "https://github.com/NativeScript/nativescript-angular/issues",

Diff for: nativescript-angular/router/ns-location-strategy.ts

+4-5
Original file line numberDiff line numberDiff line change
@@ -564,19 +564,18 @@ export class NSLocationStrategy extends LocationStrategy {
564564
}
565565

566566
findOutlet(outletKey: string, activatedRouteSnapshot?: ActivatedRouteSnapshot): Outlet {
567-
const that = this;
568567
let outlet: Outlet = this.outlets.find((currentOutlet) => {
569-
let equalModalDepth = currentOutlet.modalNavigationDepth === that._modalNavigationDepth;
570-
return currentOutlet.outletKeys.indexOf(outletKey) > -1 && equalModalDepth;
568+
let equalModalDepth = currentOutlet.modalNavigationDepth === this._modalNavigationDepth;
569+
return equalModalDepth && currentOutlet.outletKeys.indexOf(outletKey) > -1;
571570
});
572571

573572
// No Outlet with the given outletKey could happen when using nested unnamed p-r-o
574573
// primary -> primary -> prymary
575574
if (!outlet && activatedRouteSnapshot) {
576575
const pathByOutlets = this.getPathByOutlets(activatedRouteSnapshot);
577576
outlet = this.outlets.find((currentOutlet) => {
578-
let equalModalDepth = currentOutlet.modalNavigationDepth === that._modalNavigationDepth;
579-
return currentOutlet.pathByOutlets === pathByOutlets && equalModalDepth;
577+
let equalModalDepth = currentOutlet.modalNavigationDepth === this._modalNavigationDepth;
578+
return equalModalDepth && currentOutlet.pathByOutlets === pathByOutlets;
580579
});
581580
}
582581

0 commit comments

Comments
 (0)