fix: export NgView and NgElement from element-registry (#823)

reverts breaking change

Author: sis0k0

Diff for: nativescript-angular/animations/animation-driver.ts

@@ -1,6 +1,6 @@
 import { AnimationPlayer } from "@angular/animations";
 
-import { NgView } from "../element-types";
+import { NgView } from "../element-registry";
 import { NativeScriptAnimationPlayer } from "./animation-player";
 import { Keyframe } from "./utils";
 

Diff for: nativescript-angular/animations/animation-engine.ts

@@ -1,7 +1,7 @@
 import { ɵDomAnimationEngine as DomAnimationEngine } from "@angular/animations/browser";
 import { AnimationEvent, AnimationPlayer } from "@angular/animations";
 
-import { NgView } from "../element-types";
+import { NgView } from "../element-registry";
 import {
     copyArray,
     cssClasses,

Diff for: nativescript-angular/animations/animation-player.ts

@@ -4,7 +4,7 @@ import {
     KeyframeAnimationInfo,
 } from "tns-core-modules/ui/animation/keyframe-animation";
 
-import { NgView } from "../element-types";
+import { NgView } from "../element-registry";
 import { Keyframe, getAnimationCurve, parseAnimationKeyframe } from "./utils";
 
 export class NativeScriptAnimationPlayer implements AnimationPlayer {

Diff for: nativescript-angular/animations/dom-utils.ts

@@ -7,7 +7,7 @@ import {
 } from "@angular/animations";
 import { unsetValue } from "tns-core-modules/ui/core/view";
 
-import { NgView } from "../element-types";
+import { NgView } from "../element-registry";
 
 // overriden to use the default 'unsetValue'
 // instead of empty string ''

Diff for: nativescript-angular/directives/action-bar.ts

@@ -4,8 +4,11 @@ import { Page } from "tns-core-modules/ui/page";
 import { View } from "tns-core-modules/ui/core/view";
 
 import { isBlank } from "../lang-facade";
-import { registerElement } from "../element-registry";
-import { ViewClassMeta, NgView } from "../element-types";
+import {
+    NgView,
+    ViewClassMeta,
+    registerElement,
+} from "../element-registry";
 
 const actionBarMeta: ViewClassMeta = {
     skipAddToDom: true,

Diff for: nativescript-angular/directives/list-view-comp.ts

@@ -24,7 +24,7 @@ import { View, KeyedTemplate } from "tns-core-modules/ui/core/view";
 import { ObservableArray } from "tns-core-modules/data/observable-array";
 import { LayoutBase } from "tns-core-modules/ui/layouts/layout-base";
 
-import { CommentNode } from "../element-types";
+import { CommentNode } from "../element-registry";
 import { isListLikeIterable } from "../collection-facade";
 import { listViewLog, listViewError } from "../trace";
 

Diff for: nativescript-angular/directives/tab-view.ts

@@ -9,7 +9,7 @@ import {
 } from "@angular/core";
 import { TabView, TabViewItem } from "tns-core-modules/ui/tab-view";
 
-import { CommentNode } from "../element-types";
+import { CommentNode } from "../element-registry";
 import { rendererLog } from "../trace";
 import { isBlank } from "../lang-facade";
 

Diff for: nativescript-angular/element-registry.ts

@@ -1,4 +1,35 @@
-import { ViewClass, ViewClassMeta } from "./element-types";
+import { View } from "tns-core-modules/ui/core/view";
+
+export type NgView = (View & ViewExtensions);
+export type NgElement = NgView | CommentNode;
+
+export interface ViewExtensions {
+    nodeType: number;
+    nodeName: string;
+    templateParent: NgView;
+    ngCssClasses: Map<string, boolean>;
+    meta: ViewClassMeta;
+}
+
+export interface ViewClass {
+    new (): View;
+}
+
+// used for creating comments and text nodes in the renderer
+export class CommentNode {
+    meta: { skipAddToDom: true };
+    templateParent: NgView;
+}
+
+export interface ViewClassMeta {
+    skipAddToDom?: boolean;
+    insertChild?: (parent: NgView, child: NgView, atIndex: number) => void;
+    removeChild?: (parent: NgView, child: NgView) => void;
+}
+
+export function isDetachedElement(element): boolean {
+    return (element && element.meta && element.meta.skipAddToDom);
+}
 
 export type ViewResolver = () => ViewClass;
 

Diff for: nativescript-angular/element-types.ts

@@ -17,16 +17,13 @@ export * from "./view-util";
 export * from "./resource-loader";
 
 export {
+    ViewClass,
+    ViewClassMeta,
     ViewResolver,
-    registerElement,
     getViewClass,
     getViewMeta,
     isKnownView,
+    registerElement,
 } from "./element-registry";
 
-export {
-    ViewClass,
-    ViewClassMeta,
-} from "./element-types";
-
 export * from "./value-accessors/base-value-accessor";

Diff for: nativescript-angular/index.ts

@@ -12,7 +12,7 @@ import { topmost } from "tns-core-modules/ui/frame";
 import { APP_ROOT_VIEW, DEVICE, getRootPage } from "./platform-providers";
 import { isBlank } from "./lang-facade";
 import { ViewUtil } from "./view-util";
-import { NgView, CommentNode } from "./element-types";
+import { NgView, CommentNode } from "./element-registry";
 import { rendererLog as traceLog } from "./trace";
 
 // CONTENT_ATTR not exported from NativeScript_renderer - we need it for styles application.

Diff for: nativescript-angular/renderer.ts

@@ -4,18 +4,16 @@ import { Placeholder } from "tns-core-modules/ui/placeholder";
 import { ContentView } from "tns-core-modules/ui/content-view";
 import { LayoutBase } from "tns-core-modules/ui/layouts/layout-base";
 import {
+    CommentNode,
+    NgElement,
+    NgView,
+    ViewExtensions,
     getViewClass,
     getViewMeta,
+    isDetachedElement,
     isKnownView,
 } from "./element-registry";
 
-import {
-    CommentNode,
-    ViewExtensions,
-    NgElement,
-    NgView,
-    isDetachedElement,
-} from "./element-types";
 import { platformNames, Device } from "tns-core-modules/platform";
 import { rendererLog as traceLog } from "./trace";
 

Diff for: nativescript-angular/view-util.ts

@@ -2,7 +2,11 @@
 import {assert} from "./test-config";
 import {View} from "ui/core/view";
 import {ViewUtil} from "nativescript-angular/view-util";
-import {NgView, ViewExtensions, ViewClassMeta} from "nativescript-angular/element-types";
+import {
+    NgView,
+    ViewExtensions,
+    ViewClassMeta,
+} from "nativescript-angular/element-registry";
 import {Red} from "color/known-colors";
 import {device, platformNames} from "platform";
 import {createDevice} from "./test-utils";

Diff for: tests/app/tests/property-sets.ts

@@ -9,7 +9,7 @@ import { LayoutBase } from "ui/layouts/layout-base";
 import { StackLayout } from "ui/layouts/stack-layout";
 import { ContentView } from "ui/content-view";
 import { Button } from "ui/button";
-import { NgView } from "nativescript-angular/element-types";
+import { NgView } from "nativescript-angular/element-registry";
 
 @Component({
     template: `<StackLayout><Label text="Layout"></Label></StackLayout>`