Skip to content

Commit 409e717

Browse files
committed
refactor: stop exporting NativeScriptModule from platform (#701)
Importing NativeScriptModule from "nativescript-angular/platform" leads to including @angular/compiler in the bundle when doing AoT compilation with webpack. Import from "nativescript-angular/nativescript.module" should be used instead. BREAKING CHANGE: User applications cannot import NativeScriptModule from "nativescript-angular/platform" anymore. Migration: Before: ``` import { NativeScriptModule } from "nativescript-angular/platform"; ``` After ``` import { NativeScriptModule } from "nativescript-angular/nativescript.module"; ```
1 parent c7837ed commit 409e717

File tree

3 files changed

+3
-4
lines changed

3 files changed

+3
-4
lines changed

Diff for: nativescript-angular/platform.ts

-2
Original file line numberDiff line numberDiff line change
@@ -37,8 +37,6 @@ import "./dom-adapter";
3737
import { NativeScriptElementSchemaRegistry } from "./schema-registry";
3838
import { FileSystemResourceLoader } from "./resource-loader";
3939

40-
export { NativeScriptModule } from "./nativescript.module";
41-
4240
export const NS_COMPILER_PROVIDERS = [
4341
COMPILER_PROVIDERS,
4442
{

Diff for: tests/app/snippets/navigation/page-outlet.ts

+1-1
Original file line numberDiff line numberDiff line change
@@ -2,9 +2,9 @@ import { TestApp, registerTestApp } from "../../tests/test-app";
22
import { ApplicationRef } from "@angular/core";
33
import { Router, NavigationStart, NavigationEnd } from "@angular/router";
44
// >> page-outlet-example
5-
import { Component, NgModule } from "@angular/core";
65
import { platformNativeScriptDynamic } from "nativescript-angular/platform";
76
import { NativeScriptModule } from "nativescript-angular/nativescript.module";
7+
import { Component, NgModule } from '@angular/core';
88
import { NativeScriptRouterModule } from "nativescript-angular/router";
99

1010
import { routes } from "./app.routes";

Diff for: tests/app/tests/test-app.ts

+2-1
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,5 @@
1-
import { NativeScriptModule, platformNativeScriptDynamic } from "nativescript-angular/platform";
1+
import { platformNativeScriptDynamic } from "nativescript-angular/platform";
2+
import { NativeScriptModule } from "nativescript-angular/nativescript.module";
23
import { NativeScriptRouterModule } from "nativescript-angular/router";
34
import {
45
Type, Component, ComponentRef,

0 commit comments

Comments
 (0)