Merge branch 'master' into djenkov/location-strategy

Author: Alexander Vakrilov

Diff for: .github/ISSUE_TEMPLATE.md

@@ -1,7 +1,26 @@
-PSST! Want to get faster responses to bug reports and important issues? Help us keep the issue tracker organized by:
+### Make sure to check the existing issues in this repository 
 
-- Reporting bugs. Please include all details about the problem and provide a sample app (consider using the [playground](https://play.nativescript.org) for this.
-- Proposing features and enhancements.
-- Discussing implementation details.
+### If there is no issue for your problem, tell us about it
+Please, ensure your title is less than 63 characters long and starts with a capital
+letter.
 
-Please move all other content to the [forums](https://discourse.nativescript.org/).
+### Which platform(s) does your issue occur on?
+- iOS/Android/Both 
+- iOS/Android versions 
+- emulator or device. What type of device?
+
+### Please, provide the following version numbers that your issue occurs with:
+
+- CLI: (run `tns --version` to fetch it)
+- Cross-platform modules: (check the 'version' attribute in the
+`node_modules/tns-core-modules/package.json` file in your project)
+- Runtime(s): (look for the `"tns-android"` and `"tns-ios"` properties in the `package.json` file of your project)
+- Plugin(s): (look for the version numbers in the `package.json` file of your
+project and paste your dependencies and devDependencies here)
+
+### Please, tell us how to recreate the issue in as much detail as possible. 
+Describe the steps to reproduce it.
+
+### Is there any code involved? 
+ - provide a code example to recreate the problem 
+ - (EVEN BETTER) consider using the [playground](https://play.nativescript.org) to provide an application where the problem is reproducible. If this is not possible, provide a .zip with application or refer to a repository with application where the problem is reproducible.

Diff for: nativescript-angular/directives/dialogs.ts

@@ -78,19 +78,25 @@ export class ModalDialogService {
 
         this.location._beginModalNavigation(frame);
 
-        return new Promise(resolve => {
-            setTimeout(() => this._showDialog({
-                containerRef: viewContainerRef,
-                context,
-                doneCallback: resolve,
-                fullscreen,
-                animated,
-                stretched,
-                pageFactory,
-                parentView,
-                resolver,
-                type,
-            }), 10);
+        return new Promise((resolve, reject) => {
+            setTimeout(() => {
+                try {
+                    this._showDialog({
+                        containerRef: viewContainerRef,
+                        context,
+                        doneCallback: resolve,
+                        fullscreen,
+                        animated,
+                        stretched,
+                        pageFactory,
+                        parentView,
+                        resolver,
+                        type,
+                    });
+                } catch (err) {
+                    reject(err);
+                }
+            }, 10);
         });
     }