Merge pull request #1940 from NativeScript/svetoslavtsenov/update-appium-tests

chore: update appium tests to support ns-dev-appium 6.0.0

Author: SvetoslavTsenov

Diff for: e2e/animation-examples/e2e/pages/animations-with-default-options-page.ts

@@ -29,10 +29,10 @@ export class AnimationsWithDefaultOptionsPage extends BasePage {
     }
 
     private getItem(item) {
-        return this._driver.findElementByXPathIfExists(`${this._elementHelper.getXPathByTextAtributes("//*", "itemsContainer", true)}${this._elementHelper.getXPathByTextAtributes("//*", item, false)}`);
+        return this._driver.findElementByXPathIfExists(`${this._elementHelper.getXPathByTextAttributes("//*", "itemsContainer", true)}${this._elementHelper.getXPathByTextAttributes("//*", item, false)}`);
     }
 
-    async awaitItemToDissapear(item: string, wait: number = 3000) {
+    async awaitItemToDisappear(item: string, wait: number = 3000) {
         const startTime = Date.now();
         let btn = await this.getItem(item);
         while (btn && await btn.isDisplayed() && Date.now() - startTime <= wait) {
@@ -53,16 +53,16 @@ export class AnimationsWithDefaultOptionsPage extends BasePage {
     }
 
     async getChildren() {
-        const children: Array<UIElement> = await this._driver.findElementsByXPath(`${this._elementHelper.getXPathByTextAtributes("//*", "itemsContainer", true)}/*`);
+        const children: Array<UIElement> = await this._driver.findElementsByXPath(`${this._elementHelper.getXPathByTextAttributes("//*", "itemsContainer", true)}/*`);
         const orderedList: Array<UIElement> = await sort(children);
 
         return orderedList;
     }
 
-    async assertItemPosition(text: string, itemIndex: number, expctedElementsCount: number) {
+    async assertItemPosition(text: string, itemIndex: number, expectedElementsCount: number) {
         const children = this._children;
 
-        assert.isTrue(children.length === expctedElementsCount, `Expected items count: ${expctedElementsCount} is not as actual: ${children.length}`);
+        assert.isTrue(children.length === expectedElementsCount, `Expected items count: ${expectedElementsCount} is not as actual: ${children.length}`);
         const element = children[itemIndex];
         console.log("Element text: ", await element.text());
         const currentElementText = await element.text();

Diff for: e2e/animation-examples/e2e/pages/query-stagger-page.ts

@@ -21,18 +21,18 @@ export class QueryWithStaggerPage extends BasePage {
     }
 
     async getChildren() {
-        const children: Array<UIElement> = await this._driver.findElementsByXPath(`${this._elementHelper.getXPathByTextAtributes("//*", "container", true)}/*`);
+        const children: Array<UIElement> = await this._driver.findElementsByXPath(`${this._elementHelper.getXPathByTextAttributes("//*", "container", true)}/*`);
         const orderedList: Array<UIElement> = await sort(children);
 
         return orderedList;
     }
 
-    async assertItemPosition(text: string, itemIndex: number, expctedElementsCount: number) {
+    async assertItemPosition(text: string, itemIndex: number, expectedElementsCount: number) {
         const startTime = Date.now();
         let item = await this._driver.findElementByTextIfExists(text)
         while ((!item || !(await item.isDisplayed())) && Date.now() - startTime <= 3000) { }
         const children = await this.getChildren();
-        assert.isTrue(children.length === expctedElementsCount);
+        assert.isTrue(children.length === expectedElementsCount);
         const element = children[itemIndex];
         const elementText = await element.text();
         console.log("Element text: ", elementText);

Diff for: e2e/animation-examples/e2e/pages/selector-page.ts

@@ -10,7 +10,7 @@ export class SelectorPage extends BasePage {
 
     constructor(_driver: AppiumDriver) {
         super(_driver);
-        this._itemsContainerXpath = this._elementHelper.getXPathByTextAtributes("//*", "itemsContainer", true);
+        this._itemsContainerXpath = this._elementHelper.getXPathByTextAttributes("//*", "itemsContainer", true);
         this._itemsContainerChildrenXpath = `${this._itemsContainerXpath}/*`
     }
 
@@ -41,18 +41,18 @@ export class SelectorPage extends BasePage {
         return orderedList;
     }
 
-    async assertElementPossition(expctedElementsCount: number) {
+    async assertElementPosition(expectedElementsCount: number) {
         const children = await this.getChildren();
-        assert.isTrue(children.length === expctedElementsCount)
+        assert.isTrue(children.length === expectedElementsCount)
         for (let index = 0; index < children.length - 1; index++) {
             const element = children[index];
-            const el = await (<any>element.driver()).elementByXPathIfExists(this._elementHelper.getXPathByTextAtributes("//*", `Item No.${index}`, true));
+            const el = await (<any>element.driver()).elementByXPathIfExists(this._elementHelper.getXPathByTextAttributes("//*", `Item No.${index}`, true));
             console.log(await el.text());
             assert.isTrue(el && el !== null);
         }
     }
 
     private itemXpath(item) {
-        return `${this._itemsContainerXpath}${this._elementHelper.getXPathByTextAtributes("//*", item, false)}`;
+        return `${this._itemsContainerXpath}${this._elementHelper.getXPathByTextAttributes("//*", item, false)}`;
     }
 }

Diff for: e2e/animation-examples/e2e/smoke.e2e-spec.ts

@@ -55,14 +55,14 @@ describe("smoke-tests", async function () {
         await selectorPage.enterExample();
         await selectorPage.addItem();
         await selectorPage.waitItemToToggleVisibility("Item No.2", true);
-        await selectorPage.assertElementPossition(4);
+        await selectorPage.assertElementPosition(4);
 
         await selectorPage.clickOnItem("second");
         await selectorPage.waitItemToToggleVisibility("second", false);
-        await selectorPage.assertElementPossition(3);
+        await selectorPage.assertElementPosition(3);
     });
 
-    it("querry with stagger", async function () {
+    it("query with stagger", async function () {
         const queryWithStaggerPage = new QueryWithStaggerPage(driver);
         await queryWithStaggerPage.enterExample();
         await queryWithStaggerPage.addItem();
@@ -103,7 +103,7 @@ describe("smoke-tests", async function () {
 
         await animationWithOptionsPage.clickOnItem("Harley Quinn");
         examplesCount--;
-        await animationWithOptionsPage.awaitItemToDissapear("Harley Quinn");
+        await animationWithOptionsPage.awaitItemToDisappear("Harley Quinn");
         await animationWithOptionsPage.assertItemPosition("Wonder Woman", 1, examplesCount);
         await animationWithOptionsPage.assertItemPosition("Joker", 2, examplesCount);
         await animationWithOptionsPage.assertItemPosition("Aquaman", 3, examplesCount);

Diff for: tests/package.json

@@ -29,7 +29,7 @@
     "@angular/platform-browser-dynamic": "~8.1.0",
     "@angular/router": "~8.1.0",
     "nativescript-angular": "../nativescript-angular",
-    "nativescript-unit-test-runner": "~0.6.3",
+    "nativescript-unit-test-runner": "0.7.0",
     "rxjs": "~6.3.3",
     "tns-core-modules": "next",
     "zone.js": "^0.9.1"