Skip to content

Commit 9579532

Browse files
committed
fix(build): Do not strip local symbols from NativeScript.framework
Stripping them reduces .ipa size with about 900kb but native stacktraces become significantly less readable without dSYMs. Although Crashlytics and Xcode can use the dSYMs, stack unwinds in application code cannot use them (as they are missing from the device) and remain unsymbolicated.
1 parent fa3fefb commit 9579532

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

build/scripts/build-nativescript-framework.sh

+1-1
Original file line numberDiff line numberDiff line change
@@ -25,7 +25,7 @@ cp -r "$WORKSPACE/cmake-build/src/NativeScript/$CONFIGURATION-iphoneos/NativeScr
2525
rm "NativeScript.framework/NativeScript"
2626

2727
# Strip debug information, dSYM package must be used for debugging and symbolicating
28-
strip -S -x "$WORKSPACE/cmake-build/src/NativeScript/$CONFIGURATION-iphonesimulator/NativeScript.framework/NativeScript" \
28+
strip -S "$WORKSPACE/cmake-build/src/NativeScript/$CONFIGURATION-iphonesimulator/NativeScript.framework/NativeScript" \
2929
"$WORKSPACE/cmake-build/src/NativeScript/$CONFIGURATION-iphoneos/NativeScript.framework/NativeScript"
3030
echo "CodeSign $WORKSPACE/cmake-build/src/NativeScript/$CONFIGURATION-iphonesimulator/NativeScript.framework/NativeScript"
3131

0 commit comments

Comments
 (0)