Skip to content

Why method_id is generated in index.js #31

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
zahhak opened this issue Dec 27, 2017 · 1 comment
Open

Why method_id is generated in index.js #31

zahhak opened this issue Dec 27, 2017 · 1 comment

Comments

@zahhak
Copy link

zahhak commented Dec 27, 2017

I wonder why method_id (or id) is generated in the index.js
As far as I see it is mainly used as correlation_id for the communication channel (I wonder why it is not named like this).
If this is the case - why it is not managed by the IOSDeviceLibStdioHandler?

@zahhak
Copy link
Author

zahhak commented Dec 27, 2017

Ignoring the code design, If the events are managed by the IOSDeviceLibStdioHandler we will be able to avoid the execution of the following if on every incoming data message
https://github.com/telerik/ios-device-lib/blob/382c9c63dd1999ef247def16a3787b5987d63649/index.js#L110

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant