fix: add timeout when receiving message from connection

All socket connections were changed and now are started in ssl mode. This changes the way messages are sent and received from sockets. As a result, `timeout` option is not anymore respected when receiving messages from socket. However, the messages now are received only via methods from mobile device lib. As there isn't a built-in method in mobile device that can work with timeout, we implemented timeout mechanism using new thread. `AMDServiceConnectionReceive` blocks the current thread when application is not running on device. After the provided timeout, the socket connection is invalidated and this way the current thread is freed.

Author: Fatme

IOSDeviceLib/Declarations.h

@@ -267,6 +267,7 @@ extern "C"
 {
 	CFSocketNativeHandle  AMDServiceConnectionGetSocket(ServiceConnRef con);
 	long AMDServiceConnectionReceive(ServiceConnRef, void *, long);
+    void AMDServiceConnectionInvalidate(ServiceConnRef);
 	long AMDServiceConnectionSendMessage(ServiceConnRef serviceConnection, CFDictionaryRef message, CFPropertyListFormat format);
 	unsigned AMDeviceSecureStartService(AMDeviceRef device, CFStringRef service_name, unsigned int *unknown, ServiceConnRef * handle);
 	unsigned AMDeviceNotificationSubscribe(void(*f)(const DevicePointer*), long, long, long, HANDLE*);

IOSDeviceLib/IOSDeviceLib.cpp

@@ -1007,7 +1007,7 @@ void get_application_infos(std::string device_identifier, std::string method_id)
 	std::vector<json> livesync_app_infos;
 	while (true)
 	{
-		std::map<std::string, boost::any> dict = receive_con_message(serviceInfo.connection);
+		std::map<std::string, boost::any> dict = receive_con_message(serviceInfo.connection, device_identifier, method_id, 0);
 		PRINT_ERROR_AND_RETURN_IF_FAILED_RESULT(dict.count(kErrorKey), boost::any_cast<std::string>(dict[kErrorKey]).c_str(), device_identifier, method_id);
 		if (dict.empty() || (dict.count(kStatusKey) && has_complete_status(dict)))
 		{
@@ -1181,7 +1181,7 @@ void await_notification_response(std::string device_identifier, AwaitNotificatio
 	PRINT_ERROR_AND_RETURN_IF_FAILED_RESULT(connection == nullptr, invalid_connection_error_message.c_str(), device_identifier, method_id);
 
 	ServiceInfo currentNotificationProxy = devices[device_identifier].services[kNotificationProxy];
-	std::map<std::string, boost::any> response = receive_con_message(connection);
+	std::map<std::string, boost::any> response = receive_con_message(connection, device_identifier, method_id, await_notification_response_info.timeout);
 	if (response.size())
 	{
 		PRINT_ERROR_AND_RETURN_IF_FAILED_RESULT(response.count(kErrorKey), boost::any_cast<std::string>(response[kErrorKey]).c_str(), device_identifier, method_id);

IOSDeviceLib/SocketHelper.cpp

@@ -7,10 +7,26 @@
 #include "PlistCpp/Plist.hpp"
 #include "PlistCpp/PlistDate.hpp"
 
+void setTimeout(std::function<void()> operation, int timeout) {
+    std::thread([=]() {
+        std::this_thread::sleep_for(std::chrono::milliseconds(timeout * 1000));
+        operation();
+    }).detach();
+}
+
 std::mutex receive_con_message_mutex;
-std::map<std::string, boost::any> receive_con_message(ServiceConnRef con)
+std::map<std::string, boost::any> receive_con_message(ServiceConnRef con, std::string device_identifier, std::string method_id, int timeout)
 {
     receive_con_message_mutex.lock();
+    
+    bool isSuccessful = false;
+    
+    setTimeout([=]() {
+        if (!isSuccessful) {
+            AMDServiceConnectionInvalidate(con);
+        }
+    }, timeout);
+    
     std::map<std::string, boost::any> dict;
     char *buffer = new char[4];
     int bytes_read = AMDServiceConnectionReceive(con, buffer, 4);
@@ -23,6 +39,7 @@ std::map<std::string, boost::any> receive_con_message(ServiceConnRef con)
         if (bytes_read > 0)
         {
             Plist::readPlist(buffer, res, dict);
+            isSuccessful = true;
         }
     }
 

IOSDeviceLib/SocketHelper.h

@@ -41,7 +41,7 @@ LengthEncodedMessage get_message_with_encoded_length(const char* message, long l
 int send_message(const char* message, SOCKET socket, long long length = -1);
 int send_message(std::string message, SOCKET socket, long long length = -1);
 long send_con_message(HANDLE* serviceConnection, CFDictionaryRef message);
-std::map<std::string, boost::any> receive_con_message(HANDLE* con);
+std::map<std::string, boost::any> receive_con_message(HANDLE* con, std::string device_identifier, std::string method_id, int timeout);
 std::map<std::string, boost::any> receive_message(SOCKET socket, int timeout = 5);
 std::string receive_message_raw(SOCKET socket, int size = 1000);