Apply suggestions from code review

Fatme · Dimitar Tachev · web-flow · commit 462e68a912d8 · 2019-08-28T16:46:05.000+03:00
Co-Authored-By: Dimitar Tachev &lt;dimitar.tachev@telerik.com&gt;
diff --git a/IOSDeviceLib/Declarations.h b/IOSDeviceLib/Declarations.h
@@ -267,7 +267,7 @@ extern "C"
 {
 	CFSocketNativeHandle  AMDServiceConnectionGetSocket(ServiceConnRef con);
 	long AMDServiceConnectionReceive(ServiceConnRef, void *, long);
-    void AMDServiceConnectionInvalidate(ServiceConnRef);
+	void AMDServiceConnectionInvalidate(ServiceConnRef);
 	long AMDServiceConnectionSendMessage(ServiceConnRef serviceConnection, CFDictionaryRef message, CFPropertyListFormat format);
 	unsigned AMDeviceSecureStartService(AMDeviceRef device, CFStringRef service_name, unsigned int *unknown, ServiceConnRef * handle);
 	unsigned AMDeviceNotificationSubscribe(void(*f)(const DevicePointer*), long, long, long, HANDLE*);
diff --git a/IOSDeviceLib/IOSDeviceLib.cpp b/IOSDeviceLib/IOSDeviceLib.cpp
@@ -1002,7 +1002,7 @@ void get_application_infos(std::string device_identifier, std::string method_id)
 	std::vector<json> livesync_app_infos;
 	while (true)
 	{
-		std::map<std::string, boost::any> dict = receive_con_message(serviceInfo.connection, device_identifier, method_id, 0);
+		std::map<std::string, boost::any> dict = receive_con_message(serviceInfo.connection, device_identifier, method_id, 10);
 		PRINT_ERROR_AND_RETURN_IF_FAILED_RESULT(dict.count(kErrorKey), boost::any_cast<std::string>(dict[kErrorKey]).c_str(), device_identifier, method_id);
 		if (dict.empty() || (dict.count(kStatusKey) && has_complete_status(dict)))
 		{

Original file line number	Diff line number	Diff line change
`@@ -267,7 +267,7 @@ extern "C"`
`267`	`267`	`{`
`268`	`268`	`CFSocketNativeHandle AMDServiceConnectionGetSocket(ServiceConnRef con);`
`269`	`269`	`long AMDServiceConnectionReceive(ServiceConnRef, void *, long);`
`270`		`- void AMDServiceConnectionInvalidate(ServiceConnRef);`
	`270`	`+ void AMDServiceConnectionInvalidate(ServiceConnRef);`
`271`	`271`	`long AMDServiceConnectionSendMessage(ServiceConnRef serviceConnection, CFDictionaryRef message, CFPropertyListFormat format);`
`272`	`272`	`unsigned AMDeviceSecureStartService(AMDeviceRef device, CFStringRef service_name, unsigned int unknown, ServiceConnRef handle);`
`273`	`273`	`unsigned AMDeviceNotificationSubscribe(void(f)(const DevicePointer), long, long, long, HANDLE*);`
Original file line number	Diff line number	Diff line change
`@@ -1002,7 +1002,7 @@ void get_application_infos(std::string device_identifier, std::string method_id)`
`1002`	`1002`	`std::vector<json> livesync_app_infos;`
`1003`	`1003`	`while (true)`
`1004`	`1004`	`{`
`1005`		`- std::map<std::string, boost::any> dict = receive_con_message(serviceInfo.connection, device_identifier, method_id, 0);`
	`1005`	`+ std::map<std::string, boost::any> dict = receive_con_message(serviceInfo.connection, device_identifier, method_id, 10);`
`1006`	`1006`	`PRINT_ERROR_AND_RETURN_IF_FAILED_RESULT(dict.count(kErrorKey), boost::any_cast<std::string>(dict[kErrorKey]).c_str(), device_identifier, method_id);`
`1007`	`1007`	`if (dict.empty() \|\| (dict.count(kStatusKey) && has_complete_status(dict)))`
`1008`	`1008`	`{`