Skip to content
This repository was archived by the owner on Nov 17, 2022. It is now read-only.

Commit 92239a6

Browse files
authored
Merge pull request #1249 from NativeScript/tsonevn_improvebtn
hiding the second improve btn from JS and NG SDK examples
2 parents d6ae3f8 + e86c24d commit 92239a6

File tree

2 files changed

+6
-2
lines changed

2 files changed

+6
-2
lines changed

build/_assets/stylesheets/styles.css

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -759,6 +759,9 @@ div.right-nav__links .ns-button {
759759
margin-top: 1.56em;
760760
display: block;
761761
}
762+
.hide {
763+
display: none !important;
764+
}
762765

763766
.right-nav__links a:not(.ns-button) > i {
764767
margin-right: .2em;

build/_plugins/improvethis_generator.rb

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -7,9 +7,10 @@ def generate(site)
77

88
site.pages.each do |page|
99
pageImproveThisUrl = getPageImproveThisUrl(page)
10-
if pageImproveThisUrl.nil? || pageImproveThisUrl.length == 0
10+
regexexp = /(?i)(?:ns-ui-widgets|ng-ui-widgets|ns-framework-modules|ng-framework-modules|ns-hardware-access|ng-hardware-access|common-screens)/;
11+
if pageImproveThisUrl.nil? || pageImproveThisUrl.length == 0 || (!(page.path.match(regexexp).nil?))
1112
page.data['improvethisurl'] = ''
12-
page.data['improvethisvisibilityclass'] = '-hidden'
13+
page.data['improvethisvisibilityclass'] = 'hide'
1314
else
1415
page.data['improvethisurl'] = pageImproveThisUrl
1516
page.data['improvethisvisibilityclass'] = ''

0 commit comments

Comments
 (0)