Skip to content

fix(text-view): only reload text if hint is showing on ios #8662

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

dosomder
Copy link
Contributor

@dosomder dosomder commented Jun 22, 2020

PR Checklist

What is the current behavior?

iOS TextView reloads text every time the TextView is focused

What is the new behavior?

Only reload text if necessary (i.e. previously was the hint shown)

Fixes/Implements/Closes #8620

@cla-bot cla-bot bot added the cla: yes label Jun 22, 2020
@dosomder dosomder force-pushed the fix-ios-text-view-reloading branch from 21d2682 to 615b6ec Compare June 22, 2020 10:46
@dosomder dosomder force-pushed the fix-ios-text-view-reloading branch from 615b6ec to 830b012 Compare June 24, 2020 07:01
@dosomder
Copy link
Contributor Author

@NathanWalker rebased on master to fix merge conflicts

@NathanWalker
Copy link
Contributor

Thanks @dosomder

@dosomder
Copy link
Contributor Author

@NathanWalker Do you know when this is planned to be merged / released?

@NathanWalker NathanWalker merged commit ec17727 into NativeScript:master Jun 30, 2020
@NathanWalker
Copy link
Contributor

This will go out this week in a patch update 👍

@dosomder
Copy link
Contributor Author

dosomder commented Jul 5, 2020

Looking forward to the release 👍

@NathanWalker
Copy link
Contributor

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[ios] text is reloaded when entering text view
2 participants