Skip to content

ActionItem with *ngIf throws an error when it's removed #4691

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
madakk opened this issue Aug 13, 2017 · 2 comments
Closed

ActionItem with *ngIf throws an error when it's removed #4691

madakk opened this issue Aug 13, 2017 · 2 comments

Comments

@madakk
Copy link

madakk commented Aug 13, 2017

Looks like this is happening because ActionItems.removeItems calls _removeView directly:

this._actionBar._removeView(item);

But the nativescript angular handler has already removed the view (due to the same *ngIf directive) causing the error.

I believe this can be fixed by simply checking that the item's parent is actually the actionBar before attempting to remove it.

@tsonevn
Copy link
Contributor

tsonevn commented Aug 14, 2017

This issue was moved to NativeScript/nativescript-angular#942

@lock
Copy link

lock bot commented Aug 28, 2019

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot locked and limited conversation to collaborators Aug 28, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants