Updates requested in the review:

  - Added comment explaining the LVSA summary unload
  - Removal of obsolete logging
  - Fixed typos

Author: marek-trtik

src/taint-analysis/taint_summary.cpp

@@ -1733,6 +1733,19 @@ void taint_summarise_all_functions(
 
   auto start_time=std::chrono::high_resolution_clock::now();
 
+  // In the map 'lvsadb_flush_ref_counts' there we store for each function
+  // in the inverted topological order two information:
+  //    - reference count (how many callers the function has)
+  //    - names of the callees
+  // where both information are considered w.r.t. the inverted topological
+  // order. Namely, considered are only recursive calls to predecessors in the
+  // topological order.
+  // We use the map for unloading not needed LVSA summaries from the memory
+  // (but they are saved on the disk). An LVSA summary of a given function
+  // is not needed at a given position in the inverted topological order of
+  // functions, if none of the remaining function (i.e. those after the position
+  // in the order) is a caller of the given function w.r.t the inverted
+  // topological order.
   typedef std::pair<std::size_t, std::unordered_set<irep_idt>>
           refcount_and_calleest;
   std::unordered_map<irep_idt, refcount_and_calleest> lvsadb_flush_ref_counts;
@@ -1845,7 +1858,6 @@ void taint_summarise_all_functions(
         --elem.first;
         if(elem.first == 0UL)
         {
-          std::cout << "@@@   Trying to flush: " << succ << std::endl;
           const bool unloaded = lvsa_db.unload(succ);
           INVARIANT(unloaded || skipped.count(succ) != 0UL,
                     "Either the LVSA summary was unloaded or there was "

src/util/cached_map.h

@@ -514,10 +514,10 @@ class cached_mapt final
   Function: cached_mapt::unload(const key_type &)
 
   Inputs:
-    key: A key whose corresponding value should be unload.
+    key: A key whose corresponding value should be unloaded.
 
   Outputs:
-   True, if the referenced element was unload, and false otherwise.
+   True, if the referenced element was unloaded, and false otherwise.
 
   Purpose:
     Unloads the element referenced by the passed key in the cache to allow the