Remove goto_convertt::lookup

This was a hardly used wrapper.

Author: tautschnig

src/goto-programs/goto_convert.cpp

@@ -668,7 +668,7 @@ void goto_convertt::convert_decl(
 
   const irep_idt &identifier=op0.get(ID_identifier);
 
-  const symbolt &symbol=lookup(identifier);
+  const symbolt &symbol = ns.lookup(identifier);
 
   if(symbol.is_static_lifetime ||
      symbol.type.id()==ID_code)
@@ -2067,17 +2067,6 @@ void goto_convertt::new_name(symbolt &symbol)
   symbol_table.add(symbol);
 }
 
-const symbolt &goto_convertt::lookup(const irep_idt &identifier)
-{
-  const symbolt *symbol;
-  if(ns.lookup(identifier, symbol))
-  {
-    error() << "failed to find symbol " << identifier << eom;
-    throw 0;
-  }
-  return *symbol;
-}
-
 void goto_convert(
   const codet &code,
   symbol_table_baset &symbol_table,

src/goto-programs/goto_convert_class.h

@@ -57,7 +57,6 @@ class goto_convertt:public messaget
   // tools for symbols
   //
   void new_name(symbolt &symbol);
-  const symbolt &lookup(const irep_idt &identifier);
 
   symbolt &new_tmp_symbol(
     const typet &type,

src/goto-programs/goto_convert_side_effect.cpp

@@ -377,7 +377,7 @@ void goto_convertt::remove_function_call(
   if(expr.op0().id()==ID_symbol)
   {
     const irep_idt &identifier=expr.op0().get(ID_identifier);
-    const symbolt &symbol=lookup(identifier);
+    const symbolt &symbol = ns.lookup(identifier);
 
     std::string new_base_name=id2string(new_symbol.base_name);