Skip to content

Commit bd2547a

Browse files
author
Daniel Kroening
authored
Merge pull request diffblue#2458 from tautschnig/vs-long-long
Use long-long integer constant as the left-hand side is long long
2 parents 6adcebc + 4c6fc61 commit bd2547a

File tree

1 file changed

+7
-7
lines changed

1 file changed

+7
-7
lines changed

src/util/mp_arith.cpp

Lines changed: 7 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -262,7 +262,7 @@ mp_integer arith_left_shift(
262262
llong_t result=a.to_long()<<shift;
263263
llong_t mask=
264264
true_size<(sizeof(llong_t)*8) ?
265-
(1L<<true_size)-1 :
265+
(1LL << true_size) - 1 :
266266
-1;
267267
return result&mask;
268268
}
@@ -281,8 +281,8 @@ mp_integer arith_right_shift(
281281
if(shift>true_size)
282282
throw "shift value out of range";
283283

284-
llong_t sign=(1<<(true_size-1))&number;
285-
llong_t pad=(sign==0) ? 0 : ~((1<<(true_size-shift))-1);
284+
const llong_t sign = (1LL << (true_size - 1)) & number;
285+
const llong_t pad = (sign == 0) ? 0 : ~((1LL << (true_size - shift)) - 1);
286286
llong_t result=(number >> shift)|pad;
287287
return result;
288288
}
@@ -302,8 +302,8 @@ mp_integer logic_left_shift(
302302
llong_t result=a.to_long()<<shift;
303303
if(true_size<(sizeof(llong_t)*8))
304304
{
305-
llong_t sign=(1L<<(true_size-1))&result;
306-
llong_t mask=(1L<<true_size)-1;
305+
const llong_t sign = (1LL << (true_size - 1)) & result;
306+
const llong_t mask = (1LL << true_size) - 1;
307307
// Sign-fill out-of-range bits:
308308
if(sign==0)
309309
result&=mask;
@@ -345,7 +345,7 @@ mp_integer rotate_right(
345345
throw "shift value out of range";
346346

347347
ullong_t revShift=true_size-shift;
348-
ullong_t filter=1<<(true_size-1);
348+
const ullong_t filter = 1ULL << (true_size - 1);
349349
ullong_t result=(number >> shift)|((number<<revShift)&filter);
350350
return result;
351351
}
@@ -365,7 +365,7 @@ mp_integer rotate_left(
365365
throw "shift value out of range";
366366

367367
ullong_t revShift=true_size-shift;
368-
ullong_t filter=1<<(true_size-1);
368+
const ullong_t filter = 1ULL << (true_size - 1);
369369
ullong_t result=((number<<shift)&filter)|((number&filter) >> revShift);
370370
return result;
371371
}

0 commit comments

Comments
 (0)