Merge pull request diffblue#2540 from tautschnig/vs-explicit-cast

Explicit type cast to avoid signed/unsigned warning

Author: Daniel Kroening

jbmc/src/java_bytecode/object_factory_parameters.h

@@ -15,7 +15,8 @@ Author: Daniel Kroening, [email protected]
 #include <util/irep.h>
 
 #define MAX_NONDET_ARRAY_LENGTH_DEFAULT 5
-#define MAX_NONDET_STRING_LENGTH std::numeric_limits<std::int32_t>::max()
+#define MAX_NONDET_STRING_LENGTH \
+  static_cast<std::size_t>(std::numeric_limits<std::int32_t>::max())
 #define MAX_NONDET_TREE_DEPTH 5
 #define MAX_NONNULL_TREE_DEPTH 0
 

src/solvers/sat/satcheck_minisat2.cpp

@@ -14,6 +14,7 @@ Author: Daniel Kroening, [email protected]
 #include <unistd.h>
 #endif
 
+#include <limits>
 #include <stack>
 
 #include <util/invariant.h>
@@ -28,7 +29,9 @@ Author: Daniel Kroening, [email protected]
 
 void convert(const bvt &bv, Minisat::vec<Minisat::Lit> &dest)
 {
-  dest.capacity(bv.size());
+  PRECONDITION(
+    bv.size() <= static_cast<std::size_t>(std::numeric_limits<int>::max()));
+  dest.capacity(static_cast<int>(bv.size()));
 
   forall_literals(it, bv)
     if(!it->is_false())