Add documentation to typet

Author: svorenova

src/util/type.cpp

@@ -1,27 +1,38 @@
 /*******************************************************************\
 
-Module:
+Module: Implementations of some functions of typet
 
 Author: Daniel Kroening, [email protected]
+        Maria Svorenova, [email protected]
 
 \*******************************************************************/
 
+/// \file
+/// Implementations of some functions of typet
+
 #include "type.h"
 #include "std_types.h"
 #include "namespace.h"
 
+/// Copy the provided type to the subtypes of this type.
+/// \param type The type to add to subtypes
 void typet::copy_to_subtypes(const typet &type)
 {
   subtypes().push_back(type);
 }
 
+/// Move the provided type to the subtypes of this type. Destroys the
+/// provided type.
+/// \param type The type to add to subtypes
 void typet::move_to_subtypes(typet &type)
 {
   subtypest &sub=subtypes();
   sub.push_back(static_cast<const typet &>(get_nil_irep()));
   sub.back().swap(type);
 }
 
+/// Returns true if the type is a rational, real, integer, natural, complex,
+/// unsignedbv, signedbv, floatbv or fixedbv.
 bool is_number(const typet &type)
 {
   const irep_idt &id=type.id();
@@ -36,8 +47,9 @@ bool is_number(const typet &type)
          id==ID_fixedbv;
 }
 
-/// Identify if a given type is constant itself or
-/// contains constant components. Examples include:
+/// Identify whether a given type is constant itself or contains constant
+/// components.
+/// Examples include:
 ///  - const int a;
 ///  - struct contains_constant_pointer {  int x; int * const p; };
 ///  - const int b[3];

src/util/type.h

@@ -1,11 +1,14 @@
 /*******************************************************************\
 
-Module:
+Module: Defines typet, type_with_subtypet and type_with_subtypest
 
 Author: Daniel Kroening, [email protected]
+        Maria Svorenova, [email protected]
 
 \*******************************************************************/
 
+/// \file
+/// Defines typet, type_with_subtypet and type_with_subtypest
 
 #ifndef CPROVER_UTIL_TYPE_H
 #define CPROVER_UTIL_TYPE_H
@@ -17,8 +20,11 @@ Author: Daniel Kroening, [email protected]
 
 class namespacet;
 
-/*! \brief The type of an expression
-*/
+/// The type of an expression, extends irept. Types may have subtypes. This is
+/// modeled with two subs named “subtype” (a single type) and “subtypes”
+/// (a vector of types). The class typet only adds specialized methods
+/// for accessing the subtype information to the interface of irept.
+/// For pre-defined types see `std_types.h`.
 class typet:public irept
 {
 public:
@@ -90,7 +96,7 @@ class typet:public irept
   { remove(ID_subtype); }
   #endif
 
-  void move_to_subtypes(typet &type); // destroys expr
+  void move_to_subtypes(typet &type);
 
   void copy_to_subtypes(const typet &type);
 
@@ -115,6 +121,7 @@ class typet:public irept
   }
 };
 
+/// Type with a single subtype.
 class type_with_subtypet:public typet
 {
 public:
@@ -136,6 +143,7 @@ class type_with_subtypet:public typet
   #endif
 };
 
+/// Type with multiple subtypes.
 class type_with_subtypest:public typet
 {
 public:
@@ -169,43 +177,8 @@ class type_with_subtypest:public typet
     for(typet::subtypest::iterator it=(type).subtypes().begin(); \
         it!=(type).subtypes().end(); ++it)
 
-/*
-
-pre-defined types:
-  universe      // super type
-  type          // another type
-  predicate     // predicate expression (subtype and predicate)
-  uninterpreted // uninterpreted type with identifier
-  empty         // void
-  bool          // true or false
-  abstract      // abstract super type
-  struct        // with components: each component has name and type
-                // the ordering matters
-  rational
-  real
-  integer
-  complex
-  string
-  enum          // with elements
-                // the ordering does not matter
-  tuple         // with components: each component has type
-                // the ordering matters
-  mapping       // domain -> range
-  bv            // no interpretation
-  unsignedbv
-  signedbv      // two's complement
-  floatbv       // IEEE floating point format
-  code
-  pointer       // for ANSI-C (subtype)
-  symbol        // look in symbol table (identifier)
-  number        // generic number super type
-
-*/
-
 bool is_number(const typet &type);
-// rational, real, integer, complex, unsignedbv, signedbv, floatbv
 
-// Is the passed in type const qualified?
 bool is_constant_or_has_constant_components(
     const typet &type,
     const namespacet &ns);