Deprecates add_axioms_for_is_suffix

We can get the same result using is_prefix with an offset which is the
difference of the two lengths.

Author: romainbrenguier

src/solvers/README.md

@@ -231,9 +231,6 @@ allocates a new string before calling a primitive.
   * `cprover_string_is_prefix` :
   \copybrief string_constraint_generatort::add_axioms_for_is_prefix
   \link string_constraint_generatort::add_axioms_for_is_prefix More... \endlink
-  * `cprover_string_is_suffix` :
-  \copybrief string_constraint_generatort::add_axioms_for_is_suffix
-  \link string_constraint_generatort::add_axioms_for_is_suffix More... \endlink
   * `cprover_string_index_of` :
   \copybrief string_constraint_generatort::add_axioms_for_index_of(const function_application_exprt &f)
   \link string_constraint_generatort::add_axioms_for_index_of(const function_application_exprt &f) More... \endlink
@@ -319,6 +316,8 @@ allocates a new string before calling a primitive.
   * `cprover_string_intern` : Never tested.
   * `cprover_string_is_empty` :
     Should use `cprover_string_length(s) == 0` instead.
+  * `cprover_string_is_suffix` : Should use `cprover_string_is_prefix` with an
+   offset argument.
   * `cprover_string_empty_string` : Can use literal of empty string instead.
   * `cprover_string_of_long` : Should be the same as `cprover_string_of_int`.
   * `cprover_string_delete_char_at` : A call to

src/solvers/refinement/string_constraint_generator_testing.cpp

@@ -135,6 +135,7 @@ exprt string_constraint_generatort::add_axioms_for_is_empty(
 /// \param swap_arguments: boolean flag telling whether the suffix is the second
 ///        argument or the first argument
 /// \return Boolean expression `issuffix`
+DEPRECATED("should use `strings_startwith(s0, s1, s1.length - s0.length)`")
 exprt string_constraint_generatort::add_axioms_for_is_suffix(
   const function_application_exprt &f, bool swap_arguments)
 {