Remove GOTO_CHECK options from JBMC

Author: peterschrammel

jbmc/regression/jbmc/NullPointer1/test.desc

@@ -1,6 +1,6 @@
 CORE
 NullPointer1.class
---pointer-check --stop-on-fail
+--stop-on-fail
 ^EXIT=10$
 ^SIGNAL=0$
 ^  file NullPointer1.java line 16 function java::NullPointer1.main:\(\[Ljava/lang/String;\)V bytecode-index 9$

jbmc/regression/jbmc/NullPointer2/test.desc

@@ -1,6 +1,6 @@
 CORE
 NullPointer2.class
---pointer-check --stop-on-fail
+--stop-on-fail
 ^EXIT=10$
 ^SIGNAL=0$
 ^  file NullPointer2.java line 9 function java::NullPointer2.main:\(\[Ljava/lang/String;\)V

jbmc/regression/jbmc/NullPointer3/test.desc

@@ -1,6 +1,6 @@
 CORE
 NullPointer3.class
---pointer-check
+
 ^EXIT=10$
 ^SIGNAL=0$
 ^.*Null pointer check: FAILURE$

jbmc/regression/jbmc/NullPointer4/test.desc

@@ -1,6 +1,6 @@
 CORE
 NullPointer4.class
---pointer-check --stop-on-fail
+--stop-on-fail
 ^EXIT=10$
 ^SIGNAL=0$
 ^  file NullPointer4.java line 6 function java::NullPointer4.main:\(\[Ljava/lang/String;\)V bytecode-index 4$

jbmc/regression/jbmc/pointer_check1/test.desc

@@ -1,6 +1,6 @@
 CORE
 pointer_check1.class
---pointer-check
+
 ^EXIT=10$
 ^SIGNAL=0$
 ^VERIFICATION FAILED$

jbmc/regression/jbmc/static_method1/test.desc

@@ -1,6 +1,6 @@
 CORE
 static_method1.class
---function 'static_method1.f' --div-by-zero-check
+--function 'static_method1.f'
 ^EXIT=10$
 ^SIGNAL=0$
 ^VERIFICATION FAILED$

jbmc/src/jbmc/jbmc_parse_options.cpp

@@ -1098,7 +1098,6 @@ void jbmc_parse_optionst::help()
     HELP_SHOW_CLASS_HIERARCHY
     "\n"
     "Program instrumentation options:\n"
-    HELP_GOTO_CHECK
     " --no-assertions              ignore user assertions\n"
     " --no-assumptions             ignore user assumptions\n"
     " --error-label label          check that label is unreachable\n"

jbmc/src/jbmc/jbmc_parse_options.h

@@ -47,7 +47,6 @@ class optionst;
   "(document-subgoals)(outfile):" \
   "(object-bits):" \
   "(classpath):(cp):(main-class):" \
-  OPT_GOTO_CHECK \
   "(no-assertions)(no-assumptions)" \
   "(no-built-in-assertions)" \
   "(xml-ui)(json-ui)" \